From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92F9CA9EC0 for ; Mon, 28 Oct 2019 18:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 982C321721 for ; Mon, 28 Oct 2019 18:39:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W9XRu8s6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728440AbfJ1SjP (ORCPT ); Mon, 28 Oct 2019 14:39:15 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:34789 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbfJ1SjO (ORCPT ); Mon, 28 Oct 2019 14:39:14 -0400 Received: by mail-ot1-f65.google.com with SMTP id m19so7554811otp.1 for ; Mon, 28 Oct 2019 11:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/gAhBlJb+sh0KhEN82c+Z4PpNrmxIydwqif6hZnM8oQ=; b=W9XRu8s6F/9TsFLHTcSQDb0Nv6pnIBlAVPHEIvO+0sRufsrPexDNntaTTDpMZkYUFo HPcrYBHpRf+ThMx5LF2vxZRrxrnvJBpc4Sqnihoe1cxFGg+lLl92BzCZvB5gPmy64oYx C1JVb5DYpmh6hT5M6smONPWDfCNxR+oiqBdKNQHXRCbonDeA8mQAlBm+G5c0IvbXpuED fhS+aVBYsHYn5SNgUF7cgHJNxZpIvtVB/Y6vQ+MwZhPqdFpje6OesPLagLI4Ug6Q/VKZ St6ztLOs3ojRqUZcTMIsSv2G7wbLOqTEMiKQ8LS2IyugyXUoJaGkFPbT/4mu9lCwKV9t 3T4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/gAhBlJb+sh0KhEN82c+Z4PpNrmxIydwqif6hZnM8oQ=; b=J6KxMha9uGq2zdNwNJgp11X2mcvIRgjugDny+oj7Hae9DepV19wCWt908ntDmfE2Cx MLGu3so1crnbLWfRK5ptmUYG9nV16/hNq5Un715le1VSV0MkDxN7mUcmZ7jBg29/g95B L5sMXnMzhioCKyHO05kidNZ4D0+8b2x0rXOjO97D9gVaSa1HgmnyjkCovA0MQ7mZRyvx MyuogKZI/wYkiJj8xpvb504twUafLfDQWNE5WTywGfEe8Up2PLByEiQVcu/Oe3xKsc5R mOg19TSr776BFqthIGuNCH2GP7I29MwhzMwA5/ykKYZEO3oi5uTAvTc6DchCaLfsDxqJ 6sZQ== X-Gm-Message-State: APjAAAXlo7t36nnEwtjNZEnwYYC21mNyLY0DPVT1rvvMvduLUC/Li7dG AHrrCKOr+ewVpj6J669wlg9zYbpuiwhTIpXXGbgh0w== X-Google-Smtp-Source: APXvYqyKEfwJb0l2DG8kqTlFCipDkABRVU0HfqUzj9xcr2+jKGtaVuiLUsrnqfOOo9Jq/Rny/0uW2EQPeSc+7gts5vI= X-Received: by 2002:a9d:5a0b:: with SMTP id v11mr15027479oth.102.1572287953644; Mon, 28 Oct 2019 11:39:13 -0700 (PDT) MIME-Version: 1.0 References: <20191025234834.28214-1-john.stultz@linaro.org> <20191025234834.28214-2-john.stultz@linaro.org> <20191028074642.GB31867@infradead.org> In-Reply-To: <20191028074642.GB31867@infradead.org> From: John Stultz Date: Mon, 28 Oct 2019 11:39:03 -0700 Message-ID: Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module To: Christoph Hellwig Cc: lkml , Sandeep Patil , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , "Andrew F . Davis" , Andrew Morton , Yue Hu , Mike Rapoport , Chenbo Feng , Alistair Strachan , Hridya Valsaraju , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 12:46 AM Christoph Hellwig wrote: > > On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > > struct cma *dma_contiguous_default_area; > > +EXPORT_SYMBOL(dma_contiguous_default_area); > > Please CC the dma maintainer. And no, you have no business using this. Sure thing. And I'll look again to see why I was needing to pull that one in to get it to build. > Even if you did, internals like this should always be EXPORT_SYMBOL_GPL. Certainly! My mistake here! Thanks for the feedback! -john From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14F4CA9EC2 for ; Mon, 28 Oct 2019 18:39:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAD1F214B2 for ; Mon, 28 Oct 2019 18:39:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAD1F214B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AA8B6E9B7; Mon, 28 Oct 2019 18:39:16 +0000 (UTC) Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72DA06E9B7 for ; Mon, 28 Oct 2019 18:39:14 +0000 (UTC) Received: by mail-ot1-x344.google.com with SMTP id c7so7538507otm.3 for ; Mon, 28 Oct 2019 11:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/gAhBlJb+sh0KhEN82c+Z4PpNrmxIydwqif6hZnM8oQ=; b=RZ7X0lV1AydpOwqxrrELzuBvxvJgTUw/xIANt/tvGVZu6tMnomYzmJFn4Q0gTrEzZt LyyMh7BVk3/+K7C4+/2PG50KwF5zsaLtv4PG28F8IO4I/XmR/rNFxMSwQupHQyZjtxob aoi5BsaqZJSQpobwveO2GgpSv0D1EynIg9hhmruHlUCafgddejtKkazVbzEe9U15cYvx 2ZI7psPLMf6+XlcgUvLbyxk/YAnCJzZ7RMJnoj0a251imhCQ8iLpNr4yrtEKmTcDvtS9 NpS1F/uwpS5PmeUH4oPl4hzlIV9ek27mlD2GBkYuVxchpknUpCi/5k8L9KsUvbQRbUBs F1vA== X-Gm-Message-State: APjAAAX3nLDB325dIlBbfYP8AqicrCc40Jwmd0Kl9jvm6qp9skDHg/O/ 9LeeBFrlQ52AXl1MRsqtQBwqvfQQmjs04NJLY37QJQ== X-Google-Smtp-Source: APXvYqyKEfwJb0l2DG8kqTlFCipDkABRVU0HfqUzj9xcr2+jKGtaVuiLUsrnqfOOo9Jq/Rny/0uW2EQPeSc+7gts5vI= X-Received: by 2002:a9d:5a0b:: with SMTP id v11mr15027479oth.102.1572287953644; Mon, 28 Oct 2019 11:39:13 -0700 (PDT) MIME-Version: 1.0 References: <20191025234834.28214-1-john.stultz@linaro.org> <20191025234834.28214-2-john.stultz@linaro.org> <20191028074642.GB31867@infradead.org> In-Reply-To: <20191028074642.GB31867@infradead.org> From: John Stultz Date: Mon, 28 Oct 2019 11:39:03 -0700 Message-ID: Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module To: Christoph Hellwig X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/gAhBlJb+sh0KhEN82c+Z4PpNrmxIydwqif6hZnM8oQ=; b=W9XRu8s6F/9TsFLHTcSQDb0Nv6pnIBlAVPHEIvO+0sRufsrPexDNntaTTDpMZkYUFo HPcrYBHpRf+ThMx5LF2vxZRrxrnvJBpc4Sqnihoe1cxFGg+lLl92BzCZvB5gPmy64oYx C1JVb5DYpmh6hT5M6smONPWDfCNxR+oiqBdKNQHXRCbonDeA8mQAlBm+G5c0IvbXpuED fhS+aVBYsHYn5SNgUF7cgHJNxZpIvtVB/Y6vQ+MwZhPqdFpje6OesPLagLI4Ug6Q/VKZ St6ztLOs3ojRqUZcTMIsSv2G7wbLOqTEMiKQ8LS2IyugyXUoJaGkFPbT/4mu9lCwKV9t 3T4w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Strachan , Sandeep Patil , Mike Rapoport , Chenbo Feng , lkml , Liam Mark , Yue Hu , dri-devel , "Andrew F . Davis" , Hridya Valsaraju , Andrew Morton , Pratik Patel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191028183903.amgzgVankf8mu02aMc2_og5BflclLFNOYZ1QJ9PsEMY@z> T24gTW9uLCBPY3QgMjgsIDIwMTkgYXQgMTI6NDYgQU0gQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBp bmZyYWRlYWQub3JnPiB3cm90ZToKPgo+IE9uIEZyaSwgT2N0IDI1LCAyMDE5IGF0IDExOjQ4OjMz UE0gKzAwMDAsIEpvaG4gU3R1bHR6IHdyb3RlOgo+ID4gIHN0cnVjdCBjbWEgKmRtYV9jb250aWd1 b3VzX2RlZmF1bHRfYXJlYTsKPiA+ICtFWFBPUlRfU1lNQk9MKGRtYV9jb250aWd1b3VzX2RlZmF1 bHRfYXJlYSk7Cj4KPiBQbGVhc2UgQ0MgdGhlIGRtYSBtYWludGFpbmVyLiAgQW5kIG5vLCB5b3Ug aGF2ZSBubyBidXNpbmVzcyB1c2luZyB0aGlzLgoKU3VyZSB0aGluZy4gQW5kIEknbGwgbG9vayBh Z2FpbiB0byBzZWUgd2h5IEkgd2FzIG5lZWRpbmcgdG8gcHVsbCB0aGF0Cm9uZSBpbiB0byBnZXQg aXQgdG8gYnVpbGQuCgo+IEV2ZW4gaWYgeW91IGRpZCwgaW50ZXJuYWxzIGxpa2UgdGhpcyBzaG91 bGQgYWx3YXlzIGJlIEVYUE9SVF9TWU1CT0xfR1BMLgoKQ2VydGFpbmx5ISBNeSBtaXN0YWtlIGhl cmUhCgpUaGFua3MgZm9yIHRoZSBmZWVkYmFjayEKLWpvaG4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVs