From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DFEC282DD for ; Thu, 25 Apr 2019 03:53:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17DCE217FA for ; Thu, 25 Apr 2019 03:53:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q/mSAoKF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389111AbfDYDxW (ORCPT ); Wed, 24 Apr 2019 23:53:22 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42401 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388848AbfDYDxU (ORCPT ); Wed, 24 Apr 2019 23:53:20 -0400 Received: by mail-wr1-f67.google.com with SMTP id g3so28109699wrx.9 for ; Wed, 24 Apr 2019 20:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5L3E0HwDDQMhrx+Vj9qrJRYW7q7zSpM0L4v196gNVL0=; b=Q/mSAoKFOc4eH9WR+HeVhCdUFLTM6EowQcPIAzhdU1Fcz64uLvLkOML2xA4EyEgejo YAI46uPFeUvEFN+hF/CfvFe1ht7ZaEtdTDwSVYXjrroUkeoc09dDl6rgab/iWZM7ASfF ZCb0pdzxnaClBJ6t2e3jGOGWpTmyKzBBJHnMQr1eBMeeuKrnzoURRldKICpo64Xhd4aO PIFP9h4P464dhYNF4w6y/pA7hjduYuhZjp06bgeB6AIkKq/XdZZgN3nXLLoeOQ62htQX DuGeCcZ+ssL3xmXxpcrguoZwFFKloeQnonKvtDHL0SlK/iV+hSS+80AUrLz4PcjnZzpc eS9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5L3E0HwDDQMhrx+Vj9qrJRYW7q7zSpM0L4v196gNVL0=; b=H6Wv0pCCfBatLse329OhMRBgo+9TnxU96WvbW+yZhZ55A3jFh7Qh1zdLSxKfRqjGwS zCxCB1lPv/2PVVAIc/j96UoZ8kc5ufFpmGA6zIBNqQw8SYHIxvMIONTa3aqeG+32dfan qSqgdCZFWPOaw7HxAzNF8wavEhRHRR2uPojhT0+kW2/UYjtXJuS5UaYCPZLOCKbv9guL SWT4HOHxnLDk8eFFkY/TONdEUJrvL+og+CEM/hI1yEd9FetfQh87lZ5EkRBOW1PT0fCv LzUUfl2Hzj66sXLJx5Xde2fXIjzV+BAP75eEwHg3W0AP6YlUPck+3ZbQiwxg6E26ynUc 2mNg== X-Gm-Message-State: APjAAAWsDUh6HnHANFzxDkwULWT1hb2wT8kKy/TAkpVCOCyRrGCb2Qm4 xmXdXbvSB7ORk24ZFKFtQDRm/RZ6YAulU6oESGNjvg== X-Google-Smtp-Source: APXvYqx2g/hH/RX+4k1e4COwiSspRHeePfD6prEQOj89UF5l7J2zPg3tCXtdSe4B6fOTsNadBYx+jNGygCf/m5pbW88= X-Received: by 2002:a05:6000:118a:: with SMTP id g10mr2609981wrx.233.1556164398224; Wed, 24 Apr 2019 20:53:18 -0700 (PDT) MIME-Version: 1.0 References: <1553059940-127038-1-git-send-email-fei.yang@intel.com> <20190424165052.GF21916@kroah.com> In-Reply-To: <20190424165052.GF21916@kroah.com> From: John Stultz Date: Wed, 24 Apr 2019 20:53:06 -0700 Message-ID: Subject: Re: [PATCH V2] usb: gadget: f_fs: don't free buffer prematurely To: Greg KH Cc: "Yang, Fei" , Felipe Balbi , andrzej.p@collabora.com, Vincent Pelletier , Linux USB List , lkml , Josh Gao , Alistair Strachan , Shen Jing , Alan Stern Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 24, 2019 at 9:50 AM Greg KH wrote: > > On Tue, Apr 02, 2019 at 10:26:51AM +0700, John Stultz wrote: > > On Wed, Mar 20, 2019 at 11:21 AM John Stultz wrote: > > > On Wed, Mar 20, 2019 at 9:40 AM John Stultz wrote: > > > > On Tue, Mar 19, 2019 at 10:32 PM wrote: > > > > Elsewhere it seems the ffs driver takes effort to drop any locks > > > > before calling usb_ep_dequeue(), so this seems like that should be > > > > addressed, but it also seems like recent change to the dwc3 driver has > > > > been made to avoid sleeping in that path (see fec9095bdef4 ("usb: > > > > dwc3: gadget: remove wait_end_transfer")), which may be why I'm not > > > > seeing the problem with mainline (and your patch here, of coarse). > > > > But that also doesn't clarify if its still a potential issue w/ > > > > non-dwc3 platforms. > > > > > > Felipe: Given Alan's point, does it make sense to mark the commits > > > that remove the possible sleep from wait_event_lock_irq() in > > > dwc3_gadget_ep_dequeue() for -stable? > > > > > > Against 4.19.30, the following set manages to cherry-pick cleanly: > > > git cherry-pick 1a22ec643580626f439c8583edafdcc73798f2fb > > > git cherry-pick 09fe1f8d7e2f461275b1cdd832f2cfa5e9be346d > > > git cherry-pick c3acd59014148470dc58519870fbc779785b4bf7 > > > git cherry-pick 7746a8dfb3f9c91b3a0b63a1d5c2664410e6498d > > > git cherry-pick d5443bbf5fc8f8389cce146b1fc2987cdd229d12 > > > git cherry-pick d4f1afe5e896c18ae01099a85dab5e1a198bd2a8 > > > git cherry-pick fec9095bdef4e7c988adb603d0d4f92ee735d4a1 > > > # To get things building, revert modified -stable fix > > > git revert 25ad17d > > > #pick actual upstream fix replacing the previous > > > git cherry-pick bd6742249b9ca918565e4e3abaa06665e587f4b5 > > > > > > (Though I'm always a bit hesitant with -stable backports on subsystems > > > I don't know well. So I'm not sure if this set is fully correct.) > > > > > > This set seems to avoid the crash on reboot I was seeing. > > > > > > And of course, I'm sure getting that set backported to 4.14 and 4.9 > > > (and maybe even 4.4, I need to check) will be less clean. > > > > Also, I just wanted to follow up on this as well. Does the above set > > of cherry-picks look ok to others for 4.19-stable? Does anyone have > > suggestions on how they'd like to see backports to 4.14, 4.9 and 4.4? > > If they are ok, can someone send me the commits as a series of patches, > as doing the above really doesn't help much :) Yea, so I'm happy to send that set to you for 4.19, assuming Felipe or someone else OKs it. I'm still at a bit of a loss for what to do for older (4.14/4.9/4.4) -stable kernels, as its going to be difficult to backport those. thanks -john From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V2] usb: gadget: f_fs: don't free buffer prematurely From: John Stultz Message-Id: Date: Wed, 24 Apr 2019 20:53:06 -0700 To: Greg KH Cc: "Yang, Fei" , Felipe Balbi , andrzej.p@collabora.com, Vincent Pelletier , Linux USB List , lkml , Josh Gao , Alistair Strachan , Shen Jing , Alan Stern List-ID: T24gV2VkLCBBcHIgMjQsIDIwMTkgYXQgOTo1MCBBTSBHcmVnIEtIIDxncmVna2hAbGludXhmb3Vu ZGF0aW9uLm9yZz4gd3JvdGU6Cj4KPiBPbiBUdWUsIEFwciAwMiwgMjAxOSBhdCAxMDoyNjo1MUFN ICswNzAwLCBKb2huIFN0dWx0eiB3cm90ZToKPiA+IE9uIFdlZCwgTWFyIDIwLCAyMDE5IGF0IDEx OjIxIEFNIEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5hcm8ub3JnPiB3cm90ZToKPiA+ID4g T24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgOTo0MCBBTSBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpA bGluYXJvLm9yZz4gd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBNYXIgMTksIDIwMTkgYXQgMTA6MzIg UE0gPGZlaS55YW5nQGludGVsLmNvbT4gd3JvdGU6Cj4gPiA+ID4gRWxzZXdoZXJlIGl0IHNlZW1z IHRoZSBmZnMgZHJpdmVyIHRha2VzIGVmZm9ydCB0byBkcm9wIGFueSBsb2Nrcwo+ID4gPiA+IGJl Zm9yZSBjYWxsaW5nIHVzYl9lcF9kZXF1ZXVlKCksIHNvIHRoaXMgc2VlbXMgbGlrZSB0aGF0IHNo b3VsZCBiZQo+ID4gPiA+IGFkZHJlc3NlZCwgYnV0IGl0IGFsc28gc2VlbXMgbGlrZSByZWNlbnQg Y2hhbmdlIHRvIHRoZSBkd2MzIGRyaXZlciBoYXMKPiA+ID4gPiBiZWVuIG1hZGUgdG8gYXZvaWQg c2xlZXBpbmcgaW4gdGhhdCBwYXRoIChzZWUgZmVjOTA5NWJkZWY0ICgidXNiOgo+ID4gPiA+IGR3 YzM6IGdhZGdldDogcmVtb3ZlIHdhaXRfZW5kX3RyYW5zZmVyIikpLCB3aGljaCBtYXkgYmUgd2h5 IEknbSBub3QKPiA+ID4gPiBzZWVpbmcgdGhlIHByb2JsZW0gd2l0aCBtYWlubGluZSAoYW5kIHlv dXIgcGF0Y2ggaGVyZSwgb2YgY29hcnNlKS4KPiA+ID4gPiBCdXQgdGhhdCBhbHNvIGRvZXNuJ3Qg Y2xhcmlmeSBpZiBpdHMgc3RpbGwgYSBwb3RlbnRpYWwgaXNzdWUgdy8KPiA+ID4gPiBub24tZHdj MyBwbGF0Zm9ybXMuCj4gPiA+Cj4gPiA+IEZlbGlwZTogR2l2ZW4gQWxhbidzIHBvaW50LCBkb2Vz IGl0IG1ha2Ugc2Vuc2UgdG8gbWFyayB0aGUgY29tbWl0cwo+ID4gPiB0aGF0IHJlbW92ZSB0aGUg cG9zc2libGUgc2xlZXAgZnJvbSB3YWl0X2V2ZW50X2xvY2tfaXJxKCkgaW4KPiA+ID4gZHdjM19n YWRnZXRfZXBfZGVxdWV1ZSgpICBmb3IgLXN0YWJsZT8KPiA+ID4KPiA+ID4gQWdhaW5zdCA0LjE5 LjMwLCB0aGUgZm9sbG93aW5nIHNldCBtYW5hZ2VzIHRvIGNoZXJyeS1waWNrIGNsZWFubHk6Cj4g PiA+IGdpdCBjaGVycnktcGljayAxYTIyZWM2NDM1ODA2MjZmNDM5Yzg1ODNlZGFmZGNjNzM3OThm MmZiCj4gPiA+IGdpdCBjaGVycnktcGljayAwOWZlMWY4ZDdlMmY0NjEyNzViMWNkZDgzMmYyY2Zh NWU5YmUzNDZkCj4gPiA+IGdpdCBjaGVycnktcGljayBjM2FjZDU5MDE0MTQ4NDcwZGM1ODUxOTg3 MGZiYzc3OTc4NWI0YmY3Cj4gPiA+IGdpdCBjaGVycnktcGljayA3NzQ2YThkZmIzZjljOTFiM2Ew YjYzYTFkNWMyNjY0NDEwZTY0OThkCj4gPiA+IGdpdCBjaGVycnktcGljayBkNTQ0M2JiZjVmYzhm ODM4OWNjZTE0NmIxZmMyOTg3Y2RkMjI5ZDEyCj4gPiA+IGdpdCBjaGVycnktcGljayBkNGYxYWZl NWU4OTZjMThhZTAxMDk5YTg1ZGFiNWUxYTE5OGJkMmE4Cj4gPiA+IGdpdCBjaGVycnktcGljayBm ZWM5MDk1YmRlZjRlN2M5ODhhZGI2MDNkMGQ0ZjkyZWU3MzVkNGExCj4gPiA+ICMgVG8gZ2V0IHRo aW5ncyBidWlsZGluZywgcmV2ZXJ0IG1vZGlmaWVkIC1zdGFibGUgZml4Cj4gPiA+IGdpdCByZXZl cnQgMjVhZDE3ZAo+ID4gPiAjcGljayBhY3R1YWwgdXBzdHJlYW0gZml4IHJlcGxhY2luZyB0aGUg cHJldmlvdXMKPiA+ID4gZ2l0IGNoZXJyeS1waWNrIGJkNjc0MjI0OWI5Y2E5MTg1NjVlNGUzYWJh YTA2NjY1ZTU4N2Y0YjUKPiA+ID4KPiA+ID4gKFRob3VnaCBJJ20gYWx3YXlzIGEgYml0IGhlc2l0 YW50IHdpdGggLXN0YWJsZSBiYWNrcG9ydHMgb24gc3Vic3lzdGVtcwo+ID4gPiBJIGRvbid0IGtu b3cgd2VsbC4gU28gSSdtIG5vdCBzdXJlIGlmIHRoaXMgc2V0IGlzIGZ1bGx5IGNvcnJlY3QuKQo+ ID4gPgo+ID4gPiBUaGlzIHNldCBzZWVtcyB0byBhdm9pZCB0aGUgY3Jhc2ggb24gcmVib290IEkg d2FzIHNlZWluZy4KPiA+ID4KPiA+ID4gQW5kIG9mIGNvdXJzZSwgSSdtIHN1cmUgZ2V0dGluZyB0 aGF0IHNldCBiYWNrcG9ydGVkIHRvIDQuMTQgYW5kIDQuOQo+ID4gPiAoYW5kIG1heWJlIGV2ZW4g NC40LCBJIG5lZWQgdG8gY2hlY2spIHdpbGwgYmUgbGVzcyBjbGVhbi4KPiA+Cj4gPiBBbHNvLCAg SSBqdXN0IHdhbnRlZCB0byBmb2xsb3cgdXAgb24gdGhpcyBhcyB3ZWxsLiBEb2VzIHRoZSBhYm92 ZSBzZXQKPiA+IG9mIGNoZXJyeS1waWNrcyBsb29rIG9rIHRvIG90aGVycyBmb3IgNC4xOS1zdGFi bGU/ICBEb2VzIGFueW9uZSBoYXZlCj4gPiBzdWdnZXN0aW9ucyBvbiBob3cgdGhleSdkIGxpa2Ug dG8gc2VlIGJhY2twb3J0cyB0byA0LjE0LCA0LjkgYW5kIDQuND8KPgo+IElmIHRoZXkgYXJlIG9r LCBjYW4gc29tZW9uZSBzZW5kIG1lIHRoZSBjb21taXRzIGFzIGEgc2VyaWVzIG9mIHBhdGNoZXMs Cj4gYXMgZG9pbmcgdGhlIGFib3ZlIHJlYWxseSBkb2Vzbid0IGhlbHAgbXVjaCA6KQoKWWVhLCBz byBJJ20gaGFwcHkgdG8gc2VuZCB0aGF0IHNldCB0byB5b3UgZm9yIDQuMTksIGFzc3VtaW5nIEZl bGlwZSBvcgpzb21lb25lIGVsc2UgT0tzIGl0LgpJJ20gc3RpbGwgYXQgYSBiaXQgb2YgYSBsb3Nz IGZvciB3aGF0IHRvIGRvIGZvciBvbGRlciAoNC4xNC80LjkvNC40KQotc3RhYmxlIGtlcm5lbHMs IGFzIGl0cyBnb2luZyB0byBiZSBkaWZmaWN1bHQgdG8gYmFja3BvcnQgdGhvc2UuCgp0aGFua3MK LWpvaG4K