From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44AFC433F5 for ; Wed, 10 Nov 2021 18:55:42 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 445EA61052 for ; Wed, 10 Nov 2021 18:55:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 445EA61052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60B1E4068B; Wed, 10 Nov 2021 19:55:41 +0100 (CET) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id 6DE5140683 for ; Wed, 10 Nov 2021 19:55:40 +0100 (CET) Received: by mail-io1-f52.google.com with SMTP id v65so4013919ioe.5 for ; Wed, 10 Nov 2021 10:55:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5gQsz+zuFDQP+51K2iL1xmTKtrbro5oZ5E72uLKRZ8M=; b=ftcmmRJrkjQSLT/AgLAeEnMF5zEo5C/7/EjZ2/b3QyeeMKyrwXOGaHymarATgTuoKn jw7mZkaAfqNcp7T1i88g3AF4cyBR5mlZeawE1rfkdowGBvzqvIoEoYPumwAG+4wckR9F 4TyWjU9OIQfjnqPqSy/VwwGZZUBpceb+QNTdtkyfv/sUhwVZtRckGqwPpxjTG4UCNW8L +y82s59Yx/nd4SGDfDUgXTwmuT+uUlI+976ihKSaIodJ9yl+a+5vmx+TFpm928FAhhm8 VHaIyrHZGvMMncctEllHCHE5/V1Y75+mkHY+Wuh0UcZoqu1tJ/k0WTjFvPC4JVqQSY8a QFUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5gQsz+zuFDQP+51K2iL1xmTKtrbro5oZ5E72uLKRZ8M=; b=z6+Qr6SYNTrxiWAUY5ZZcOhRv8S+C/4H8/HrQE2dReUvtcuQag5gpX+z4ob9cuGpw4 gM3N6D7CZuNGNu34RkRHd84QMYoqjuM7YL3fH4mlRO36MAKu/Z8mJgf6lQnKQSoZw32D MkQwSifnXZ4YfVpd3HUTxEQNJi5bV2em6xkx9ZfwRjjOQ6xY/CZVSP2muQ16bzLOcJ1i EkP0sDn7LJ2bW4wlDENRtA/iT5CGQGRyLyyWaLXHhT5QwQ0A7NKjC58e2myrNd/P3+1A 9e1HDeD71ug3k/G/vZuFsS4N+dq2tkV/0C7Ive3J0izbGMAV6tZY6weynKPnlrz9rtBQ YbFw== X-Gm-Message-State: AOAM532BzavuuK0ICwjkH87k8sbR+CGFhazNz3atMbqys5n//wAoO6Y0 1Wz5YRwm+Xu1CquLrlg9ZmzaJEwtsXTMZcpro44= X-Google-Smtp-Source: ABdhPJzziXlG6mhQw6F9B8aJRu0wS2AsCUtQhMsHalYfYnDuMeT5Xeb3oLPYYGYtn22KnuFEtzEk/AD8tcGi/5/TjgM= X-Received: by 2002:a05:6602:2c46:: with SMTP id x6mr888195iov.38.1636570539657; Wed, 10 Nov 2021 10:55:39 -0800 (PST) MIME-Version: 1.0 References: <20211110113210.21770-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20211110113210.21770-1-mattias.ronnblom@ericsson.com> From: Jerin Jacob Date: Thu, 11 Nov 2021 00:25:13 +0530 Message-ID: Subject: Re: [PATCH v3] eventdev: negate maintenance capability flag To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: "Van Haaren, Harry" , Jerin Jacob , Sunil Kumar Kori , dpdk-dev , Pavan Nikhilesh Bhagavatula , Hemant Agrawal , Nipun Gupta , Thomas Monjalon , David Marchand , "Gujjar, Abhinandan S" , Erik Gabriel Carrillo , "Jayatheerthan, Jay" , Ferruh Yigit , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 10, 2021 at 5:02 PM Mattias R=C3=B6nnblom wrote: > > Replace RTE_EVENT_DEV_CAP_REQUIRES_MAINT, which signaled the need > for the application to call rte_event_maintain(), with > RTE_EVENT_DEV_CAP_MAINTENANCE_FREE, which does the opposite (i.e., > signifies that the event device does not require maintenance). > > This approach is more in line with how other eventdev hardware and/or > software limitations are handled in the Eventdev API. > > v3: Fix invalid references in the API documentation > v2: New flag was not properly set in opdl_evdev.c > > Signed-off-by: Mattias R=C3=B6nnblom Acked-by: Jerin Jacob Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > doc/guides/eventdevs/dsw.rst | 4 ++-- > drivers/event/cnxk/cnxk_eventdev.c | 3 ++- > drivers/event/dlb2/dlb2.c | 3 ++- > drivers/event/dpaa/dpaa_eventdev.c | 3 ++- > drivers/event/dpaa2/dpaa2_eventdev.c | 3 ++- > drivers/event/dsw/dsw_evdev.c | 3 +-- > drivers/event/octeontx/ssovf_evdev.c | 3 ++- > drivers/event/octeontx2/otx2_evdev.c | 3 ++- > drivers/event/opdl/opdl_evdev.c | 3 ++- > drivers/event/skeleton/skeleton_eventdev.c | 3 ++- > drivers/event/sw/sw_evdev.c | 3 ++- > lib/eventdev/rte_eventdev.h | 27 +++++++++++----------- > 12 files changed, 35 insertions(+), 26 deletions(-) > > diff --git a/doc/guides/eventdevs/dsw.rst b/doc/guides/eventdevs/dsw.rst > index 18f7e9588f..5c6b51f65f 100644 > --- a/doc/guides/eventdevs/dsw.rst > +++ b/doc/guides/eventdevs/dsw.rst > @@ -44,8 +44,8 @@ Port Maintenance > ~~~~~~~~~~~~~~~~ > > The distributed software eventdev uses an internal signaling scheme > -between the ports to achieve load balancing. Therefore, it sets the > -``RTE_EVENT_DEV_CAP_REQUIRES_MAINT`` flag. > +between the ports to achieve load balancing. Therefore, it does not > +set the ``RTE_EVENT_DEV_CAP_MAINTENANCE_FREE`` flag. > > During periods when the application thread using a particular port is > neither attempting to enqueue nor to dequeue events, it must > diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk= _eventdev.c > index 50d5c351bc..f7a5026250 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.c > +++ b/drivers/event/cnxk/cnxk_eventdev.c > @@ -119,7 +119,8 @@ cnxk_sso_info_get(struct cnxk_sso_evdev *dev, > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | > RTE_EVENT_DEV_CAP_NONSEQ_MODE | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID; > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FREE; > } > > int > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c > index 0dbe85762c..16e9764dbf 100644 > --- a/drivers/event/dlb2/dlb2.c > +++ b/drivers/event/dlb2/dlb2.c > @@ -66,7 +66,8 @@ static struct rte_event_dev_info evdev_dlb2_default_inf= o =3D { > RTE_EVENT_DEV_CAP_BURST_MODE | > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED | > RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | > - RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES), > + RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), > }; > > struct process_local_port_data > diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa= _eventdev.c > index eec4bc62b7..ff6cc0be18 100644 > --- a/drivers/event/dpaa/dpaa_eventdev.c > +++ b/drivers/event/dpaa/dpaa_eventdev.c > @@ -356,7 +356,8 @@ dpaa_event_dev_info_get(struct rte_eventdev *dev, > RTE_EVENT_DEV_CAP_BURST_MODE | > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | > RTE_EVENT_DEV_CAP_NONSEQ_MODE | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID; > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FREE; > } > > static int > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/d= paa2_eventdev.c > index 710156ad14..4d94c315d2 100644 > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > @@ -408,7 +408,8 @@ dpaa2_eventdev_info_get(struct rte_eventdev *dev, > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | > RTE_EVENT_DEV_CAP_NONSEQ_MODE | > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID; > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FREE; > > } > > diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.= c > index 5ff8fcc6a9..ffabf0d23d 100644 > --- a/drivers/event/dsw/dsw_evdev.c > +++ b/drivers/event/dsw/dsw_evdev.c > @@ -222,8 +222,7 @@ dsw_info_get(struct rte_eventdev *dev __rte_unused, > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED| > RTE_EVENT_DEV_CAP_NONSEQ_MODE| > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT| > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID| > - RTE_EVENT_DEV_CAP_REQUIRES_MAINT > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID > }; > } > > diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeont= x/ssovf_evdev.c > index 366b6d356b..9e14e35d10 100644 > --- a/drivers/event/octeontx/ssovf_evdev.c > +++ b/drivers/event/octeontx/ssovf_evdev.c > @@ -155,7 +155,8 @@ ssovf_info_get(struct rte_eventdev *dev, struct rte_e= vent_dev_info *dev_info) > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LI= NK | > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_= PORT | > RTE_EVENT_DEV_CAP_NONSEQ_MODE | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID; > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FRE= E; > > } > > diff --git a/drivers/event/octeontx2/otx2_evdev.c b/drivers/event/octeont= x2/otx2_evdev.c > index f26bed334f..ccf28b678b 100644 > --- a/drivers/event/octeontx2/otx2_evdev.c > +++ b/drivers/event/octeontx2/otx2_evdev.c > @@ -505,7 +505,8 @@ otx2_sso_info_get(struct rte_eventdev *event_dev, > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LI= NK | > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_= PORT | > RTE_EVENT_DEV_CAP_NONSEQ_MODE | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID; > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FRE= E; > } > > static void > diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_ev= dev.c > index 5007e9a7bf..15c10240b0 100644 > --- a/drivers/event/opdl/opdl_evdev.c > +++ b/drivers/event/opdl/opdl_evdev.c > @@ -375,7 +375,8 @@ opdl_info_get(struct rte_eventdev *dev, struct rte_ev= ent_dev_info *info) > .max_event_port_enqueue_depth =3D MAX_OPDL_CONS_Q_DEPTH, > .max_num_events =3D OPDL_INFLIGHT_EVENTS_TOTAL, > .event_dev_cap =3D RTE_EVENT_DEV_CAP_BURST_MODE | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID, > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FREE, > }; > > *info =3D evdev_opdl_info; > diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/s= keleton/skeleton_eventdev.c > index af0efb3302..bf3b01ebc8 100644 > --- a/drivers/event/skeleton/skeleton_eventdev.c > +++ b/drivers/event/skeleton/skeleton_eventdev.c > @@ -102,7 +102,8 @@ skeleton_eventdev_info_get(struct rte_eventdev *dev, > dev_info->event_dev_cap =3D RTE_EVENT_DEV_CAP_QUEUE_QOS | > RTE_EVENT_DEV_CAP_BURST_MODE | > RTE_EVENT_DEV_CAP_EVENT_QOS | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID; > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FRE= E; > } > > static int > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c > index 070a4802e9..808f59d1e5 100644 > --- a/drivers/event/sw/sw_evdev.c > +++ b/drivers/event/sw/sw_evdev.c > @@ -609,7 +609,8 @@ sw_info_get(struct rte_eventdev *dev, struct rte_even= t_dev_info *info) > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | > RTE_EVENT_DEV_CAP_NONSEQ_MODE | > - RTE_EVENT_DEV_CAP_CARRY_FLOW_ID), > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID | > + RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), > }; > > *info =3D evdev_sw_info; > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h > index e026486ca5..eef47d8acc 100644 > --- a/lib/eventdev/rte_eventdev.h > +++ b/lib/eventdev/rte_eventdev.h > @@ -299,13 +299,14 @@ struct rte_event; > * the content of this field is implementation dependent. > */ > > -#define RTE_EVENT_DEV_CAP_REQUIRES_MAINT (1ULL << 10) > -/**< Event device requires calls to rte_event_maintain() during > - * periods when neither rte_event_dequeue_burst() nor > - * rte_event_enqueue_burst() are called on a port. This will allow the > - * event device to perform internal processing, such as flushing > - * buffered events, return credits to a global pool, or process > - * signaling related to load balancing. > +#define RTE_EVENT_DEV_CAP_MAINTENANCE_FREE (1ULL << 10) > +/**< Event device *does not* require calls to rte_event_maintain(). > + * An event device that does not set this flag requires calls to > + * rte_event_maintain() during periods when neither > + * rte_event_dequeue_burst() nor rte_event_enqueue_burst() are called > + * on a port. This will allow the event device to perform internal > + * processing, such as flushing buffered events, return credits to a > + * global pool, or process signaling related to load balancing. > */ > > /* Event device priority levels */ > @@ -2082,8 +2083,8 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t por= t_id, struct rte_event ev[], > /** > * Maintain an event device. > * > - * This function is only relevant for event devices which have the > - * @ref RTE_EVENT_DEV_CAP_REQUIRES_MAINT flag set. Such devices > + * This function is only relevant for event devices which do not have > + * the @ref RTE_EVENT_DEV_CAP_MAINTENANCE_FREE flag set. Such devices > * require an application thread using a particular port to > * periodically call rte_event_maintain() on that port during periods > * which it is neither attempting to enqueue events to nor dequeue > @@ -2098,9 +2099,9 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t por= t_id, struct rte_event ev[], > * or dequeue functions are being called, at the cost of a slight > * increase in overhead. > * > - * rte_event_maintain() may be called on event devices which haven't > - * set @ref RTE_EVENT_DEV_CAP_REQUIRES_MAINT flag, in which case it is > - * a no-operation. > + * rte_event_maintain() may be called on event devices which have set > + * @ref RTE_EVENT_DEV_CAP_MAINTENANCE_FREE, in which case it is a > + * no-operation. > * > * @param dev_id > * The identifier of the device. > @@ -2112,7 +2113,7 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t por= t_id, struct rte_event ev[], > * - 0 on success. > * - -EINVAL if *dev_id*, *port_id*, or *op* is invalid. > * > - * @see RTE_EVENT_DEV_CAP_REQUIRES_MAINT > + * @see RTE_EVENT_DEV_CAP_MAINTENANCE_FREE > */ > __rte_experimental > static inline int > -- > 2.25.1 >