All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	John McNamara <john.mcnamara@intel.com>,
	 Marko Kovacevic <marko.kovacevic@intel.com>,
	dpdk-dev <dev@dpdk.org>,
	 Andrew Rybchenko <arybchenko@solarflare.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	 Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Jerin Jacob <jerinj@marvell.com>,  Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list
Date: Fri, 25 Oct 2019 19:09:04 +0530	[thread overview]
Message-ID: <CALBAE1N_C0UZByG6RthrsHW6iK+GE=ZT2TEjM8Mf34On-REWcg@mail.gmail.com> (raw)
In-Reply-To: <5258375.BrpvpaGT02@xps>

On Fri, Oct 25, 2019 at 6:56 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 25/10/2019 14:51, Ferruh Yigit:
> > "Flow API" is a method/API to implement various filtering features, on
> > its own it doesn't give much context on what features are provided. And
> > it is not really a feature, so doesn't fit into feature table.
> >
> > Also since other filtering related APIs, 'filter_ctrl', has been
> > deprecated, flow API is the only supported way in the DPDK to implement
> > filtering options, if related filter options announced by PMDs, listing
> > "Flow API" as implemented is redundant information.
>
> I fully agree with this explanation.
> rte_flow is the only supported API for flow offloads.
> That's why we must remove the legacy API.
>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > --- a/doc/guides/nics/features/default.ini
> > +++ b/doc/guides/nics/features/default.ini
> > -Flow API             =
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

# Need to remove "Flow API" from doc/guides/nics/features.rst
# Need to remove refference of "Flow API" from "doc/guides/nics/*" as well.

Not specific to this patch,
Probably we need to add a new matrix to enumerate PATTERN and ACTIONS
supported by each PMD as a rte_flow feature matrix.
That some else can take it up if everyone agrees the semantics.

  reply	other threads:[~2019-10-25 13:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 12:51 [dpdk-dev] [PATCH 1/2] doc: add PMD filtering features back Ferruh Yigit
2019-10-25 12:51 ` [dpdk-dev] [PATCH 2/2] doc: remove flow API from the feature list Ferruh Yigit
2019-10-25 13:26   ` Thomas Monjalon
2019-10-25 13:39     ` Jerin Jacob [this message]
2020-04-10  8:44       ` Ferruh Yigit
2020-04-10  8:56         ` Thomas Monjalon
2020-04-10  9:04           ` Jerin Jacob
2020-04-10  9:20             ` Thomas Monjalon
2020-04-10  9:27               ` Ferruh Yigit
2019-10-25 13:23 ` [dpdk-dev] [PATCH 1/2] doc: add PMD filtering features back Thomas Monjalon
2020-04-10  8:53   ` Ferruh Yigit
2020-04-10  9:29 ` [dpdk-dev] [PATCH v2] doc: remove flow API from the feature list Ferruh Yigit
2020-04-10  9:29 ` [dpdk-dev] [PATCH v2 1/2] doc: add PMD filtering features back Ferruh Yigit
2020-04-10  9:29   ` [dpdk-dev] [PATCH v2 2/2] doc: remove flow API from the feature list Ferruh Yigit
2020-04-10 12:10     ` Jerin Jacob
2020-04-10 12:34       ` Thomas Monjalon
2020-04-10 12:38         ` Jerin Jacob
2020-04-10 12:22   ` [dpdk-dev] [PATCH v2 1/2] doc: add PMD filtering features back Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1N_C0UZByG6RthrsHW6iK+GE=ZT2TEjM8Mf34On-REWcg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=orika@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.