From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71BC7C433F5 for ; Fri, 18 Feb 2022 04:21:09 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39FE740395; Fri, 18 Feb 2022 05:21:08 +0100 (CET) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id C2A1D40150 for ; Fri, 18 Feb 2022 05:21:07 +0100 (CET) Received: by mail-io1-f48.google.com with SMTP id r7so776437iot.3 for ; Thu, 17 Feb 2022 20:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TD2AiFZBZ8t8DoTJoaOMZyrqH8mdBNx7I4enFJTCCuU=; b=PUHRiLx0rn/3yeKM/hdVdJ469KdSTBA5QxwDRGcg+OJon4wuLje39WR66MYgK8jXb0 c7S6FN5RS9aD3b3RTMxys2Byj1C2axrwnnBQ5oHsGsYZfAZ0VZ3sk34Qz0pvzpaOj6nz nbaunvzKJnDTVbwbEZFNtWEQ3sXv3H5M93+ttD0as/Ve4Ry2zCInz65YFBhA3+3bZlvj poTV5Gs8PDnOVM/DYRwlbMJUPtATwrirdjFxE4/GP1cSNVvlFA6ijcxl8Vmt5WNksk3k B97y9QSGrUOxesuQkx9fXUzbFGhJG0i3gUqDscCf76mTkOJYL94t/ho76SlVVowmjj3t 338g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TD2AiFZBZ8t8DoTJoaOMZyrqH8mdBNx7I4enFJTCCuU=; b=qd/02e8nSQPgBFTwFW7rBcJ+8SUGU2JwR5f11qL6Hnm6I9KPjCzWWKiMrPNcOXKVWl MRbDxUO3ihc4U7WSOI19hZS8DYMfPFTZLEZ75oP0JUdsOCoYqmdXy9H7Ua7AjeJTI2Hv /0l/mZUGE1v7iAL31EPmVxQ2i8LIahURB5WlqGhen43YvV8ZVFgx8k/fr+lnp2DsbJ+X H96fLHnWB4R7A+DlnGJxK4GaVqi4fTaKHf31tJCy9CEDpWmJQjAh8dZFOTbsZAWg+JZ9 h1QPSPdREaHjHI1vPsvDfCdVVKhNlsrJIFbeBNcakD1C5c/zpqYHddeihupBySyFAhqj jYDw== X-Gm-Message-State: AOAM530D+0pAtt/QnTp0cAnn4kZnOMAcRTBeCUfznusXH862sV6Xipd5 gPR3daeWB8I/Hwv3Rh2AIv+sGxxIQ6iMAM8H27SM8lnho0kr2A== X-Google-Smtp-Source: ABdhPJyhzVKRdgJncEUeK1anGp7HhvWAPkUEbqSSMK09cDtPYyCIe2diW8ymm54i5mMBkC8iwxoiA7Ov88noMPB1gVc= X-Received: by 2002:a05:6602:210c:b0:640:7616:d93a with SMTP id x12-20020a056602210c00b006407616d93amr973720iox.154.1645158067034; Thu, 17 Feb 2022 20:21:07 -0800 (PST) MIME-Version: 1.0 References: <20220212123820.3394341-1-gmuthukrishn@marvell.com> In-Reply-To: <20220212123820.3394341-1-gmuthukrishn@marvell.com> From: Jerin Jacob Date: Fri, 18 Feb 2022 09:50:41 +0530 Message-ID: Subject: Re: [PATCH 1/3] common/cnxk: check return value for error To: Gowrishankar Muthukrishnan , Ferruh Yigit Cc: dpdk-dev , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 12, 2022 at 6:08 PM Gowrishankar Muthukrishnan wrote: > > This patch fixes coverity issue by adding checks on return values. > > Coverity issue: 373628, 374858, 370213, 370215 > Fixes: af75aac78978 ("common/cnxk: support telemetry for NIX") > Fixes: d61138d4f0e ("drivers: remove direct access to interrupt handle") > Fixes: fcdef46b669 ("common/cnxk: support NIX TM debug and misc utils") > Fixes: df405df95ee ("common/cnxk: add NIX TM helper to alloc/free resource") > > Signed-off-by: Gowrishankar Muthukrishnan Series Acked-by: Jerin Jacob Series applied to dpdk-next-net-mrvl/for-next-net. Thanks. > --- > drivers/common/cnxk/cnxk_telemetry_nix.c | 3 +++ > drivers/common/cnxk/roc_irq.c | 5 ++++- > drivers/common/cnxk/roc_nix_debug.c | 4 +++- > drivers/common/cnxk/roc_nix_tm.c | 6 ++++-- > 4 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/drivers/common/cnxk/cnxk_telemetry_nix.c b/drivers/common/cnxk/cnxk_telemetry_nix.c > index df6458039d..4119e9ee4f 100644 > --- a/drivers/common/cnxk/cnxk_telemetry_nix.c > +++ b/drivers/common/cnxk/cnxk_telemetry_nix.c > @@ -765,6 +765,9 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char *params, > > plt_strlcpy(buf, params, PCI_PRI_STR_SIZE + 1); > name = strtok(buf, ","); > + if (name == NULL) > + goto exit; > + > param = strtok(NULL, "\0"); > > node = nix_tel_node_get_by_pcidev_name(name); > diff --git a/drivers/common/cnxk/roc_irq.c b/drivers/common/cnxk/roc_irq.c > index 7a24297d72..010b121176 100644 > --- a/drivers/common/cnxk/roc_irq.c > +++ b/drivers/common/cnxk/roc_irq.c > @@ -160,7 +160,10 @@ dev_irq_register(struct plt_intr_handle *intr_handle, plt_intr_callback_fn cb, > return rc; > } > > - plt_intr_efds_index_set(intr_handle, vec, fd); > + rc = plt_intr_efds_index_set(intr_handle, vec, fd); > + if (rc) > + return rc; > + > nb_efd = (vec > (uint32_t)plt_intr_nb_efd_get(intr_handle)) ? > vec : (uint32_t)plt_intr_nb_efd_get(intr_handle); > plt_intr_nb_efd_set(intr_handle, nb_efd); > diff --git a/drivers/common/cnxk/roc_nix_debug.c b/drivers/common/cnxk/roc_nix_debug.c > index d5143882f5..1ae045172e 100644 > --- a/drivers/common/cnxk/roc_nix_debug.c > +++ b/drivers/common/cnxk/roc_nix_debug.c > @@ -52,7 +52,9 @@ nix_bitmap_dump(struct plt_bitmap *bmp) > int i; > > plt_bitmap_scan_init(bmp); > - plt_bitmap_scan(bmp, &pos, &slab); > + if (!plt_bitmap_scan(bmp, &pos, &slab)) > + return; > + > start_pos = pos; > > nix_dump_no_nl(" \t\t["); > diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c > index a0448bec61..517502b1af 100644 > --- a/drivers/common/cnxk/roc_nix_tm.c > +++ b/drivers/common/cnxk/roc_nix_tm.c > @@ -1016,8 +1016,10 @@ nix_tm_assign_hw_id(struct nix *nix, struct nix_tm_node *parent, > return -EFAULT; > } > > - if (!slab) > - plt_bitmap_scan(bmp, &pos, &slab); > + if (!slab) { > + if (!plt_bitmap_scan(bmp, &pos, &slab)) > + return -ENOENT; > + } > > if (child->priority == parent->rr_prio && spare_schq != -1) { > /* Use spare schq first if present */ > -- > 2.25.1 >