From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12113C433E2 for ; Fri, 15 May 2020 14:36:27 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 90C3E20728 for ; Fri, 15 May 2020 14:36:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mApxkoNx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90C3E20728 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61ADA1DA45; Fri, 15 May 2020 16:36:24 +0200 (CEST) Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 80A8F1DA26 for ; Fri, 15 May 2020 16:36:22 +0200 (CEST) Received: by mail-il1-f195.google.com with SMTP id b71so2744618ilg.8 for ; Fri, 15 May 2020 07:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z7TBZ/tEUyBVEMRM4qVFa2lja3A8/+eTBmLTFaamQh8=; b=mApxkoNxz1nNyjmbfphlumwEzyx3vkLAgxlky01+176JL+R/8kaodDajFMEzCJeMAw 4UZ7XVTRB4RrhMBQREewCdwIwZaDmc76oHBLP89JXYMrsVt0HnAtMe/h6GsZPhMET3JP +no//84dmhN/DODzBLjh1mscjxlQUEg64DUD/5SHe0VZ3VW22FfeveWmk8BrGcy7pOoE RMBEKHxeWMR+Yyh2ZojAjdxtQ0n1bHa2VjrP2mO+DcMMcf/mR69MMnQMM/nuyiC8vcCd 9gfVDsHzC4BNONoqPMl4Mw9tgDh4UmcgZ7fx2HzFDn/l2yg0VfuoAgC7qgqxo3P+R7tQ GH/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z7TBZ/tEUyBVEMRM4qVFa2lja3A8/+eTBmLTFaamQh8=; b=oVd8XUhDBeYScslebppzibcpfYEg1z9f5ivQl1qsGH3oDUvKhEHpysDR8+ruOOzAJ2 Ed40G1OTvg1CvylaSyc4DnffistDBYtw31R/y3yzpZPhXmIIsD3BLziPY9gYenV9u/Ef thJWQhsk1vf7uITuJp440HMPJm5wGK5+CW5YVxOSyCzkb3rKkWc/Gteytj3td9JcQ5Ch PSZK/RyIgYHyUPv1fiOacLKTG7QS5VbzMZL09jlciEbJkMRR+9gdrRjXl3H5H0uS0jSO s87XZamyenvSPlT+Z0Siitvy1XHjmbnn7df+mcNPZyySMzUUER68VnX6p6YnuWF6XeEl yDmg== X-Gm-Message-State: AOAM5321yavJixF35PMzGyN4IotJU6C6gInmcGRuX2f/xtizXSMEs8NG dK01sO4dfiAUmQZhbCPSxpasnw8KIHcjQU8lpZ8= X-Google-Smtp-Source: ABdhPJwef7/CqRFHx35K9MbdwaVRdPEQwPP0dOifIl9G1KTnYWm/sUgsVrTqQnaPdYPdLOnbzNNu36Ot7lXXvv+GaVY= X-Received: by 2002:a05:6e02:589:: with SMTP id c9mr3684806ils.271.1589553381710; Fri, 15 May 2020 07:36:21 -0700 (PDT) MIME-Version: 1.0 References: <1589541684-23246-1-git-send-email-hkalra@marvell.com> In-Reply-To: <1589541684-23246-1-git-send-email-hkalra@marvell.com> From: Jerin Jacob Date: Fri, 15 May 2020 20:06:05 +0530 Message-ID: To: Harman Kalra Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] event/octeontx: fix memory corruption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 15, 2020 at 4:51 PM Harman Kalra wrote: > > Since PMD enqueues a single event at a time, fixing the issue by > passing 1 rather than nb_events to avoid any out of bound access as > reported by coverity. > > Coverity issue: 358447 > Fixes: 56a96aa42464 ("event/octeontx: add framework for Rx/Tx offloads") > > Signed-off-by: Harman Kalra Acked-by: Jerin Jacob Applied to dpdk-next-eventdev/master. Thanks. > --- > drivers/event/octeontx/ssovf_worker.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/event/octeontx/ssovf_worker.c b/drivers/event/octeontx/ssovf_worker.c > index d2d5eea8f..18b7926e8 100644 > --- a/drivers/event/octeontx/ssovf_worker.c > +++ b/drivers/event/octeontx/ssovf_worker.c > @@ -282,6 +282,7 @@ __sso_event_tx_adapter_enqueue(void *port, struct rte_event ev[], > struct ssows *ws = port; > struct octeontx_txq *txq; > > + RTE_SET_USED(nb_events); > switch (ev->sched_type) { > case SSO_SYNC_ORDERED: > ssows_swtag_norm(ws, ev->event, SSO_SYNC_ATOMIC); > @@ -305,7 +306,7 @@ __sso_event_tx_adapter_enqueue(void *port, struct rte_event ev[], > ethdev = &rte_eth_devices[port_id]; > txq = ethdev->data->tx_queues[queue_id]; > > - return __octeontx_xmit_pkts(txq, &m, nb_events, cmd, flag); > + return __octeontx_xmit_pkts(txq, &m, 1, cmd, flag); > } > > #define T(name, f3, f2, f1, f0, sz, flags) \ > -- > 2.18.0 >