Re: [dpdk-dev] [PATCH v2 02/11] net/octeontx_ep: add ethdev probe and remove

From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nalla Pradeep <pnalla@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	 Radha Mohan Chintakuntla <radhac@marvell.com>,
	Veerasenareddy Burru <vburru@marvell.com>,
	dpdk-dev <dev@dpdk.org>,  Satananda Burla <sburla@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2 02/11] net/octeontx_ep: add ethdev probe and remove
Date: Tue, 19 Jan 2021 17:25:53 +0530	[thread overview]
Message-ID: <CALBAE1P9xb1VYdaBN7dvBXYiR8L_p_tdR3XdTM_X3DSYiF6v-g@mail.gmail.com> (raw)
In-Reply-To: <20210118093602.5449-2-pnalla@marvell.com>

On Mon, Jan 18, 2021 at 3:07 PM Nalla Pradeep <pnalla@marvell.com> wrote:
>
> add basic PCIe ethdev probe and remove.
>
> Signed-off-by: Nalla Pradeep <pnalla@marvell.com>
> ---
>  drivers/common/octeontx2/otx2_common.h    |  5 +-
>  drivers/net/octeontx_ep/meson.build       | 13 +++++
>  drivers/net/octeontx_ep/otx_ep_common.h   | 14 +++++
>  drivers/net/octeontx_ep/otx_ep_ethdev.c   | 62 +++++++++++++++++++++++
>  drivers/net/octeontx_ep/otx_ep_vf.h       |  9 ++++
>  drivers/raw/octeontx2_ep/otx2_ep_rawdev.c |  6 +--
>  6 files changed, 105 insertions(+), 4 deletions(-)
>  create mode 100644 drivers/net/octeontx_ep/otx_ep_common.h
>  create mode 100644 drivers/net/octeontx_ep/otx_ep_vf.h
>
> diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h
> index b6779f7104..cd52e098e6 100644
> --- a/drivers/common/octeontx2/otx2_common.h
> +++ b/drivers/common/octeontx2/otx2_common.h
> @@ -136,7 +136,10 @@ extern int otx2_logtype_ree;
>  #define PCI_DEVID_OCTEONTX2_RVU_CPT_VF         0xA0FE
>  #define PCI_DEVID_OCTEONTX2_RVU_AF_VF          0xA0f8
>  #define PCI_DEVID_OCTEONTX2_DPI_VF             0xA081
> -#define PCI_DEVID_OCTEONTX2_EP_VF              0xB203 /* OCTEON TX2 EP mode */
> +#define PCI_DEVID_OCTEONTX2_EP_NET_VF          0xB203 /* OCTEON TX2 EP mode */
> +/* OCTEON TX2 98xx EP mode */
> +#define PCI_DEVID_CN98XX_EP_NET_VF             0xB103
> +#define PCI_DEVID_OCTEONTX2_EP_RAW_VF          0xB204 /* OCTEON TX2 EP mode */
>  #define PCI_DEVID_OCTEONTX2_RVU_SDP_PF         0xA0f6
>  #define PCI_DEVID_OCTEONTX2_RVU_SDP_VF         0xA0f7
>  #define PCI_DEVID_OCTEONTX2_RVU_REE_PF         0xA0f4
> diff --git a/drivers/net/octeontx_ep/meson.build b/drivers/net/octeontx_ep/meson.build
> index 83ffbad7b6..06663de4e2 100644
> --- a/drivers/net/octeontx_ep/meson.build
> +++ b/drivers/net/octeontx_ep/meson.build
> @@ -6,3 +6,16 @@ sources = files(
>                 'otx_ep_ethdev.c',
>                 )
>
> +extra_flags = []
> +# This integrated controller runs only on a arm64 machine, remove 32bit warnings
> +if not dpdk_conf.get('RTE_ARCH_64')
> +        extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
> +endif

This was from net/octeontx2 driver due to NPA complication. Please
check, Is this really required
as this driver can run in x86 32bit mode unlike net/octeontx2.