From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD547C636CC for ; Fri, 3 Feb 2023 10:03:56 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6A4A40A79; Fri, 3 Feb 2023 11:03:55 +0100 (CET) Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by mails.dpdk.org (Postfix) with ESMTP id C55274021E for ; Fri, 3 Feb 2023 11:03:54 +0100 (CET) Received: by mail-vs1-f53.google.com with SMTP id e9so4828912vsj.3 for ; Fri, 03 Feb 2023 02:03:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lSvBJGfuPZgejFcXn/YfeLwu5mHzc66V3ac93zQRhvU=; b=DVlAiFKybtHu6j6zCDLWJASYGED/H3T3luX4LvqW6qvGe1Scz4+Vh7AN5f/FWn9Ph3 DutWGSdDbnaomdTNfzqsL1qGthHX2eCPsitMhpaOcWtN3s/m8jRw5lExY34oA3fpzYLT 1WTebCU0E7Nii2RwPOXrKtUqZKim8T+G7uz6Vp68H13eavOmV7Mpj8RygxzLgPf9Tm9J eew5xuphzIU625VDvO7TvbZ8G34M1ohpEWlk3P4Jievxs7UAL+Cu7QuWg3OhXZSPPfKY R3q0iYw9tNdkkNura0IcRIxUF8tUG3NRVkaMX2j4jxJ0hgODiEKlfR0csFTLzSYUzgiV aOCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lSvBJGfuPZgejFcXn/YfeLwu5mHzc66V3ac93zQRhvU=; b=iRKaWsn6i2RxsFqDh1xbDPC9QyV0cJ4qSLhUjQ9U2sOYLblHH75brqaTosqcQTFdCC a/CS2viMdkOgWJUb1lWPXadFQUsNEqd7jo46Iie1dri5kyPTmGVpOaNR40ZV5HPArfTg 1YnsAD0TiehltVnYACkh4rRrvPtfJzMX1tVphjBnPJ8W3V/fqLE2Hd5dw2me1mJqEIAo Oz9IohzdC5r35WpUwkqI5gktGChCyHiFbDjQenCEEcgiVtyjX+Ilx66CLjkO5ROB4IgB TWgfBCKqDLVLgGyOSK0O4wei3JwDQqPX/Vso4Fy9y5MFAg1aJbCnWdsUrzOgBKaf/4sB Yg5A== X-Gm-Message-State: AO0yUKVcIHreNcOahXx61O+IhTc3dLVR//3LPhho+psP9yolWjOlYL5A vs9Ig/PcVoI5/IIAMKKF2zsG6nM6JIWkdXdwxSc= X-Google-Smtp-Source: AK7set/dUWkH1Ptw5IyBvAICrOz3exph772G985tGuGS+UYjpQKhiBRRjzusVWv2PPeQzzEGMVj/LmDtE/rYWF+63Gw= X-Received: by 2002:a05:6102:3ec3:b0:3f7:fd86:fabf with SMTP id n3-20020a0561023ec300b003f7fd86fabfmr1822768vsv.66.1675418634165; Fri, 03 Feb 2023 02:03:54 -0800 (PST) MIME-Version: 1.0 References: <20220803132839.2747858-2-jerinj@marvell.com> <20221114120238.2143832-1-jerinj@marvell.com> <20221114120238.2143832-2-jerinj@marvell.com> <20230202162803.3d780d6c@hermes.local> In-Reply-To: <20230202162803.3d780d6c@hermes.local> From: Jerin Jacob Date: Fri, 3 Feb 2023 15:33:27 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library To: Stephen Hemminger Cc: Shivah Shankar Shankar Narayan Rao , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Thomas Monjalon , Bruce Richardson , Srikanth Yalavarthi , "ferruh.yigit@xilinx.com" , "ajit.khaparde@broadcom.com" , "aboyer@pensando.io" , "andrew.rybchenko@oktetlabs.ru" , "beilei.xing@intel.com" , "chas3@att.com" , "chenbo.xia@intel.com" , "ciara.loftus@intel.com" , Devendra Singh Rawat , "ed.czeck@atomicrules.com" , "evgenys@amazon.com" , "grive@u256.net" , "g.singh@nxp.com" , "zhouguoyang@huawei.com" , "haiyue.wang@intel.com" , Harman Kalra , "heinrich.kuhn@corigine.com" , "hemant.agrawal@nxp.com" , "hyonkim@cisco.com" , "igorch@amazon.com" , Igor Russkikh , "jgrajcia@cisco.com" , "jasvinder.singh@intel.com" , "jianwang@trustnetic.com" , "jiawenwu@trustnetic.com" , "jingjing.wu@intel.com" , "johndale@cisco.com" , "john.miller@atomicrules.com" , "linville@tuxdriver.com" , "keith.wiles@intel.com" , Kiran Kumar Kokkilagadda , "oulijun@huawei.com" , Liron Himi , "longli@microsoft.com" , "mw@semihalf.com" , "spinler@cesnet.cz" , "matan@nvidia.com" , "matt.peters@windriver.com" , "maxime.coquelin@redhat.com" , "mk@semihalf.com" , "humin29@huawei.com" , Pradeep Kumar Nalla , Nithin Kumar Dabilpuram , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , Radha Chintakuntla , "rahul.lakkireddy@chelsio.com" , Rasesh Mody , "rosen.xu@intel.com" , "sachin.saxena@oss.nxp.com" , Satha Koteswara Rao Kottidi , Shahed Shaikh , "shaibran@amazon.com" , "shepard.siegel@atomicrules.com" , "asomalap@amd.com" , "somnath.kotur@broadcom.com" , "sthemmin@microsoft.com" , "steven.webster@windriver.com" , Sunil Kumar Kori , "mtetsuyah@gmail.com" , Veerasenareddy Burru , "viacheslavo@nvidia.com" , "xiao.w.wang@intel.com" , "cloud.wangxiaoyun@huawei.com" , "yisen.zhuang@huawei.com" , "yongwang@vmware.com" , "xuanziyang2@huawei.com" , Prasun Kapoor , Nadav Haklai , Satananda Burla , Narayana Prasad Raju Athreya , Akhil Goyal , "mdr@ashroe.eu" , "dmitry.kozliuk@gmail.com" , "anatoly.burakov@intel.com" , "cristian.dumitrescu@intel.com" , "honnappa.nagarahalli@arm.com" , "mattias.ronnblom@ericsson.com" , "ruifeng.wang@arm.com" , "drc@linux.vnet.ibm.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" , "jay.jayatheerthan@intel.com" , Ashwin Sekhar T K , Pavan Nikhilesh Bhagavatula , "eagostini@nvidia.com" , Derek Chickles , Parijat Shukla , Anup Prabhu , Prince Takkar Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 3, 2023 at 5:58 AM Stephen Hemminger wrote: > > On Wed, 1 Feb 2023 13:34:41 +0000 > Shivah Shankar Shankar Narayan Rao wrote: > > > +#define RTE_ML_STR_MAX 128 > > +/**< Maximum length of name string */ > > Fixed length strings do create long term technical issues. > But this is big enough, I doubt it matters. > > You may want to make sure that string is always at the end > of the struct to reduce cache foot print. I.e put important stuff first Yeah. fastpath stuff first in fast path structures.