All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Rasesh Mody <rmody@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
	 Ferruh Yigit <ferruh.yigit@intel.com>,
	GR-Everest-DPDK-Dev@marvell.com
Subject: Re: [dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW
Date: Thu, 3 Oct 2019 11:27:19 +0530	[thread overview]
Message-ID: <CALBAE1PzPsnz+eZ3Q9WaVUbcm45UWhoQ6Xmi3iOanEoC7hP-KQ@mail.gmail.com> (raw)
In-Reply-To: <20191002191456.28488-1-rmody@marvell.com>

On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> Hi,
>
> Currently, BNX2X PMD uses a very old firmware 7.2.51.
> This patch series updated the base driver to use to latest
> firmware 7.13.11. The latest firmware comprises of enhancements
> and fixes.
>
> v3:
> - Addressed gcc 9.2 build issues
> v2:
> - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11"
> - Addressed most of checkpatch issues
>
> Thanks!
> -Rasesh
>
> Rasesh Mody (3):
>   net/bnx2x: update and reorganize HW registers
>   net/bnx2x: update HSI code
>   net/bnx2x: update to latest FW 7.13.11

I don't think this patch comes as _base_ code, Please fix the trivial
and genuine check path errors.

[master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh

### net/bnx2x: update HSI code

WARNING:TYPO_SPELLING: 'entires' may be misspelled - perhaps 'entries'?
#863: FILE: drivers/net/bnx2x/ecore_hsi.h:2844:
+       /* 9 entires for the C2S PCP map for each inner VLAN PCP + 1 default */

total: 0 errors, 1 warnings, 0 checks, 5425 lines checked

### net/bnx2x: update to latest FW 7.13.11

CHECK:CAMELCASE: Avoid CamelCase: <assertListEntry>
#174: FILE: drivers/net/bnx2x/ecore_fw_defs.h:18:
+       (IRO[151].base + ((assertListEntry) * IRO[151].m1))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+       (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \
                                 ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+       (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \
                                                               ^

CHECK:CAMELCASE: Avoid CamelCase: <pfId>
#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+       (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23:
+       (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \
                                 ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23:
+       (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \
                                                               ^

CHECK:CAMELCASE: Avoid CamelCase: <funcId>
#193: FILE: drivers/net/bnx2x/ecore_fw_defs.h:26:
+       (IRO[163].base + ((funcId) * IRO[163].m1))

CHECK:CAMELCASE: Avoid CamelCase: <hcIndex>
#199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30:
+       (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2))

CHECK:CAMELCASE: Avoid CamelCase: <sbId>
#199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30:
+       (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32:
+       (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \
                                    ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32:
+       (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \

CHECK:CAMELCASE: Avoid CamelCase: <iscsiEqId>


                  [65/1889]
#215: FILE: drivers/net/bnx2x/ecore_fw_defs.h:40:
+       (IRO[316].base + ((pfId) * IRO[316].m1) + ((iscsiEqId) * IRO[316].m2))

CHECK:CAMELCASE: Avoid CamelCase: <vfId>
#287: FILE: drivers/net/bnx2x/ecore_fw_defs.h:87:
+#define CSTORM_VF_PF_CHANNEL_STATE_OFFSET(vfId) \

CHECK:CAMELCASE: Avoid CamelCase: <portId>
#368: FILE: drivers/net/bnx2x/ecore_fw_defs.h:142:
+       (IRO[187].base + ((portId) * IRO[187].m1))

CHECK:CAMELCASE: Avoid CamelCase: <clientId>
#414: FILE: drivers/net/bnx2x/ecore_fw_defs.h:172:
+       (IRO[215].base + ((portId) * IRO[215].m1) + ((clientId) * \

CHECK:CAMELCASE: Avoid CamelCase: <qzoneId>
#420: FILE: drivers/net/bnx2x/ecore_fw_defs.h:175:
+       (IRO[216].base + ((qzoneId) * IRO[216].m1))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241:
+       (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \
                                 ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241:
+       (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \
                                                               ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+       (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
                             ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+       (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
                                                        ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+       (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
                                                            ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                       ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                                                ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276:
+#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1)




                  [16/1889]
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                                                ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276:
+#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1)
                                                      ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#577: FILE: drivers/net/bnx2x/ecore_fw_defs.h:378:
+#define TSDM_TIMER_TICK_RESUL_CHIP (1 * (1e-6))
                                            ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r_order
== MAX_RD_ORD'
#1119: FILE: drivers/net/bnx2x/ecore_init_ops.h:499:
+       if ((CHIP_IS_E1(sc) || CHIP_IS_E1H(sc)) && (r_order == MAX_RD_ORD))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1537: FILE: drivers/net/bnx2x/ecore_sp.h:138:
+#define ECORE_ILT_ZALLOC(x, y, size)                           \
        do {                                                            \
                x = rte_malloc("", sizeof(struct bnx2x_dma),
RTE_CACHE_LINE_SIZE); \
                if (x) {                                                \
                        if (bnx2x_dma_alloc((struct bnx2x_softc *)sc,   \
                                          size, (struct bnx2x_dma *)x,  \
+                                         "ILT", RTE_CACHE_LINE_SIZE) != 0) { \
                                rte_free(x);                            \
                                x = NULL;                               \
+                               *(y) = 0;                               \
                        } else {                                        \
                                *y = ((struct bnx2x_dma *)x)->paddr;    \
                        }                                               \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#1537: FILE: drivers/net/bnx2x/ecore_sp.h:138:
+#define ECORE_ILT_ZALLOC(x, y, size)                           \
        do {                                                            \
                x = rte_malloc("", sizeof(struct bnx2x_dma),
RTE_CACHE_LINE_SIZE); \
                if (x) {                                                \
                        if (bnx2x_dma_alloc((struct bnx2x_softc *)sc,   \
                                          size, (struct bnx2x_dma *)x,  \
+                                         "ILT", RTE_CACHE_LINE_SIZE) != 0) { \
                                rte_free(x);                            \
                                x = NULL;                               \
+                               *(y) = 0;                               \
                        } else {                                        \
                                *y = ((struct bnx2x_dma *)x)->paddr;    \
                        }                                               \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?
#2191: FILE: drivers/net/bnx2x/ecore_sp.h:1967:
+#define PF_MAC_CREDIT_E2(sc, func_num)                                 \
+       ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_MAC_CREDIT_CNT) / \
+        (func_num) + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?


>
>  doc/guides/nics/bnx2x.rst          |    4 +-
>  drivers/net/bnx2x/bnx2x.c          |   63 +-
>  drivers/net/bnx2x/bnx2x.h          |   95 +-
>  drivers/net/bnx2x/bnx2x_osal.h     |   29 +
>  drivers/net/bnx2x/bnx2x_rxtx.c     |   10 +-
>  drivers/net/bnx2x/ecore_fw_defs.h  |  252 +-
>  drivers/net/bnx2x/ecore_hsi.h      | 3508 ++++++++-------
>  drivers/net/bnx2x/ecore_init.h     |  214 +-
>  drivers/net/bnx2x/ecore_init_ops.h |  192 +-
>  drivers/net/bnx2x/ecore_mfw_req.h  |   11 +-
>  drivers/net/bnx2x/ecore_reg.h      | 6617 +++++++++++++++++++---------
>  drivers/net/bnx2x/ecore_sp.c       |   48 +-
>  drivers/net/bnx2x/ecore_sp.h       |  308 +-
>  13 files changed, 7185 insertions(+), 4166 deletions(-)
>  create mode 100644 drivers/net/bnx2x/bnx2x_osal.h
>
> --
> 2.18.0
>

  reply	other threads:[~2019-10-03  5:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  7:25 [dpdk-dev] [PATCH 0/5] net/bnx2x: update to latest FW Rasesh Mody
2019-09-06  7:25 ` [dpdk-dev] [PATCH 1/5] net/bnx2x: update and reorganize HW registers Rasesh Mody
2019-09-12 12:17   ` Jerin Jacob
2019-09-19 21:28     ` [dpdk-dev] [EXT] " Rasesh Mody
2019-09-23 10:47   ` [dpdk-dev] " Jerin Jacob
2019-09-06  7:25 ` [dpdk-dev] [PATCH 2/5] net/bnx2x: update HSI code Rasesh Mody
2019-09-06  7:25 ` [dpdk-dev] [PATCH 3/5] net/bnx2x: update to latest FW 7.13.11 Rasesh Mody
2019-09-12 12:25   ` Jerin Jacob
2019-09-06  7:25 ` [dpdk-dev] [PATCH 4/5] doc: cleanup SPDX license id usage in bnx2x guide Rasesh Mody
2019-09-06  7:25 ` [dpdk-dev] [PATCH 5/5] net/bnx2x: change PMD version to 1.1.0.1 Rasesh Mody
2019-09-12 12:11 ` [dpdk-dev] [PATCH 0/5] net/bnx2x: update to latest FW Jerin Jacob
2019-09-12 22:00   ` [dpdk-dev] [EXT] " Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 0/4] " Rasesh Mody
2019-09-23 16:33   ` Ferruh Yigit
2019-09-24 15:39     ` Jerin Jacob
2019-09-24 15:57       ` Ferruh Yigit
2019-09-24 16:30         ` Jerin Jacob
2019-09-24 16:51           ` Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 1/4] net/bnx2x: update and reorganize HW registers Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 2/4] net/bnx2x: update HSI code Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 3/4] net/bnx2x: update to latest FW 7.13.11 Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 4/4] doc: cleanup SPDX license id usage in bnx2x guide Rasesh Mody
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW Rasesh Mody
2019-10-03  5:57   ` Jerin Jacob [this message]
2019-10-03  6:48     ` Rasesh Mody
2019-10-04  9:32       ` Jerin Jacob
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 1/3] net/bnx2x: update and reorganize HW registers Rasesh Mody
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 2/3] net/bnx2x: update HSI code Rasesh Mody
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 3/3] net/bnx2x: update to latest FW 7.13.11 Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1PzPsnz+eZ3Q9WaVUbcm45UWhoQ6Xmi3iOanEoC7hP-KQ@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=GR-Everest-DPDK-Dev@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=rmody@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.