From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/10] x86: Change board baud_rate to ulong
Date: Fri, 12 Oct 2012 12:00:25 +1100 [thread overview]
Message-ID: <CALButC+_EfEQawPK6AcyLXU+jggqgwVccn12dN2bW8iru6Q1vA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ3LGmFc2wXyPee-p9_mM1zQ9V0UbOSvUXNixKpdMtyK6A@mail.gmail.com>
Hi Simon,
On Fri, Oct 12, 2012 at 11:55 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi,
>
> On Thu, Oct 11, 2012 at 5:51 PM, Graeme Russ <graeme.russ@gmail.com> wrote:
>> Hi Simon,
>>
>> On Fri, Oct 12, 2012 at 11:46 AM, Simon Glass <sjg@chromium.org> wrote:
>>> Hi Wolfgang,
>>>
>>> On Thu, Oct 11, 2012 at 12:32 AM, Wolfgang Denk <wd@denx.de> wrote:
>>>> Dear Simon Glass,
>>>>
>>>> In message <1349910781-32088-2-git-send-email-sjg@chromium.org> you wrote:
>>>>> This is a ulong for some architectures and just unsigned for others.
>>>>> Change x86 to be consistent.
>>>>
>>>> Given the limited range for this variable it makes no sense to use a
>>>> long for this. Please fix this the other way round, i. e. change the
>>>> architectures that use a long.
>>>
>>> OK I will send out a series that changes them to unsigned long.
>>
>> Should we just change them all to u32 to be clear on the value range?
>
> Sorry, I meant unsigned int.
>
> Are there architectures in U-Boot which use a 16-bit int?
The C standard does not guarantee unsigned int will be at least
32-bits. It is possible (although I have not checked it) that
compiling 'real-mode' x86 code can produce 16-bit ints (not that we do
that in U-Boot)
using u32 will always guarantee a 32-bit unsigned value - better to be
safe than sorry
Regards,
Graeme
next prev parent reply other threads:[~2012-10-12 1:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 23:12 [U-Boot] [PATCH v2 0/10] x86: Patches to enable running U-Boot from coreboot Simon Glass
2012-10-10 23:12 ` [U-Boot] [PATCH v2 01/10] x86: Change board baud_rate to ulong Simon Glass
2012-10-11 0:15 ` Graeme Russ
2012-10-11 0:21 ` Graeme Russ
2012-10-11 7:32 ` Wolfgang Denk
2012-10-11 8:38 ` Graeme Russ
2012-10-12 0:46 ` Simon Glass
2012-10-12 0:51 ` Graeme Russ
2012-10-12 0:55 ` Simon Glass
2012-10-12 1:00 ` Graeme Russ [this message]
2012-10-12 1:14 ` Simon Glass
2012-10-10 23:12 ` [U-Boot] [PATCH v2 02/10] x86: Add initial memory barrier macros Simon Glass
2012-10-11 0:21 ` Graeme Russ
2012-10-10 23:12 ` [U-Boot] [PATCH v2 03/10] x86: Allow excluding reset vector code from u-boot Simon Glass
2012-10-11 0:22 ` Graeme Russ
2012-11-20 6:56 ` Wolfgang Denk
2012-11-26 6:03 ` Simon Glass
2012-10-10 23:12 ` [U-Boot] [PATCH v2 04/10] x86: Add some missing includes Simon Glass
2012-10-11 0:22 ` Graeme Russ
2012-10-10 23:12 ` [U-Boot] [PATCH v2 05/10] x86: coreboot: Move non-board specific files to coreboot arch directory Simon Glass
2012-10-11 0:23 ` Graeme Russ
2012-10-10 23:12 ` [U-Boot] [PATCH v2 06/10] x86: coreboot: Tell u-boot about PCI bus 0 when initializing Simon Glass
2012-10-11 0:23 ` Graeme Russ
2012-10-10 23:12 ` [U-Boot] [PATCH v2 07/10] x86: coreboot: Modify u-boot code to allow building coreboot payload Simon Glass
2012-10-11 0:24 ` Graeme Russ
2012-10-10 23:12 ` [U-Boot] [PATCH v2 08/10] x86: coreboot: Implement recursively scanning PCI busses Simon Glass
2012-10-11 0:24 ` Graeme Russ
2012-10-10 23:13 ` [U-Boot] [PATCH v2 09/10] x86: coreboot: Enable LPC TPM and CONFIG_NO_RESET_CODE Simon Glass
2012-10-11 0:25 ` Graeme Russ
2012-10-11 3:45 ` Marek Vasut
2012-10-11 3:47 ` Graeme Russ
2012-10-10 23:13 ` [U-Boot] [PATCH v2 10/10] x86: Remove coreboot start16 code Simon Glass
2012-10-11 0:25 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALButC+_EfEQawPK6AcyLXU+jggqgwVccn12dN2bW8iru6Q1vA@mail.gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.