From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755348AbcB2PmB (ORCPT ); Mon, 29 Feb 2016 10:42:01 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:34935 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbcB2Pl7 (ORCPT ); Mon, 29 Feb 2016 10:41:59 -0500 MIME-Version: 1.0 In-Reply-To: <1456752417-9626-11-git-send-email-mhocko@kernel.org> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-11-git-send-email-mhocko@kernel.org> From: Andy Lutomirski Date: Mon, 29 Feb 2016 07:41:39 -0800 Message-ID: Subject: Re: [PATCH 10/18] vdso: make arch_setup_additional_pages wait for mmap_sem for write killable To: Michal Hocko Cc: LKML , Andrew Morton , "linux-mm@kvack.org" , Alex Deucher , Alex Thorlton , Andrea Arcangeli , Benjamin LaHaise , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch , Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr Cermak , Thomas Gleixner , Michal Hocko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 29, 2016 at 5:26 AM, Michal Hocko wrote: > From: Michal Hocko > > most architectures are relying on mmap_sem for write in their > arch_setup_additional_pages. If the waiting task gets killed by the oom > killer it would block oom_reaper from asynchronous address space reclaim > and reduce the chances of timely OOM resolving. Wait for the lock in > the killable mode and return with EINTR if the task got killed while > waiting. Acked-by: Andy Lutomirski # for the x86 vdso From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH 10/18] vdso: make arch_setup_additional_pages wait for mmap_sem for write killable Date: Mon, 29 Feb 2016 07:41:39 -0800 Message-ID: References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-11-git-send-email-mhocko@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1456752417-9626-11-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org To: Michal Hocko Cc: LKML , Andrew Morton , "linux-mm@kvack.org" , Alex Deucher , Alex Thorlton , Andrea Arcangeli , Benjamin LaHaise , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch , Mel Gorman , Oleg Nesterov Peter List-Id: linux-arch.vger.kernel.org On Mon, Feb 29, 2016 at 5:26 AM, Michal Hocko wrote: > From: Michal Hocko > > most architectures are relying on mmap_sem for write in their > arch_setup_additional_pages. If the waiting task gets killed by the oom > killer it would block oom_reaper from asynchronous address space reclaim > and reduce the chances of timely OOM resolving. Wait for the lock in > the killable mode and return with EINTR if the task got killed while > waiting. Acked-by: Andy Lutomirski # for the x86 vdso -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f44.google.com (mail-oi0-f44.google.com [209.85.218.44]) by kanga.kvack.org (Postfix) with ESMTP id A281A6B0005 for ; Mon, 29 Feb 2016 10:41:59 -0500 (EST) Received: by mail-oi0-f44.google.com with SMTP id m82so107197515oif.1 for ; Mon, 29 Feb 2016 07:41:59 -0800 (PST) Received: from mail-ob0-x22c.google.com (mail-ob0-x22c.google.com. [2607:f8b0:4003:c01::22c]) by mx.google.com with ESMTPS id cp8si21963821oec.98.2016.02.29.07.41.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Feb 2016 07:41:58 -0800 (PST) Received: by mail-ob0-x22c.google.com with SMTP id xx9so24768719obc.2 for ; Mon, 29 Feb 2016 07:41:58 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1456752417-9626-11-git-send-email-mhocko@kernel.org> References: <1456752417-9626-1-git-send-email-mhocko@kernel.org> <1456752417-9626-11-git-send-email-mhocko@kernel.org> From: Andy Lutomirski Date: Mon, 29 Feb 2016 07:41:39 -0800 Message-ID: Subject: Re: [PATCH 10/18] vdso: make arch_setup_additional_pages wait for mmap_sem for write killable Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: LKML , Andrew Morton , "linux-mm@kvack.org" , Alex Deucher , Alex Thorlton , Andrea Arcangeli , Benjamin LaHaise , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Vetter , Dave Hansen , David Airlie , Davidlohr Bueso , David Rientjes , "H . Peter Anvin" , Hugh Dickins , Ingo Molnar , Johannes Weiner , "Kirill A . Shutemov" , Konstantin Khlebnikov , linux-arch , Mel Gorman , Oleg Nesterov , Peter Zijlstra , Petr Cermak , Thomas Gleixner , Michal Hocko On Mon, Feb 29, 2016 at 5:26 AM, Michal Hocko wrote: > From: Michal Hocko > > most architectures are relying on mmap_sem for write in their > arch_setup_additional_pages. If the waiting task gets killed by the oom > killer it would block oom_reaper from asynchronous address space reclaim > and reduce the chances of timely OOM resolving. Wait for the lock in > the killable mode and return with EINTR if the task got killed while > waiting. Acked-by: Andy Lutomirski # for the x86 vdso -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org