From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753513AbbCXTrH (ORCPT ); Tue, 24 Mar 2015 15:47:07 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:34764 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752426AbbCXTrE (ORCPT ); Tue, 24 Mar 2015 15:47:04 -0400 MIME-Version: 1.0 In-Reply-To: <20150324194402.GA27598@gmail.com> References: <202c56ca63823c338af8e2e54948dbe222da6343.1426728647.git.luto@kernel.org> <20150324194402.GA27598@gmail.com> From: Andy Lutomirski Date: Tue, 24 Mar 2015 12:46:42 -0700 Message-ID: Subject: Re: [tip:x86/asm] x86/asm/entry: Add user_mode_ignore_vm86() To: Ingo Molnar Cc: "H. Peter Anvin" , Brad Spengler , Linus Torvalds , Borislav Petkov , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Andrew Lutomirski , Denys Vlasenko , "linux-tip-commits@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 12:44 PM, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > >> On Mon, Mar 23, 2015 at 5:26 AM, tip-bot for Andy Lutomirski >> wrote: >> > Commit-ID: a67e7277d01ccfd39b0db5a198c2643cc19dd79c >> > Gitweb: http://git.kernel.org/tip/a67e7277d01ccfd39b0db5a198c2643cc19dd79c >> > Author: Andy Lutomirski >> > AuthorDate: Wed, 18 Mar 2015 18:33:29 -0700 >> > Committer: Ingo Molnar >> > CommitDate: Mon, 23 Mar 2015 11:13:36 +0100 >> > >> > x86/asm/entry: Add user_mode_ignore_vm86() >> > >> > user_mode() is dangerous and user_mode_vm() has a confusing name. >> > >> > Add user_mode_ignore_vm86() (equivalent to current user_mode()). >> > We'll change the small number of legitimate users of user_mode() >> > to user_mode_ignore_vm86(). >> > >> > Inspired by grsec, although this works rather differently. >> >> Ingo, does this mean that you changed your mind or do you still want >> a patch to delete user_mode_ignore_vm86 and just use user_mode >> everywhere instead? > > Would be still nice to have it as an add on patch, if you agree with > my arguments. Given that there are only a very small number of callers left and they're all Obviously Correct (tm), I'm not too worried about it. Maybe if we kill off __copy_to_user, I'll be inspired to kill off user_mode_ignore_vm86 as well :) --Andy > > I picked up your series as-is because it's correct and because it > already improves things a lot in this area. > > Thanks, > > Ingo -- Andy Lutomirski AMA Capital Management, LLC