From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B4CEC433E6 for ; Sun, 31 Jan 2021 02:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68BD064E1C for ; Sun, 31 Jan 2021 02:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230438AbhAaC6x (ORCPT ); Sat, 30 Jan 2021 21:58:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:58806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbhAaC6v (ORCPT ); Sat, 30 Jan 2021 21:58:51 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F02B964E20 for ; Sun, 31 Jan 2021 02:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612061891; bh=2ZuL0ipkHZksLJpXozGUIZWFSxAx6TjngbQg46FjVM4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nDjn+UMdjG1f8RaeG7NRfTa5sthGZmBxu704daUKOBV7vqFzHbcVnU/tC+JrhdQes q2zFmGj79Tw8LVpmYqfeXtiX8EHeRKIjObO7WEFFRzDnzgfo7g10ieVUSA0oYaw47L QsEH2wz6BBjm7ra4G+59DOMncVLb7bRZ+mZwusTreVCc1oJlDUKcYWgUkPAXhHNKjC aft7Olq0QOOvWnDx/pWxibmoLAplDCnUXONCEiUv/WewqJ6GmKLFAsbjGwr5kW15ao 88ffk8Rp7fdlJQSJNOH+sO7UZZT4P6Qvoq5lGbLT1UzrPDOglUkA2YHI3lu4lGZA6C 4v5xa2Er41FSw== Received: by mail-ej1-f54.google.com with SMTP id kg20so18903983ejc.4 for ; Sat, 30 Jan 2021 18:58:10 -0800 (PST) X-Gm-Message-State: AOAM532x+1e5Rxlt6UNVsBfWS0zFJ5FnB96dLSynOce/fv9mo2ZhNyKr QF+lDhKBToKogGLsZOCOECHVsGQUwxXPkgRk5GbIFw== X-Google-Smtp-Source: ABdhPJzuvMeoa5x43Osfwv5jGxZhV69eYEA9EJO6fmryJgk55JeUN54QNBUrDa6b4orPYL5iQvjaHV8eULSlbn7/NbA= X-Received: by 2002:a17:906:5608:: with SMTP id f8mr11420554ejq.101.1612061889455; Sat, 30 Jan 2021 18:58:09 -0800 (PST) MIME-Version: 1.0 References: <20210131001132.3368247-1-namit@vmware.com> <20210131001132.3368247-2-namit@vmware.com> In-Reply-To: From: Andy Lutomirski Date: Sat, 30 Jan 2021 18:57:58 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 01/20] mm/tlb: fix fullmm semantics To: Nadav Amit Cc: Andy Lutomirski , Linux-MM , LKML , Andrea Arcangeli , Andrew Morton , Dave Hansen , Peter Zijlstra , Thomas Gleixner , Will Deacon , Yu Zhao , Nick Piggin , X86 ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 30, 2021 at 5:19 PM Nadav Amit wrote: > > > On Jan 30, 2021, at 5:02 PM, Andy Lutomirski wrote: > > > > On Sat, Jan 30, 2021 at 4:16 PM Nadav Amit wrote: > >> From: Nadav Amit > >> > >> fullmm in mmu_gather is supposed to indicate that the mm is torn-down > >> (e.g., on process exit) and can therefore allow certain optimizations. > >> However, tlb_finish_mmu() sets fullmm, when in fact it want to say that > >> the TLB should be fully flushed. > > > > Maybe also rename fullmm? > > Possible. How about mm_torn_down? Sure. Or mm_exiting, perhaps? > > I should have also changed the comment in tlb_finish_mmu(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE07C433DB for ; Sun, 31 Jan 2021 02:58:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A8D264DED for ; Sun, 31 Jan 2021 02:58:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A8D264DED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25BB26B0005; Sat, 30 Jan 2021 21:58:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20B8F6B0006; Sat, 30 Jan 2021 21:58:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FAD16B006C; Sat, 30 Jan 2021 21:58:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id EAD3B6B0005 for ; Sat, 30 Jan 2021 21:58:12 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A79223635 for ; Sun, 31 Jan 2021 02:58:12 +0000 (UTC) X-FDA: 77764561224.23.cover19_2006a29275b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 8C04C37604 for ; Sun, 31 Jan 2021 02:58:12 +0000 (UTC) X-HE-Tag: cover19_2006a29275b6 X-Filterd-Recvd-Size: 3271 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Sun, 31 Jan 2021 02:58:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D674164E19 for ; Sun, 31 Jan 2021 02:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612061891; bh=2ZuL0ipkHZksLJpXozGUIZWFSxAx6TjngbQg46FjVM4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nDjn+UMdjG1f8RaeG7NRfTa5sthGZmBxu704daUKOBV7vqFzHbcVnU/tC+JrhdQes q2zFmGj79Tw8LVpmYqfeXtiX8EHeRKIjObO7WEFFRzDnzgfo7g10ieVUSA0oYaw47L QsEH2wz6BBjm7ra4G+59DOMncVLb7bRZ+mZwusTreVCc1oJlDUKcYWgUkPAXhHNKjC aft7Olq0QOOvWnDx/pWxibmoLAplDCnUXONCEiUv/WewqJ6GmKLFAsbjGwr5kW15ao 88ffk8Rp7fdlJQSJNOH+sO7UZZT4P6Qvoq5lGbLT1UzrPDOglUkA2YHI3lu4lGZA6C 4v5xa2Er41FSw== Received: by mail-ej1-f51.google.com with SMTP id ke15so18825170ejc.12 for ; Sat, 30 Jan 2021 18:58:10 -0800 (PST) X-Gm-Message-State: AOAM533r2U7yPhsfTg8e9sNznxQI3Ca+fRkrMSXF4Ta7wzjGZZM/yo/R U7tB9LfHDQIWkeFfIVPss69kXNjEoH+0JCIPZ612Rw== X-Google-Smtp-Source: ABdhPJzuvMeoa5x43Osfwv5jGxZhV69eYEA9EJO6fmryJgk55JeUN54QNBUrDa6b4orPYL5iQvjaHV8eULSlbn7/NbA= X-Received: by 2002:a17:906:5608:: with SMTP id f8mr11420554ejq.101.1612061889455; Sat, 30 Jan 2021 18:58:09 -0800 (PST) MIME-Version: 1.0 References: <20210131001132.3368247-1-namit@vmware.com> <20210131001132.3368247-2-namit@vmware.com> In-Reply-To: From: Andy Lutomirski Date: Sat, 30 Jan 2021 18:57:58 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 01/20] mm/tlb: fix fullmm semantics To: Nadav Amit Cc: Andy Lutomirski , Linux-MM , LKML , Andrea Arcangeli , Andrew Morton , Dave Hansen , Peter Zijlstra , Thomas Gleixner , Will Deacon , Yu Zhao , Nick Piggin , X86 ML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 30, 2021 at 5:19 PM Nadav Amit wrote: > > > On Jan 30, 2021, at 5:02 PM, Andy Lutomirski wrote: > > > > On Sat, Jan 30, 2021 at 4:16 PM Nadav Amit wrote: > >> From: Nadav Amit > >> > >> fullmm in mmu_gather is supposed to indicate that the mm is torn-down > >> (e.g., on process exit) and can therefore allow certain optimizations. > >> However, tlb_finish_mmu() sets fullmm, when in fact it want to say that > >> the TLB should be fully flushed. > > > > Maybe also rename fullmm? > > Possible. How about mm_torn_down? Sure. Or mm_exiting, perhaps? > > I should have also changed the comment in tlb_finish_mmu().