From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D7AC282CE for ; Tue, 4 Jun 2019 20:32:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D13E20848 for ; Tue, 4 Jun 2019 20:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559680350; bh=9sDZU19/Kb3jU11bUCd3XZ92C4kNtHvwtUFMEx9ULmw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=2g6uuUh4r9sQfBAZ782qjIohhpYGiRK1TGALxPYiTwAQUt9O1XeZWUjsz6sorwU62 cizZ4EaYr5xoqdj0f1H0uTm0v4C96YvRyGH3ZRU15nYuwwOCrf21pTJKLWNtl2yrMV bKJn+4qBz4iMcexhe1XDeotbLdCPCMn1FbXOkEY0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726851AbfFDUc3 (ORCPT ); Tue, 4 Jun 2019 16:32:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:60410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbfFDUc0 (ORCPT ); Tue, 4 Jun 2019 16:32:26 -0400 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E9D9920863 for ; Tue, 4 Jun 2019 20:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559679923; bh=9sDZU19/Kb3jU11bUCd3XZ92C4kNtHvwtUFMEx9ULmw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YznqkV5OPlnaq+Ug+Uiu3Omc0QBbSzhN+xqkGs7jbVcRZCmGQDKPgfQHQvmoqFCEz B2mt+gJcoMcz63SfC4huy1JwgW2Ul3NPzBdXUG1IBouA46iNQdkhcGPflg0S8u2Nu7 WXsIPVqVJ5bwn7ri6Rl1lZbR2/YYt4wM913gwXhk= Received: by mail-wr1-f47.google.com with SMTP id x4so17191674wrt.6 for ; Tue, 04 Jun 2019 13:25:22 -0700 (PDT) X-Gm-Message-State: APjAAAX4hRDYhbAOtV5wufZMoBKQTb6JwgEaYriZHsOteybhwDDjkskB G0oaBMS+fZXUgJSIw3WOZiPJoTxfIuPGWa+1ep77ww== X-Google-Smtp-Source: APXvYqysczE0WCFAw9A2ekaDQXIExESkgzbRePbJWfnmPHTmIpwjyZf8K5tnfHa6NYctc+YamSt9R5W/FajQBcCOU+c= X-Received: by 2002:a5d:6207:: with SMTP id y7mr3944378wru.265.1559679921568; Tue, 04 Jun 2019 13:25:21 -0700 (PDT) MIME-Version: 1.0 References: <20190531233159.30992-1-sean.j.christopherson@intel.com> <20190531233159.30992-8-sean.j.christopherson@intel.com> <20190604162555.GC3811@linux.intel.com> In-Reply-To: <20190604162555.GC3811@linux.intel.com> From: Andy Lutomirski Date: Tue, 4 Jun 2019 13:25:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 7/9] x86/sgx: Enforce noexec filesystem restriction for enclaves To: Jarkko Sakkinen Cc: Sean Christopherson , Andy Lutomirski , Cedric Xing , Stephen Smalley , James Morris , "Serge E . Hallyn" , LSM List , Paul Moore , Eric Paris , selinux@vger.kernel.org, Jethro Beekman , Dave Hansen , Thomas Gleixner , Linus Torvalds , LKML , X86 ML , linux-sgx@vger.kernel.org, Andrew Morton , nhorman@redhat.com, npmccallum@redhat.com, Serge Ayoun , Shay Katz-zamir , Haitao Huang , Andy Shevchenko , Kai Svahn , Borislav Petkov , Josh Triplett , Kai Huang , David Rientjes , William Roberts , Philip Tricca Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 4, 2019 at 9:26 AM Jarkko Sakkinen wrote: > > On Fri, May 31, 2019 at 04:31:57PM -0700, Sean Christopherson wrote: > > Do not allow an enclave page to be mapped with PROT_EXEC if the source > > page is backed by a file on a noexec file system. > > > > Signed-off-by: Sean Christopherson > > Why don't you just check in sgx_encl_add_page() that whether the path > comes from noexec and deny if SECINFO contains X? > SECINFO seems almost entirely useless for this kind of thing because of SGX2. I'm thinking that SECINFO should be completely ignored for anything other than its required architectural purpose.