All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Brian Gerst <brgerst@gmail.com>,
	X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] x86/vdso: Use static_cpu_has()
Date: Mon, 25 Jan 2016 10:45:30 -0800	[thread overview]
Message-ID: <CALCETrUt42BNJEY+dskCKF8Tmwu0keMo0L-faxefMKBcKRGRFg@mail.gmail.com> (raw)
In-Reply-To: <1453627728-27197-7-git-send-email-bp@alien8.de>

On Sun, Jan 24, 2016 at 1:28 AM, Borislav Petkov <bp@alien8.de> wrote:
> From: Borislav Petkov <bp@suse.de>
>
> ... and simplify and speed up a tad.

This function is only used when initializing CPUs, so the "tad" is
very small indeed.

If there are systems for which some cpus support rdtscp and some
don't, then this patch is wrong.  Of course, if the bsp has rdtscp and
the aps don't, then we're screwed anyway.  I left it as cpu_has
because this is a cpu init function and it seemed reasonable.

That being said, I have no meaningful objection to this patch.

--Andy

  reply	other threads:[~2016-01-25 18:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24  9:28 [PATCH 0/6] x86/cpufeature: Cleanups and improvements v1 Borislav Petkov
2016-01-24  9:28 ` [PATCH 1/6] x86/cpufeature: Carve out X86_FEATURE_* Borislav Petkov
2016-01-24  9:28 ` [PATCH 2/6] x86/cpufeature: Replace the old static_cpu_has() with safe variant Borislav Petkov
2016-01-24  9:28 ` [PATCH 3/6] x86/cpufeature: Get rid of the non-asm goto variant Borislav Petkov
2016-01-24  9:28 ` [PATCH 4/6] x86/alternatives: Add an auxilary section Borislav Petkov
2016-01-24  9:28 ` [PATCH 5/6] x86/alternatives: Discard dynamic check after init Borislav Petkov
2016-01-24  9:28 ` [PATCH 6/6] x86/vdso: Use static_cpu_has() Borislav Petkov
2016-01-25 18:45   ` Andy Lutomirski [this message]
2016-01-25 18:58     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALCETrUt42BNJEY+dskCKF8Tmwu0keMo0L-faxefMKBcKRGRFg@mail.gmail.com \
    --to=luto@amacapital.net \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.