All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Joerg Roedel <jroedel@suse.de>, KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Sebastian Ott <sebott@linux.vnet.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Andy Lutomirski <luto@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	sparclinux@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Linux Virtualization <virtualization@lists.linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>,
	"David S. Miller" <davem@davemloft.net>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH v5 00/10] virtio DMA API, yet again
Date: Sun, 31 Jan 2016 12:16:18 -0800	[thread overview]
Message-ID: <CALCETrUtRx3Lzzsjg3ugictuNVNcQK_9+6LYnH2OUZZV9PiFZQ__41433.0648877241$1454271414$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <20160131201232.GA1643@redhat.com>

On Sun, Jan 31, 2016 at 12:12 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Jan 28, 2016 at 06:31:13PM -0800, Andy Lutomirski wrote:
>> This switches virtio to use the DMA API on Xen and if requested by
>> module option.
>>
>> This fixes virtio on Xen, and it should break anything because it's
>> off by default on everything except Xen PV on x86.
>>
>> To the Xen people: is this okay?  If it doesn't work on other Xen
>> variants (PVH? HVM?), can you submit follow-up patches to fix it?
>>
>> To everyone else: we've waffled on this for way too long.  I think
>> we should to get DMA API implementation in with a conservative
>> policy like this rather than waiting until we achieve perfection.
>> I'm tired of carrying these patches around.
>
> I agree, thanks for working on this!
>
>> Michael, if these survive review, can you stage these in your tree?
>
> Yes, I'll stage everything except 10/10. I'd rather not maintain a
> module option like this, things work for now and I'm working on a
> clean solution for things like dpdk within guest.

The module option was mainly for testing, but patching in a "return
true" works just as well.

I ran the code through the DMA API debugging stuff and swiotlb=force
with the module option set under KVM (no Xen), and everything seemed
to work.

--Andy

  reply	other threads:[~2016-01-31 20:16 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29  2:31 [PATCH v5 00/10] virtio DMA API, yet again Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 01/10] dma: Provide simple noop dma ops Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 02/10] alpha/dma: use common " Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 03/10] s390/dma: Allow per device " Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 04/10] vring: Introduce vring_use_dma_api() Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-02-01 11:22   ` David Woodhouse
2016-02-01 11:22   ` David Woodhouse
2016-02-01 11:22     ` David Woodhouse
2016-02-01 11:22     ` David Woodhouse
2016-02-01 13:23     ` Michael S. Tsirkin
2016-02-01 13:23       ` Michael S. Tsirkin
2016-02-01 13:23       ` Michael S. Tsirkin
2016-02-01 15:39       ` Andy Lutomirski
2016-02-01 15:39       ` Andy Lutomirski
2016-02-01 15:39         ` Andy Lutomirski
2016-02-01 16:11         ` David Woodhouse
2016-02-01 16:11         ` David Woodhouse
2016-02-01 16:11         ` David Woodhouse
2016-02-01 15:39       ` Andy Lutomirski
2016-02-01 13:23     ` Michael S. Tsirkin
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 05/10] virtio_ring: Support DMA APIs Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 06/10] virtio: Add improved queue allocation API Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 07/10] virtio_mmio: Use the DMA API if enabled Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 08/10] virtio_pci: " Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 09/10] vring: Use the DMA API on Xen Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29 10:34   ` [Xen-devel] " David Vrabel
2016-01-29 10:34   ` David Vrabel
2016-01-29 10:34     ` David Vrabel
2016-01-31 20:09     ` Michael S. Tsirkin
2016-01-31 20:09       ` Michael S. Tsirkin
2016-01-31 20:09       ` Michael S. Tsirkin
2016-01-31 20:13       ` Andy Lutomirski
2016-01-31 20:13         ` Andy Lutomirski
2016-01-31 20:13         ` Andy Lutomirski
2016-01-31 20:18         ` Michael S. Tsirkin
2016-01-31 20:18         ` [Xen-devel] " Michael S. Tsirkin
2016-01-31 20:18           ` Michael S. Tsirkin
2016-01-31 20:18           ` Michael S. Tsirkin
2016-01-31 20:27           ` Andy Lutomirski
2016-01-31 20:27           ` Andy Lutomirski
2016-01-31 20:27             ` Andy Lutomirski
2016-01-31 20:27           ` Andy Lutomirski
2016-01-31 20:13       ` Andy Lutomirski
2016-02-01 21:24       ` [Xen-devel] " Wei Liu
2016-02-01 21:24         ` Wei Liu
2016-02-01 21:24         ` Wei Liu
2016-02-01 21:24       ` Wei Liu
2016-01-31 20:09     ` Michael S. Tsirkin
2016-01-29 10:34   ` David Vrabel
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31 ` [PATCH v5 10/10] vring: Add a module parameter to force-enable the DMA API Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29  2:31   ` Andy Lutomirski
2016-01-29  2:31 ` Andy Lutomirski
2016-01-29 11:01 ` [PATCH v5 00/10] virtio DMA API, yet again David Woodhouse
2016-01-29 11:01 ` David Woodhouse
2016-01-29 11:01 ` David Woodhouse
2016-01-31 19:06   ` Christoph Hellwig
2016-01-31 19:06     ` Christoph Hellwig
2016-01-31 19:06     ` Christoph Hellwig
2016-01-31 19:06   ` Christoph Hellwig
2016-01-31 20:12 ` Michael S. Tsirkin
2016-01-31 20:12 ` Michael S. Tsirkin
2016-01-31 20:12 ` Michael S. Tsirkin
2016-01-31 20:12   ` Michael S. Tsirkin
2016-01-31 20:16   ` Andy Lutomirski [this message]
2016-01-31 20:16   ` Andy Lutomirski
2016-01-31 20:16     ` Andy Lutomirski
2016-01-31 20:16   ` Andy Lutomirski
2016-02-01 11:00 ` [Xen-devel] " Wei Liu
2016-02-01 11:00   ` Wei Liu
2016-02-01 11:00   ` Wei Liu
2016-02-01 18:04   ` Andy Lutomirski
2016-02-01 18:04   ` [Xen-devel] " Andy Lutomirski
2016-02-01 18:04     ` Andy Lutomirski
2016-02-01 18:04     ` Andy Lutomirski
2016-02-01 21:22     ` Wei Liu
2016-02-01 21:22       ` Wei Liu
2016-02-01 21:22       ` Wei Liu
2016-02-01 21:22     ` Wei Liu
2016-02-01 11:00 ` Wei Liu
  -- strict thread matches above, loose matches on Subject: below --
2016-01-29  2:31 Andy Lutomirski
2016-01-29  2:31 Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALCETrUtRx3Lzzsjg3ugictuNVNcQK_9+6LYnH2OUZZV9PiFZQ__41433.0648877241$1454271414$gmane$org@mail.gmail.com' \
    --to=luto@amacapital.net \
    --cc=benh@kernel.crashing.org \
    --cc=borntraeger@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=david.vrabel@citrix.com \
    --cc=dwmw2@infradead.org \
    --cc=hch@lst.de \
    --cc=jroedel@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=sebott@linux.vnet.ibm.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.