From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbcFWTKQ (ORCPT ); Thu, 23 Jun 2016 15:10:16 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:35037 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbcFWTKN (ORCPT ); Thu, 23 Jun 2016 15:10:13 -0400 MIME-Version: 1.0 In-Reply-To: <20160623185340.GO30154@twins.programming.kicks-ass.net> References: <20160623143126.GA16664@redhat.com> <20160623170352.GA17372@redhat.com> <20160623185340.GO30154@twins.programming.kicks-ass.net> From: Andy Lutomirski Date: Thu, 23 Jun 2016 12:09:53 -0700 Message-ID: Subject: Re: [PATCH v3 00/13] Virtually mapped stacks with guard pages (x86, core) To: Peter Zijlstra Cc: Linus Torvalds , Oleg Nesterov , Andy Lutomirski , "the arch/x86 maintainers" , Linux Kernel Mailing List , "linux-arch@vger.kernel.org" , Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf , Jann Horn , Heiko Carstens Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 11:53 AM, Peter Zijlstra wrote: > On Thu, Jun 23, 2016 at 10:52:58AM -0700, Linus Torvalds wrote: >> Ugh. Looking around at this, it turns out that a great example of this >> kind of legacy issue is the debug_mutex stuff. >> >> It uses "struct thread_info *" as the owner pointer, and there is _no_ >> existing reason for it. In fact, in every single place it actually >> wants the task_struct, and it does task_thread_info(task) just to >> convert it to the thread-info, and then converts it back with >> "ti->task". >> >> So the attached patch seems to be the right thing to do regardless of >> this whole discussion. > > Yeah, that looks fine. Want me to take it or will you just commit? PeterZ, mind if I split it into a couple of patches, test it, and add it to my series? --Andy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH v3 00/13] Virtually mapped stacks with guard pages (x86, core) Date: Thu, 23 Jun 2016 12:09:53 -0700 Message-ID: References: <20160623143126.GA16664@redhat.com> <20160623170352.GA17372@redhat.com> <20160623185340.GO30154@twins.programming.kicks-ass.net> Reply-To: kernel-hardening@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20160623185340.GO30154@twins.programming.kicks-ass.net> To: Peter Zijlstra Cc: Linus Torvalds , Oleg Nesterov , Andy Lutomirski , the arch/x86 maintainers , Linux Kernel Mailing List , "linux-arch@vger.kernel.org" , Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf , Jann Horn , Heiko Carstens List-Id: linux-arch.vger.kernel.org On Thu, Jun 23, 2016 at 11:53 AM, Peter Zijlstra wrote: > On Thu, Jun 23, 2016 at 10:52:58AM -0700, Linus Torvalds wrote: >> Ugh. Looking around at this, it turns out that a great example of this >> kind of legacy issue is the debug_mutex stuff. >> >> It uses "struct thread_info *" as the owner pointer, and there is _no_ >> existing reason for it. In fact, in every single place it actually >> wants the task_struct, and it does task_thread_info(task) just to >> convert it to the thread-info, and then converts it back with >> "ti->task". >> >> So the attached patch seems to be the right thing to do regardless of >> this whole discussion. > > Yeah, that looks fine. Want me to take it or will you just commit? PeterZ, mind if I split it into a couple of patches, test it, and add it to my series? --Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com MIME-Version: 1.0 In-Reply-To: <20160623185340.GO30154@twins.programming.kicks-ass.net> References: <20160623143126.GA16664@redhat.com> <20160623170352.GA17372@redhat.com> <20160623185340.GO30154@twins.programming.kicks-ass.net> From: Andy Lutomirski Date: Thu, 23 Jun 2016 12:09:53 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [kernel-hardening] Re: [PATCH v3 00/13] Virtually mapped stacks with guard pages (x86, core) To: Peter Zijlstra Cc: Linus Torvalds , Oleg Nesterov , Andy Lutomirski , the arch/x86 maintainers , Linux Kernel Mailing List , "linux-arch@vger.kernel.org" , Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf , Jann Horn , Heiko Carstens List-ID: On Thu, Jun 23, 2016 at 11:53 AM, Peter Zijlstra wrote: > On Thu, Jun 23, 2016 at 10:52:58AM -0700, Linus Torvalds wrote: >> Ugh. Looking around at this, it turns out that a great example of this >> kind of legacy issue is the debug_mutex stuff. >> >> It uses "struct thread_info *" as the owner pointer, and there is _no_ >> existing reason for it. In fact, in every single place it actually >> wants the task_struct, and it does task_thread_info(task) just to >> convert it to the thread-info, and then converts it back with >> "ti->task". >> >> So the attached patch seems to be the right thing to do regardless of >> this whole discussion. > > Yeah, that looks fine. Want me to take it or will you just commit? PeterZ, mind if I split it into a couple of patches, test it, and add it to my series? --Andy