From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754182AbcAIBtw (ORCPT ); Fri, 8 Jan 2016 20:49:52 -0500 Received: from mail-oi0-f49.google.com ([209.85.218.49]:34255 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbcAIBtu (ORCPT ); Fri, 8 Jan 2016 20:49:50 -0500 MIME-Version: 1.0 In-Reply-To: <19f6403f2b04d3448ed2ac958e656645d8b6e70c.1452297867.git.tony.luck@intel.com> References: <19f6403f2b04d3448ed2ac958e656645d8b6e70c.1452297867.git.tony.luck@intel.com> From: Andy Lutomirski Date: Fri, 8 Jan 2016 17:49:30 -0800 Message-ID: Subject: Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() To: Tony Luck Cc: linux-nvdimm , Dan Williams , Borislav Petkov , "linux-kernel@vger.kernel.org" , Andrew Morton , Robert , Ingo Molnar , "linux-mm@kvack.org" , X86 ML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jan 8, 2016 4:19 PM, "Tony Luck" wrote: > > Make use of the EXTABLE_FAULT exception table entries. This routine > returns a structure to indicate the result of the copy: Perhaps this is silly, but could we make this feature depend on ERMS and thus make the code a lot simpler? Also, what's the sfence for? You don't seem to be using any non-temporal operations. --Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f176.google.com (mail-ob0-f176.google.com [209.85.214.176]) by kanga.kvack.org (Postfix) with ESMTP id 2D175828DE for ; Fri, 8 Jan 2016 20:49:51 -0500 (EST) Received: by mail-ob0-f176.google.com with SMTP id ba1so368879625obb.3 for ; Fri, 08 Jan 2016 17:49:51 -0800 (PST) Received: from mail-oi0-x22a.google.com (mail-oi0-x22a.google.com. [2607:f8b0:4003:c06::22a]) by mx.google.com with ESMTPS id oo8si8298311obb.53.2016.01.08.17.49.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jan 2016 17:49:50 -0800 (PST) Received: by mail-oi0-x22a.google.com with SMTP id o124so13588886oia.3 for ; Fri, 08 Jan 2016 17:49:50 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <19f6403f2b04d3448ed2ac958e656645d8b6e70c.1452297867.git.tony.luck@intel.com> References: <19f6403f2b04d3448ed2ac958e656645d8b6e70c.1452297867.git.tony.luck@intel.com> From: Andy Lutomirski Date: Fri, 8 Jan 2016 17:49:30 -0800 Message-ID: Subject: Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Tony Luck Cc: linux-nvdimm , Dan Williams , Borislav Petkov , "linux-kernel@vger.kernel.org" , Andrew Morton , Robert , Ingo Molnar , "linux-mm@kvack.org" , X86 ML On Jan 8, 2016 4:19 PM, "Tony Luck" wrote: > > Make use of the EXTABLE_FAULT exception table entries. This routine > returns a structure to indicate the result of the copy: Perhaps this is silly, but could we make this feature depend on ERMS and thus make the code a lot simpler? Also, what's the sfence for? You don't seem to be using any non-temporal operations. --Andy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org