From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CE1C47257 for ; Sun, 3 May 2020 00:30:16 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B96520721 for ; Sun, 3 May 2020 00:30:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=amacapital-net.20150623.gappssmtp.com header.i=@amacapital-net.20150623.gappssmtp.com header.b="E1AEkHox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B96520721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amacapital.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 9F1C411613790; Sat, 2 May 2020 17:28:48 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::342; helo=mail-wm1-x342.google.com; envelope-from=luto@amacapital.net; receiver= Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 42B5E1161378C for ; Sat, 2 May 2020 17:28:45 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id z6so4597045wml.2 for ; Sat, 02 May 2020 17:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=V2nT+jmzW6uK6j6RNvaRunaFhSFW7qRx5cWISy3xtsQ=; b=E1AEkHox21046/Jzv0H2sg0BIzJvXI5WKdhrIfyzhtFbc0BBr2Jbbo4W/cz61zuCWi N7wfdgGQbbeddGO74JguUI2EXq4+V2iEf/49y27rGKNWMBfesVlzBgPOzVPeBAWsDjVi MwfyIgQ4sj5GybFYWk26pinWgUjQkfCWZ6xmmDA/YANZdJExvY+1eHRU0qsu08dgxRg4 yba0Fz8wK4DVM4JNI9vneWIr8MwO1iTNEI1j2c8OtrlAD2zgZyVuN0UPndhOvADA09K0 oGD9E7oaU2Xm77LaL1nDwVx5b0TQ2W5oTxfvUMvijPlQLM0HQwCdOkQFHHjX+VELIOiy 0BvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=V2nT+jmzW6uK6j6RNvaRunaFhSFW7qRx5cWISy3xtsQ=; b=jCvbyz5HBqtoDUVdZK7Q1vJPtv+Z/2tGdZoXvebVPjID3ruDxcNK0tDsXseumZHUm0 GwzR9whC7fZbUGSjmHp1cuFV3wbDqBCYlij2zS2T3rObLRJ+IKjUd+TRlC9ltIGCfSBz OpqmIyJ223rbSAMiUJfm4+4ZDkI4p/E1T/z+Ch6I548hRk637CzmRzKrx14WaIh/yGUk +n9jnoP5SHWsPRuUTAafjOX6Kd6D67Gnta8PZob3tlzqybLr1PrWbtHwKeOHEYMHSZrI IrVotLdGTJCW4GysRkrRXIEh4V/L/B/Y+UXTIeqAv2eSunNSkHcCzvY87viq2pbJ3Pax J/VQ== X-Gm-Message-State: AGi0PuY3q0/EwHeoZMjUHOWCACJpt4RgAFIuQbJACSDJcCdyN0yXWtKE jTkzV6kXs54gflX93bUuvlfY8XUM7Fq0r6mNmv95ww== X-Google-Smtp-Source: APiQypK033BSVa5j3+ZhThYcEUFkwS26U4I4SJPdSG0fksA6GljM8v6NbCEY+NCeISjVSggtF2WxUBXyAZEAOTUxbUM= X-Received: by 2002:a1c:4186:: with SMTP id o128mr6735406wma.21.1588465809902; Sat, 02 May 2020 17:30:09 -0700 (PDT) MIME-Version: 1.0 References: <1962EE67-8AD1-409D-963A-4F1E1AB3B865@amacapital.net> <3908561D78D1C84285E8C5FCA982C28F7F60EBB6@ORSMSX115.amr.corp.intel.com> In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F60EBB6@ORSMSX115.amr.corp.intel.com> From: Andy Lutomirski Date: Sat, 2 May 2020 17:29:57 -0700 Message-ID: Subject: Re: [PATCH v2 0/2] Replace and improve "mcsafe" with copy_safe() To: "Luck, Tony" Message-ID-Hash: HNNC544O2V56D7FJS2TR5Z67YVCMJE37 X-Message-ID-Hash: HNNC544O2V56D7FJS2TR5Z67YVCMJE37 X-MailFrom: luto@amacapital.net X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Linus Torvalds , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Borislav Petkov , stable , the arch/x86 maintainers , "H. Peter Anvin" , Paul Mackerras , Benjamin Herrenschmidt , "Tsaur, Erwin" , Michael Ellerman , Arnaldo Carvalho de Melo , linux-nvdimm , Linux Kernel Mailing List X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gRnJpLCBNYXkgMSwgMjAyMCBhdCA3OjA5IEFNIEx1Y2ssIFRvbnkgPHRvbnkubHVja0BpbnRl bC5jb20+IHdyb3RlOg0KPg0KPiA+IE5vdyBtYXliZSBjb3B5X3RvX3VzZXIoKSBzaG91bGQgKmFs d2F5cyogd29yayB0aGlzIHdheSwgYnV0IEnigJltIG5vdCBjb252aW5jZWQuDQo+ID4gQ2VydGFp bmx5IHB1dF91c2VyKCkgc2hvdWxkbuKAmXQg4oCUIHRoZSByZXN1bHQgd291bGRu4oCZdCBldmVu IGJlIHdlbGwgZGVmaW5lZC4gQW5kIEnigJltDQo+ID4gIHVuY29udmluY2VkIHRoYXQgaXQgbWFr ZXMgbXVjaCBzZW5zZSBmb3IgdGhlIG1ham9yaXR5IG9mIGNvcHlfdG9fdXNlcigpIGNhbGxlcnMN Cj4gPiAgdGhhdCBhcmUgYWxzbyBkaXJlY3RseSBhY2Nlc3NpbmcgdGhlIHNvdXJjZSBzdHJ1Y3R1 cmUuDQo+DQo+IE9uZSBjYXNlIHRoYXQgbWlnaHQgd29yayBpcyBjb3B5X3RvX3VzZXIoKSB0aGF0 J3MgY29weWluZyBmcm9tIHRoZSBrZXJuZWwgcGFnZSBjYWNoZQ0KPiB0byB0aGUgdXNlciBpbiBy ZXNwb25zZSB0byBhIHJlYWQoMikgc3lzdGVtIGNhbGwuICBBY3Rpb24gd291bGQgYmUgdG8gY2hl Y2sgaWYgd2UgY291bGQNCj4gcmUtcmVhZCBmcm9tIHRoZSBmaWxlIHN5c3RlbSB0byBhIGRpZmZl cmVudCBwYWdlLiBJZiBub3QsIHJldHVybiAtRUlPLiBFaXRoZXIgd2F5IGRpdGNoIHRoZQ0KPiBw b2lzb24gcGFnZSBmcm9tIHRoZSBwYWdlIGNhY2hlLg0KPg0KDQpJIHRoaW5rIHRoYXQsIGJlZm9y ZSB3ZSBkbyB0b28gbXVjaCBkZXNpZ24gb2YgdGhlIHNlbWFudGljcyBvZiBqdXN0DQp0aGUgY29w eSBmdW5jdGlvbiwgd2UgbmVlZCBhIGRlc2lnbiBmb3IgdGhlIHdob2xlIHN5c3RlbS4NClNwZWNp ZmljYWxseToNCg0KV2hlbiB0aGUga2VybmVsIGZpbmRzIG91dCB0aGF0IGEga2VybmVsIHBhZ2Ug aXMgYmFkICh2aWEgI01DIG9yIHZpYQ0KYW55IG90aGVyIG1lY2hhbmlzbSksIHdoYXQgZG9lcyB0 aGUga2VybmVsIGRvPyAgRG9lcyBpdCB1bm1hcCBpdD8NCkRvZXMgaXQgcmVwbGFjZSBpdCB3aXRo IGEgZHVtbXkgcGFnZT8gIERvZXMgaXQgbGVhdmUgaXQgdGhlcmU/DQoNCldoZW4gYSBjb3B5IGZ1 bmN0aW9uIGhpdHMgYSBiYWQgcGFnZSBhbmQgdGhlIHBhZ2UgaXMgbm90IHlldCBrbm93biB0bw0K YmUgYmFkLCB3aGF0IGRvZXMgaXQgZG8/ICAoSS5lLiB0aGUgcGFnZSB3YXMgYmVsaWV2ZWQgdG8g YmUgZmluZSBidXQNCnRoZSBjb3B5IGZ1bmN0aW9uIGdldHMgI01DLikgIERvZXMgaXQgdW5tYXAg aXQgcmlnaHQgYXdheT8gIFdoYXQgZG9lcw0KaXQgcmV0dXJuPw0KDQpXaGVuIGEgY29weSBmdW5j dGlvbiBoaXRzIGEgcGFnZSB0aGF0IGlzIGFscmVhZHkga25vd24gdG8gYmUgYmFkDQpiZWNhdXNl IHRoZSBrZXJuZWwgZ290IHRoZSAib2ggY3JhcCwgYmFkIHBhZ2UiIG5vdGlmaWNhdGlvbiBlYXJs aWVyLA0Kd2hhdCBkb2VzIGl0IGRvPyAgUmV0dXJuIC1FSU8/ICBUYWtlIHNvbWUgZmFuY2llciBh Y3Rpb24gdW5kZXIgdGhlDQphc3N1bXB0aW9uIHRoYXQgaXQncyBjYWxsZWQgaW4gYSBwcmVlbXB0 aWJsZSwgSVJRcy1vbiBjb250ZXh0LCB3aGVyZWFzDQp0aGUgb3JpZ2luYWwgI01DIG9yIG90aGVy IGhhcmR3YXJlIG5vdGlmaWNhdGlvbiBtYXkgaGF2ZSBjb21lIGF0IGENCmxlc3Mgb3Bwb3J0dW5l IHRpbWU/Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LW52ZGltbSBtYWlsaW5nIGxpc3QgLS0gbGludXgtbnZkaW1tQGxpc3RzLjAxLm9yZwpUbyB1 bnN1YnNjcmliZSBzZW5kIGFuIGVtYWlsIHRvIGxpbnV4LW52ZGltbS1sZWF2ZUBsaXN0cy4wMS5v cmcK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CCA0C3A5A9 for ; Sun, 3 May 2020 00:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 506B820721 for ; Sun, 3 May 2020 00:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=amacapital-net.20150623.gappssmtp.com header.i=@amacapital-net.20150623.gappssmtp.com header.b="E1AEkHox" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726576AbgECAaM (ORCPT ); Sat, 2 May 2020 20:30:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgECAaL (ORCPT ); Sat, 2 May 2020 20:30:11 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5911BC061A0E for ; Sat, 2 May 2020 17:30:11 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id z6so4597046wml.2 for ; Sat, 02 May 2020 17:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=V2nT+jmzW6uK6j6RNvaRunaFhSFW7qRx5cWISy3xtsQ=; b=E1AEkHox21046/Jzv0H2sg0BIzJvXI5WKdhrIfyzhtFbc0BBr2Jbbo4W/cz61zuCWi N7wfdgGQbbeddGO74JguUI2EXq4+V2iEf/49y27rGKNWMBfesVlzBgPOzVPeBAWsDjVi MwfyIgQ4sj5GybFYWk26pinWgUjQkfCWZ6xmmDA/YANZdJExvY+1eHRU0qsu08dgxRg4 yba0Fz8wK4DVM4JNI9vneWIr8MwO1iTNEI1j2c8OtrlAD2zgZyVuN0UPndhOvADA09K0 oGD9E7oaU2Xm77LaL1nDwVx5b0TQ2W5oTxfvUMvijPlQLM0HQwCdOkQFHHjX+VELIOiy 0BvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=V2nT+jmzW6uK6j6RNvaRunaFhSFW7qRx5cWISy3xtsQ=; b=Gz3di2LFF5mxL6a7sKgO1jXr9oa2Tuo287C5qowljtGOggGq4Tq4DdeITikUotr2cJ /9u0qQ76ClOOPtBb8jRO/8DgxLk3MAyppRDLU7e6FA3OCOcCzFkRnA2FFBVnB/VeZKZs pk2cwVsIfCz31nr88r231KiamGDnnDhOZultKxVKHYYHJ5Eqa4TbZ3Y808WVe4CyEPsn +vCwAzojz8W2wMd/XGKGlG13sehNql2cC8jf9zcOc6YKvTR1MicXfO8lcL8yQQa/kEIY 8Q2ySdlN9KuQw6ptc+YxMlSEDb3zhnnejFP01Yixk0Pig1cyUdo0rDV4u9KQxg6GFuBU V03Q== X-Gm-Message-State: AGi0PubX85NZuGHC1yD/ZX5SDpW6AULhnaFMRLeVZT/zqBvvv9pDSkg1 MhDomCtisXAE22scE6YctoX0YhzFUKa8AqHOoegYgA== X-Google-Smtp-Source: APiQypK033BSVa5j3+ZhThYcEUFkwS26U4I4SJPdSG0fksA6GljM8v6NbCEY+NCeISjVSggtF2WxUBXyAZEAOTUxbUM= X-Received: by 2002:a1c:4186:: with SMTP id o128mr6735406wma.21.1588465809902; Sat, 02 May 2020 17:30:09 -0700 (PDT) MIME-Version: 1.0 References: <1962EE67-8AD1-409D-963A-4F1E1AB3B865@amacapital.net> <3908561D78D1C84285E8C5FCA982C28F7F60EBB6@ORSMSX115.amr.corp.intel.com> In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F60EBB6@ORSMSX115.amr.corp.intel.com> From: Andy Lutomirski Date: Sat, 2 May 2020 17:29:57 -0700 Message-ID: Subject: Re: [PATCH v2 0/2] Replace and improve "mcsafe" with copy_safe() To: "Luck, Tony" Cc: Linus Torvalds , "Williams, Dan J" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Borislav Petkov , stable , "the arch/x86 maintainers" , "H. Peter Anvin" , Paul Mackerras , Benjamin Herrenschmidt , "Tsaur, Erwin" , Michael Ellerman , Arnaldo Carvalho de Melo , linux-nvdimm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 1, 2020 at 7:09 AM Luck, Tony wrote: > > > Now maybe copy_to_user() should *always* work this way, but I=E2=80=99m= not convinced. > > Certainly put_user() shouldn=E2=80=99t =E2=80=94 the result wouldn=E2= =80=99t even be well defined. And I=E2=80=99m > > unconvinced that it makes much sense for the majority of copy_to_user(= ) callers > > that are also directly accessing the source structure. > > One case that might work is copy_to_user() that's copying from the kernel= page cache > to the user in response to a read(2) system call. Action would be to che= ck if we could > re-read from the file system to a different page. If not, return -EIO. Ei= ther way ditch the > poison page from the page cache. > I think that, before we do too much design of the semantics of just the copy function, we need a design for the whole system. Specifically: When the kernel finds out that a kernel page is bad (via #MC or via any other mechanism), what does the kernel do? Does it unmap it? Does it replace it with a dummy page? Does it leave it there? When a copy function hits a bad page and the page is not yet known to be bad, what does it do? (I.e. the page was believed to be fine but the copy function gets #MC.) Does it unmap it right away? What does it return? When a copy function hits a page that is already known to be bad because the kernel got the "oh crap, bad page" notification earlier, what does it do? Return -EIO? Take some fancier action under the assumption that it's called in a preemptible, IRQs-on context, whereas the original #MC or other hardware notification may have come at a less opportune time?