All of
 help / color / mirror / Atom feed
From: Andy Lutomirski <>
To: Guenter Roeck <>
	Jean Delvare <>,
	James Ralston
	Andras BALI <>
Subject: Re: [PATCH v3 3/4] tsod: New hwmon driver for Temperature Sensors on DIMM
Date: Wed, 17 Jul 2013 15:49:24 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Jul 17, 2013 at 3:19 PM, Guenter Roeck <> wrote:
> On Wed, Jul 17, 2013 at 01:53:07PM -0700, Andy Lutomirski wrote:
>> Signed-off-by: Andy Lutomirski <>
>> ---
> Why don't you just use the existing jc42 driver ?

Failure to notice it.  *sigh*.  I assumed that any driver for this
device would have "tsod" or "TSOD" somewhere greppable.  I'll at least
send a patch to improve the description.

That being said, the jc42 driver *writes*.  The iMC controller
(AFAICS) uses the data from the TSOD for things like dynamically
adjusting the DRAM refresh interval and IMO the kernel has no business
at all writing to any registers on the TSOD on this platform.  (FWIW,
I tried fiddling with the critical threshold and my box didn't blow up
or report thermal trip events.  But still, this scares me a bit.)

If I modify the i2c_imc driver to add .class = I2C_CLASS_SPD and get
rid of the TSOD probing and load the jc42 module, then it can't
actually find my TSODs (because the i2c core isn't capable of probing
on the iMC bus).  If I manually add the device, it works.

But I'd like to keep the enumeration code I wrote around, since the
main point of this exercise is to enumerate things that aren't
actually hwmon devices.  But I don't want random sensors scripts
reprogramming the hardware.  Is the some magic I can work (or should
add) with i2c_board_info to force the jc42 driver into a read-only

In any case, am I doing the right thing by not setting I2C_CLASS_SPD on my bus?


  parent reply	other threads:[~2013-07-17 22:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 20:53 [PATCH v3 0/4] iMC SMBUS, TSOD hwmon devices, and eeprom modalias Andy Lutomirski
     [not found] ` <>
2013-07-17 20:53   ` [PATCH v3 1/4] i2c: Add DIMM bus code Andy Lutomirski
     [not found]     ` <>
2013-07-17 22:23       ` Guenter Roeck
     [not found]         ` <>
2013-07-17 23:04           ` Andy Lutomirski
     [not found]             ` <>
2013-07-18  0:57               ` Andy Lutomirski
2013-07-17 20:53   ` [PATCH v3 2/4] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips Andy Lutomirski
2013-07-17 20:53   ` [PATCH v3 3/4] tsod: New hwmon driver for Temperature Sensors on DIMM Andy Lutomirski
     [not found]     ` <>
2013-07-17 22:19       ` Guenter Roeck
     [not found]         ` <>
2013-07-17 22:49           ` Andy Lutomirski [this message]
     [not found]             ` <>
2013-07-17 23:09               ` Guenter Roeck
     [not found]                 ` <>
2013-07-17 23:13                   ` Andy Lutomirski
2013-07-17 20:53   ` [PATCH v3 4/4] eeprom: Add a MODULE_DEVICE_TABLE Andy Lutomirski
     [not found]     ` <>
2013-07-18  7:11       ` Jean Delvare
     [not found]         ` <>
2013-07-18 16:15           ` Andy Lutomirski
     [not found]             ` <>
2013-07-18 20:31               ` Jean Delvare
     [not found]                 ` <>
2013-07-18 20:44                   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.