From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525D8C04AA7 for ; Mon, 13 May 2019 16:01:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DCBF2147A for ; Mon, 13 May 2019 16:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557763295; bh=lEibKcwC5gVE6uqe1w9PcI6jNFCNtyn0TO/fffg8YH8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=DuG1BneiiAqZpZD4PK3aOnNLSZajOINO1QJgwCqP5Noz5uqKnaAj2OgcOpayHbdy/ xemH9frAQFIqTAKU4sdtlBiTX3+EhtF9pB7j17/U7eglFMyOjRHJ3KCN3EL1oYIh9Y 6b0IaUMQEJXaOPKHY5W3xQ+y0XeDNm+Bm5yij7Sw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730263AbfEMQBe (ORCPT ); Mon, 13 May 2019 12:01:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:43392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729726AbfEMQBd (ORCPT ); Mon, 13 May 2019 12:01:33 -0400 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80629216E3 for ; Mon, 13 May 2019 16:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557763292; bh=lEibKcwC5gVE6uqe1w9PcI6jNFCNtyn0TO/fffg8YH8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=k+z5lpybKEi6mIpFrCN17wQ9GoetmotYQ4i88fejJcVpMaoHOZbrljm2PEWhDSswf 06cEs3sA7iEdSg/w9f9tzMdQIooZs+IfZ3+LMzAYVslGXnDJ50vPScbKZ3yfmR0j61 V+5Fh+Qm2y15i11H0UpnUapfNJQgFELWxccdwEPU= Received: by mail-wm1-f48.google.com with SMTP id o189so14476556wmb.1 for ; Mon, 13 May 2019 09:01:32 -0700 (PDT) X-Gm-Message-State: APjAAAVabzk9T5/5m1nMh9gXwlgbCyBbK9FIJc0dYvikofp5kdGywWUq WUB/oLzavTLF277Y2VLZMwc6HKZiwmDubw3ZiNMPAQ== X-Google-Smtp-Source: APXvYqySeak5d5b75+WeyRRha6bI26hiE/9igsHZ0v7N1L8hvam3cM49nnezAxrIoHS1OAg32CScL++8+THXngeTOP8= X-Received: by 2002:a7b:c844:: with SMTP id c4mr5457540wml.108.1557763286508; Mon, 13 May 2019 09:01:26 -0700 (PDT) MIME-Version: 1.0 References: <1557758315-12667-1-git-send-email-alexandre.chartre@oracle.com> <1557758315-12667-26-git-send-email-alexandre.chartre@oracle.com> In-Reply-To: <1557758315-12667-26-git-send-email-alexandre.chartre@oracle.com> From: Andy Lutomirski Date: Mon, 13 May 2019 09:01:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC KVM 25/27] kvm/isolation: implement actual KVM isolation enter/exit To: Alexandre Chartre Cc: Paolo Bonzini , Radim Krcmar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Dave Hansen , Andrew Lutomirski , Peter Zijlstra , kvm list , X86 ML , Linux-MM , LKML , Konrad Rzeszutek Wilk , jan.setjeeilers@oracle.com, Liran Alon , Jonathan Adams Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 13, 2019 at 7:40 AM Alexandre Chartre wrote: > > From: Liran Alon > > KVM isolation enter/exit is done by switching between the KVM address > space and the kernel address space. > > Signed-off-by: Liran Alon > Signed-off-by: Alexandre Chartre > --- > arch/x86/kvm/isolation.c | 30 ++++++++++++++++++++++++------ > arch/x86/mm/tlb.c | 1 + > include/linux/sched.h | 1 + > 3 files changed, 26 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kvm/isolation.c b/arch/x86/kvm/isolation.c > index db0a7ce..b0c789f 100644 > --- a/arch/x86/kvm/isolation.c > +++ b/arch/x86/kvm/isolation.c > @@ -1383,11 +1383,13 @@ static bool kvm_page_fault(struct pt_regs *regs, unsigned long error_code, > printk(KERN_DEFAULT "KVM isolation: page fault %ld at %pS on %lx (%pS) while switching mm\n" > " cr3=%lx\n" > " kvm_mm=%px pgd=%px\n" > - " active_mm=%px pgd=%px\n", > + " active_mm=%px pgd=%px\n" > + " kvm_prev_mm=%px pgd=%px\n", > error_code, (void *)regs->ip, address, (void *)address, > cr3, > &kvm_mm, kvm_mm.pgd, > - active_mm, active_mm->pgd); > + active_mm, active_mm->pgd, > + current->kvm_prev_mm, current->kvm_prev_mm->pgd); > dump_stack(); > > return false; > @@ -1649,11 +1651,27 @@ void kvm_may_access_sensitive_data(struct kvm_vcpu *vcpu) > kvm_isolation_exit(); > } > > +static void kvm_switch_mm(struct mm_struct *mm) > +{ > + unsigned long flags; > + > + /* > + * Disable interrupt before updating active_mm, otherwise if an > + * interrupt occurs during the switch then the interrupt handler > + * can be mislead about the mm effectively in use. > + */ > + local_irq_save(flags); > + current->kvm_prev_mm = current->active_mm; Peter's NAK aside, why on Earth is this in task_struct? You cannot possibly context switch while in isolation mode. --Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9794DC04AAA for ; Mon, 13 May 2019 16:01:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 46E892147A for ; Mon, 13 May 2019 16:01:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YBdQmFv+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46E892147A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 093406B0280; Mon, 13 May 2019 12:01:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 043F46B0282; Mon, 13 May 2019 12:01:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E755E6B0284; Mon, 13 May 2019 12:01:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id B19036B0280 for ; Mon, 13 May 2019 12:01:31 -0400 (EDT) Received: by mail-pg1-f199.google.com with SMTP id 63so9415792pga.18 for ; Mon, 13 May 2019 09:01:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:mime-version:references :in-reply-to:from:date:message-id:subject:to:cc; bh=Ljy/U+bZu7KOD/jm5h/Nov5oW0yZ5jBLjvuaOwjQBsk=; b=hFHzPOwgCupdldAR7+X1mmEkPMB/EzxDTRHscri++qZb91RbVSqR1hU4bY3KiU/33X EAn2wMpBpI5k6VwShhEw+bQijFbiyqN3ONIZ1hqb1+SaoN+/p3EwEtODWe/nTZktH0xa +H6xnWKoZzxJpaP+0eb2j31gBZJRBVm1Q6iiWMtydfE+z4FqrurGwa8PLkuGqxPPSl+2 U1+JGIItmPCjHKKCbyg8/v1xvMAbyeSBh74OaIOS24b+3p9mshjbafdwbZL5L6aa98N/ NnM+MvXlQWzjW2ng0ed3/C0vzqXxDknpODl10ptn0HDFR+SCeryIRA1j2eRqqq7f4V1p nOkw== X-Gm-Message-State: APjAAAUizvdddw5slXIO9AhIvs1wMBlBPJfAZ/sj3O+4C+H6kx4lhxSM SfMgqEnT5S3EPPWwGMKba+9PXP5rAa/D1D71WJ8Gep5UxDHM3kb37SBwlkjywkjXqgYdUVgEAOu w3S2pPNjp9dTDK50uYhGHreBj4LIfX5YOz41opliIkGm1YQ0xjYXkbljmyFr5CO1+hw== X-Received: by 2002:a17:902:b614:: with SMTP id b20mr30369905pls.200.1557763291392; Mon, 13 May 2019 09:01:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQYp7hA4AI5l+PAXXs/Fjyk6t6XI96LdGfy/zTJtOMLYzXlWOUIgBb6xnVh/d6aF1G8R1q X-Received: by 2002:a17:902:b614:: with SMTP id b20mr30369820pls.200.1557763290718; Mon, 13 May 2019 09:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557763290; cv=none; d=google.com; s=arc-20160816; b=ctUOJUjGXnh8VnsGmxST5rVzA5mkbYjzpb63VWfd8myvmouwFAVOrDZXSgfyOVgtk4 yaof4qw90ah9N48cMTd7XaUkBB/Iry5ytnv+eUMTSR/udedWm3At9w4dNnQxVfa0jhr2 n90U+VwL/6pFniCBurEnzU9LFMbdiTXjsJYJttH+XWZvET8WvOXitKGwpu5HrO/HFKmA GpAsNdi5uEEGZEJ3ljTaX+ryByHnOgS36hmSE2t6rxkH1FbdBUUM5dbp7l8M/1nJ49mW bv0nZo7P62HLHH6y9cFrpvyHUX3i3GG8EDj0CK20oD7iVwQVo2/YMSTkqLpIhYDdLeKJ XqZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=Ljy/U+bZu7KOD/jm5h/Nov5oW0yZ5jBLjvuaOwjQBsk=; b=KTNicf/GeZL5VBBJ9eYHt34Qgq0hK4dT+iIXSZDup4FXuebwwdQSccy+fnL+ZvS3z6 +kVTtM9WkvJ80y5MPpdKKDD9zn3ZXvhcADgfOEzYBTLuRBkRAfI/hM/GVdUNL7/Fpgp6 rbM8UauKUjIR7mTGCLvDpOdeyoc29Oqd0ZPbisBnhQbUj6v674LBC7pGmOWvbZSmJHwZ cnvKfVC8JM7GLllp+jnB6k2TZ4OOkYklSNeJMtmBgMV2OeNlUh3XvePUHAXTWvQP5b2U tV6PkzDaLkoHs6v6OUe1G5YQoSUanxS0e8gsb5IiGi0OGEqwn8M1Nwr4XGhrfXZDFgMh GBwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YBdQmFv+; spf=pass (google.com: domain of luto@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=luto@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by mx.google.com with ESMTPS id v40si16502367plg.409.2019.05.13.09.01.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 May 2019 09:01:30 -0700 (PDT) Received-SPF: pass (google.com: domain of luto@kernel.org designates 198.145.29.99 as permitted sender) client-ip=198.145.29.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YBdQmFv+; spf=pass (google.com: domain of luto@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=luto@kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2370E21655 for ; Mon, 13 May 2019 16:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557763290; bh=lEibKcwC5gVE6uqe1w9PcI6jNFCNtyn0TO/fffg8YH8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YBdQmFv+6f0ehcqPTdycmmzLGxIGw7o9OdfJad+Pew98TJbknjnEOFU5Ia677bZeP 7yQRnNXKQ7beIL8WyMqISTgRWj+CyN9f5Tkextzwte6J/imWrq8bxznyj77y8IXwbR 0OGW+acgJQTjsK+TkAhuAsfAx54+ZMBW+kf/71MQ= Received: by mail-wm1-f50.google.com with SMTP id f2so14279677wmj.3 for ; Mon, 13 May 2019 09:01:30 -0700 (PDT) X-Received: by 2002:a7b:c844:: with SMTP id c4mr5457540wml.108.1557763286508; Mon, 13 May 2019 09:01:26 -0700 (PDT) MIME-Version: 1.0 References: <1557758315-12667-1-git-send-email-alexandre.chartre@oracle.com> <1557758315-12667-26-git-send-email-alexandre.chartre@oracle.com> In-Reply-To: <1557758315-12667-26-git-send-email-alexandre.chartre@oracle.com> From: Andy Lutomirski Date: Mon, 13 May 2019 09:01:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC KVM 25/27] kvm/isolation: implement actual KVM isolation enter/exit To: Alexandre Chartre Cc: Paolo Bonzini , Radim Krcmar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Dave Hansen , Andrew Lutomirski , Peter Zijlstra , kvm list , X86 ML , Linux-MM , LKML , Konrad Rzeszutek Wilk , jan.setjeeilers@oracle.com, Liran Alon , Jonathan Adams Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 13, 2019 at 7:40 AM Alexandre Chartre wrote: > > From: Liran Alon > > KVM isolation enter/exit is done by switching between the KVM address > space and the kernel address space. > > Signed-off-by: Liran Alon > Signed-off-by: Alexandre Chartre > --- > arch/x86/kvm/isolation.c | 30 ++++++++++++++++++++++++------ > arch/x86/mm/tlb.c | 1 + > include/linux/sched.h | 1 + > 3 files changed, 26 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kvm/isolation.c b/arch/x86/kvm/isolation.c > index db0a7ce..b0c789f 100644 > --- a/arch/x86/kvm/isolation.c > +++ b/arch/x86/kvm/isolation.c > @@ -1383,11 +1383,13 @@ static bool kvm_page_fault(struct pt_regs *regs, unsigned long error_code, > printk(KERN_DEFAULT "KVM isolation: page fault %ld at %pS on %lx (%pS) while switching mm\n" > " cr3=%lx\n" > " kvm_mm=%px pgd=%px\n" > - " active_mm=%px pgd=%px\n", > + " active_mm=%px pgd=%px\n" > + " kvm_prev_mm=%px pgd=%px\n", > error_code, (void *)regs->ip, address, (void *)address, > cr3, > &kvm_mm, kvm_mm.pgd, > - active_mm, active_mm->pgd); > + active_mm, active_mm->pgd, > + current->kvm_prev_mm, current->kvm_prev_mm->pgd); > dump_stack(); > > return false; > @@ -1649,11 +1651,27 @@ void kvm_may_access_sensitive_data(struct kvm_vcpu *vcpu) > kvm_isolation_exit(); > } > > +static void kvm_switch_mm(struct mm_struct *mm) > +{ > + unsigned long flags; > + > + /* > + * Disable interrupt before updating active_mm, otherwise if an > + * interrupt occurs during the switch then the interrupt handler > + * can be mislead about the mm effectively in use. > + */ > + local_irq_save(flags); > + current->kvm_prev_mm = current->active_mm; Peter's NAK aside, why on Earth is this in task_struct? You cannot possibly context switch while in isolation mode. --Andy