From: Andy Lutomirski <luto@amacapital.net>
To: Aristeu Rozanski <aris@redhat.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Doug Thompson <dougthompson@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Borislav Petkov <bp@alien8.de>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-edac@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Rui Wang <ruiv.wang@gmail.com>
Subject: Re: [PATCH 2/2] sb_edac: Claim a different PCI device
Date: Mon, 8 Sep 2014 14:49:59 -0700 [thread overview]
Message-ID: <CALCETrX3KO=1T1m4Qwn+j7vqqhEuNb8Xdkf_c2Ne4P9AbpwOoA@mail.gmail.com> (raw)
In-Reply-To: <20140908141035.GK22290@redhat.com>
On Mon, Sep 8, 2014 at 7:10 AM, Aristeu Rozanski <aris@redhat.com> wrote:
> On Thu, Aug 14, 2014 at 02:45:41PM -0700, Andy Lutomirski wrote:
>> sb_edac controls a large number of different PCI functions. Rather
>> than registering as a normal PCI driver for all of them, it
>> registers for just one so that it gets probed and, at probe time, it
>> looks for all the others.
>>
>> Coincidentally, the device it registers for also contains the SMBUS
>> registers, so the PCI core will refuse to probe both sb_edac and a
>> future iMC SMBUS driver. The drivers don't actually conflict, so
>> just change sb_edac's device table to probe a different device.
>>
>> An alternative fix would be to merge the two drivers, but sb_edac
>> will also refuse to load on non-ECC systems, whereas i2c_imc would
>> still be useful without ECC.
>>
>> The only user-visible change should be that sb_edac appears to bind
>> a different device.
>>
>> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
>> Cc: Rui Wang <ruiv.wang@gmail.com>
>> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
>> ---
>> drivers/edac/sb_edac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
>> index a2597e9313c6..e3bc2cced580 100644
>> --- a/drivers/edac/sb_edac.c
>> +++ b/drivers/edac/sb_edac.c
>> @@ -432,7 +432,7 @@ static const struct pci_id_table pci_dev_descr_ibridge_table[] = {
>> * pci_device_id table for which devices we are looking for
>> */
>> static const struct pci_device_id sbridge_pci_tbl[] = {
>> - {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_TA)},
>> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_HA0)},
>> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IBRIDGE_IMC_HA0_TA)},
>> {0,} /* 0 terminated list. */
>> };
>
> Acked-by: Aristeu Rozanski <aris@redhat.com>
>
Whose tree will this go through?
FWIW, this git am can't apply this to 3.17-rc4, but git am --3way can,
and it's a one-liner in any case. Should I send a trivially rebased
version?
--Andy
> --
> Aristeu
>
--
Andy Lutomirski
AMA Capital Management, LLC
next prev parent reply other threads:[~2014-09-08 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 21:45 [PATCH 0/2] sb_edac: i2c_imc staging submission prep Andy Lutomirski
2014-08-14 21:45 ` [PATCH 1/2] Move Intel SNB device ids from sb_edac to pci_ids.h Andy Lutomirski
2014-09-05 23:41 ` Bjorn Helgaas
2014-09-05 23:42 ` Andy Lutomirski
2014-09-08 14:08 ` Aristeu Rozanski
2014-08-14 21:45 ` [PATCH 2/2] sb_edac: Claim a different PCI device Andy Lutomirski
2014-09-08 14:10 ` Aristeu Rozanski
2014-09-08 21:49 ` Andy Lutomirski [this message]
2014-09-08 23:41 ` Greg Kroah-Hartman
2014-09-09 9:25 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrX3KO=1T1m4Qwn+j7vqqhEuNb8Xdkf_c2Ne4P9AbpwOoA@mail.gmail.com' \
--to=luto@amacapital.net \
--cc=aris@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=ruiv.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.