From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754656AbbERT2v (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 May 2015 15:28:51 -0400
Received: from mail-la0-f43.google.com ([209.85.215.43]:34416 "EHLO
	mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754145AbbERT2s (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 May 2015 15:28:48 -0400
MIME-Version: 1.0
In-Reply-To: <CAPcyv4iBu5xawFcLcjSKW-hDSyvCkPAUonMuaMFS0g5e4rWsmQ@mail.gmail.com>
References: <20150428181203.35812.60474.stgit@dwillia2-desk3.amr.corp.intel.com>
 <20150428182417.35812.92834.stgit@dwillia2-desk3.amr.corp.intel.com>
 <x49iobtyhfv.fsf@segfault.boston.devel.redhat.com> <CAPcyv4iBu5xawFcLcjSKW-hDSyvCkPAUonMuaMFS0g5e4rWsmQ@mail.gmail.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Mon, 18 May 2015 12:28:26 -0700
Message-ID: <CALCETrXGqJJh8K58bNNy8GxST0g_655YRVqsaAXN8bqMjzdN7g@mail.gmail.com>
Subject: Re: [Linux-nvdimm] [PATCH v2 01/20] e820, efi: add ACPI 6.0
 persistent memory types
To: Dan Williams <dan.j.williams@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Jens Axboe <axboe@fb.com>,
        linux-nvdimm <linux-nvdimm@ml01.01.org>,
        Jeff Moyer <jmoyer@redhat.com>, Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On May 16, 2015 12:48 AM, "Dan Williams" <dan.j.williams@intel.com> wrote:
>
> On Fri, May 15, 2015 at 8:43 AM, Jeff Moyer <jmoyer@redhat.com> wrote:
> > Dan Williams <dan.j.williams@intel.com> writes:
> >
> >> @@ -919,10 +920,31 @@ static inline const char *e820_type_to_string(int e820_type)
> >>       case E820_NVS:  return "ACPI Non-volatile Storage";
> >>       case E820_UNUSABLE:     return "Unusable memory";
> >>       case E820_PRAM: return "Persistent RAM";
> >> +     case E820_PMEM: return "Persistent I/O Memory";
> >
> > Minor nit, but nobody refers to this stuff as persistent I/O memory.
> > I've heard it referred to as persistent memory or storage class memory.
> > In the end, I doubt it matters.
>
> Had we not polluted the waters with E820_PRAM I would have chosen
> "Persistent Memory", but as we now need to support both I'd assume
> they need different names.

We could reverse it and call E820_PRAM "legacy persistent RAM" or
something similar.

</bikeshed>

>
> > Acked-by: Jeff Moyer <jmoyer@redhat.com>
>
> Thanks Jeff.