From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbbLDQEb (ORCPT ); Fri, 4 Dec 2015 11:04:31 -0500 Received: from mail-io0-f179.google.com ([209.85.223.179]:33381 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753437AbbLDQE3 convert rfc822-to-8bit (ORCPT ); Fri, 4 Dec 2015 11:04:29 -0500 MIME-Version: 1.0 In-Reply-To: <20151204125521.GA13406@eudyptula.hq.kempniu.pl> References: <20151130211542.GE30553@malice.jf.intel.com> <1654e7bcde98f1cf89f698a1e359110c06c6fcd4.1448999372.git.kernel@kempniu.pl> <20151204011606.GI1800@malice.jf.intel.com> <20151204125521.GA13406@eudyptula.hq.kempniu.pl> From: Andy Lutomirski Date: Fri, 4 Dec 2015 08:04:09 -0800 Message-ID: Subject: Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Darren Hart , Matthew Garrett , =?UTF-8?Q?Pali_Roh=C3=A1r?= , platform-driver-x86@vger.kernel.org, "linux-kernel@vger.kernel.org" , Andy Lutomirski Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 4, 2015 at 4:55 AM, Michał Kępień wrote: >> > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant >> > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025 >> > is generated. As there seems to be no ACPI method or SMI call to >> > determine without possible side effects whether a given machine is >> > capable of simulating a keypress when this hotkey is pressed, DMI >> > matching is used to whitelist the models for which an input event should >> > be generated when WMI event 0xe025 is received. >> > >> > Signed-off-by: Michał Kępień >> > --- >> > Changes from v1: >> > >> > - Use DMI matching instead of a module parameter >> > - Change flag name to improve readability >> > >> > Darren, I am aware this patch conflicts with Andy's WMI rework series >> > posted yesterday, so please just let me know if you want me to rebase. >> >> Thanks for the heads' up. Andy's series is longer and likely going to need more >> review from more people, so I don't necessarily want to hold this one up on it - >> unless it makes sense to include it in that series so they can evolve together. >> I'll leave that to you and Andy to decide. > > As merging my patch with Andy's work is just a matter of moving code > around, not actually changing it, personally I don't feel this patch > should be somehow linked to the WMI rework. Andy, please let me know if > you disagree, I don't really have any strong feelings about this. >' I think it's just a matter of which lands first. It shouldn't be a big deal. --Andy