From: Andy Lutomirski <luto@kernel.org> To: Christoph Hellwig <hch@lst.de> Cc: Andy Lutomirski <luto@kernel.org>, Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>, Keith Busch <keith.busch@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Kai-Heng Feng <kai.heng.feng@canonical.com>, linux-nvme <linux-nvme@lists.infradead.org> Subject: Re: [PATCH 1/2] nvme: Wait at least 6000ms before entering the deepest idle state Date: Sat, 27 May 2017 09:08:23 -0700 [thread overview] Message-ID: <CALCETrXc3da8q-7ZYrh3v+fk1CbeTXqOdoPTfDbb4h=G+R+Tdg@mail.gmail.com> (raw) In-Reply-To: <20170526085225.GA28728@lst.de> On Fri, May 26, 2017 at 1:52 AM, Christoph Hellwig <hch@lst.de> wrote: > On Wed, May 24, 2017 at 03:06:30PM -0700, Andy Lutomirski wrote: >> This should at least make vendors less nervous about Linux's APST >> policy. I'm not aware of any concrete bugs it would fix (although I >> was hoping it would fix the Samsung/Dell quirk). >> >> Cc: stable@vger.kernel.org # v4.11 > > Just following a somewhat odd and arbitray policy from another driver > that doesn't fix anything by itself certainly isn't stable material. Fair enough. The Cc: stable should certainly be dropped. > > And to be honest I'm not sure what applying it will gain us at all. I'd be fine with skipping this patch entirely at least until we find some evidence that it solves a problem instead.
WARNING: multiple messages have this Message-ID (diff)
From: luto@kernel.org (Andy Lutomirski) Subject: [PATCH 1/2] nvme: Wait at least 6000ms before entering the deepest idle state Date: Sat, 27 May 2017 09:08:23 -0700 [thread overview] Message-ID: <CALCETrXc3da8q-7ZYrh3v+fk1CbeTXqOdoPTfDbb4h=G+R+Tdg@mail.gmail.com> (raw) In-Reply-To: <20170526085225.GA28728@lst.de> On Fri, May 26, 2017@1:52 AM, Christoph Hellwig <hch@lst.de> wrote: > On Wed, May 24, 2017@03:06:30PM -0700, Andy Lutomirski wrote: >> This should at least make vendors less nervous about Linux's APST >> policy. I'm not aware of any concrete bugs it would fix (although I >> was hoping it would fix the Samsung/Dell quirk). >> >> Cc: stable at vger.kernel.org # v4.11 > > Just following a somewhat odd and arbitray policy from another driver > that doesn't fix anything by itself certainly isn't stable material. Fair enough. The Cc: stable should certainly be dropped. > > And to be honest I'm not sure what applying it will gain us at all. I'd be fine with skipping this patch entirely at least until we find some evidence that it solves a problem instead.
next prev parent reply other threads:[~2017-05-27 16:08 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-24 22:06 [PATCH 0/2] nvme APST fixes Andy Lutomirski 2017-05-24 22:06 ` Andy Lutomirski 2017-05-24 22:06 ` [PATCH 1/2] nvme: Wait at least 6000ms before entering the deepest idle state Andy Lutomirski 2017-05-24 22:06 ` Andy Lutomirski 2017-05-26 8:52 ` Christoph Hellwig 2017-05-26 8:52 ` Christoph Hellwig 2017-05-27 16:08 ` Andy Lutomirski [this message] 2017-05-27 16:08 ` Andy Lutomirski 2017-05-27 16:14 ` Linus Torvalds 2017-05-27 16:14 ` Linus Torvalds 2017-05-24 22:06 ` [PATCH 2/2] nvme: Quirk APST on Intel 600P/P3100 devices Andy Lutomirski 2017-05-24 22:06 ` Andy Lutomirski 2017-05-26 8:52 ` Christoph Hellwig 2017-05-26 8:52 ` Christoph Hellwig 2017-05-30 15:35 ` Keith Busch 2017-05-30 15:35 ` Keith Busch 2017-05-31 13:54 ` Andy Lutomirski 2017-05-31 13:54 ` Andy Lutomirski 2017-06-02 7:23 ` Nicholas Sielicki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALCETrXc3da8q-7ZYrh3v+fk1CbeTXqOdoPTfDbb4h=G+R+Tdg@mail.gmail.com' \ --to=luto@kernel.org \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=kai.heng.feng@canonical.com \ --cc=keith.busch@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.