From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752732AbdE0QIr (ORCPT ); Sat, 27 May 2017 12:08:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:41294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbdE0QIp (ORCPT ); Sat, 27 May 2017 12:08:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A55A239ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org MIME-Version: 1.0 In-Reply-To: <20170526085225.GA28728@lst.de> References: <6760ae9459ba19657f8009a9231b97a71114a1e5.1495663545.git.luto@kernel.org> <20170526085225.GA28728@lst.de> From: Andy Lutomirski Date: Sat, 27 May 2017 09:08:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] nvme: Wait at least 6000ms before entering the deepest idle state To: Christoph Hellwig Cc: Andy Lutomirski , Jens Axboe , Sagi Grimberg , Keith Busch , "linux-kernel@vger.kernel.org" , Kai-Heng Feng , linux-nvme Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2017 at 1:52 AM, Christoph Hellwig wrote: > On Wed, May 24, 2017 at 03:06:30PM -0700, Andy Lutomirski wrote: >> This should at least make vendors less nervous about Linux's APST >> policy. I'm not aware of any concrete bugs it would fix (although I >> was hoping it would fix the Samsung/Dell quirk). >> >> Cc: stable@vger.kernel.org # v4.11 > > Just following a somewhat odd and arbitray policy from another driver > that doesn't fix anything by itself certainly isn't stable material. Fair enough. The Cc: stable should certainly be dropped. > > And to be honest I'm not sure what applying it will gain us at all. I'd be fine with skipping this patch entirely at least until we find some evidence that it solves a problem instead. From mboxrd@z Thu Jan 1 00:00:00 1970 From: luto@kernel.org (Andy Lutomirski) Date: Sat, 27 May 2017 09:08:23 -0700 Subject: [PATCH 1/2] nvme: Wait at least 6000ms before entering the deepest idle state In-Reply-To: <20170526085225.GA28728@lst.de> References: <6760ae9459ba19657f8009a9231b97a71114a1e5.1495663545.git.luto@kernel.org> <20170526085225.GA28728@lst.de> Message-ID: On Fri, May 26, 2017@1:52 AM, Christoph Hellwig wrote: > On Wed, May 24, 2017@03:06:30PM -0700, Andy Lutomirski wrote: >> This should at least make vendors less nervous about Linux's APST >> policy. I'm not aware of any concrete bugs it would fix (although I >> was hoping it would fix the Samsung/Dell quirk). >> >> Cc: stable at vger.kernel.org # v4.11 > > Just following a somewhat odd and arbitray policy from another driver > that doesn't fix anything by itself certainly isn't stable material. Fair enough. The Cc: stable should certainly be dropped. > > And to be honest I'm not sure what applying it will gain us at all. I'd be fine with skipping this patch entirely at least until we find some evidence that it solves a problem instead.