From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH review 02/13] mnt: Refactor fs_fully_visible into mount_too_revealing Date: Mon, 20 Jun 2016 15:53:58 -0700 Message-ID: References: <87fus77pns.fsf@x220.int.ebiederm.org> <20160620172130.15712-1-ebiederm@xmission.com> <20160620172130.15712-2-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160620172130.15712-2-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Miklos Szeredi , Linux Containers , James Bottomley , Seth Forshee , Linux FS Devel , Djalal Harouni List-Id: containers.vger.kernel.org On Mon, Jun 20, 2016 at 10:21 AM, Eric W. Biederman wrote: > Replace the call of fs_fully_visible in do_new_mount from before the > new superblock is allocated with a call of mount_too_revealing after > the superblock is allocated. This winds up being a much better location > for maintainability of the code. > > The first change this enables is the replacement of FS_USERNS_VISIBLE > with SB_I_USERNS_VISIBLE. Moving the flag from struct filesystem_type > to sb_iflags on the superblock. Why is this useful? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f50.google.com ([209.85.213.50]:34919 "EHLO mail-vk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392AbcFTWyV (ORCPT ); Mon, 20 Jun 2016 18:54:21 -0400 Received: by mail-vk0-f50.google.com with SMTP id j2so214721193vkg.2 for ; Mon, 20 Jun 2016 15:54:19 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160620172130.15712-2-ebiederm@xmission.com> References: <87fus77pns.fsf@x220.int.ebiederm.org> <20160620172130.15712-1-ebiederm@xmission.com> <20160620172130.15712-2-ebiederm@xmission.com> From: Andy Lutomirski Date: Mon, 20 Jun 2016 15:53:58 -0700 Message-ID: Subject: Re: [PATCH review 02/13] mnt: Refactor fs_fully_visible into mount_too_revealing To: "Eric W. Biederman" Cc: Linux Containers , Linux FS Devel , Miklos Szeredi , James Bottomley , Djalal Harouni , Seth Forshee , "Serge E. Hallyn" Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 20, 2016 at 10:21 AM, Eric W. Biederman wrote: > Replace the call of fs_fully_visible in do_new_mount from before the > new superblock is allocated with a call of mount_too_revealing after > the superblock is allocated. This winds up being a much better location > for maintainability of the code. > > The first change this enables is the replacement of FS_USERNS_VISIBLE > with SB_I_USERNS_VISIBLE. Moving the flag from struct filesystem_type > to sb_iflags on the superblock. Why is this useful?