From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032223AbeBOASJ (ORCPT ); Wed, 14 Feb 2018 19:18:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:43294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032127AbeBOASI (ORCPT ); Wed, 14 Feb 2018 19:18:08 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7458C217C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org X-Google-Smtp-Source: AH8x225/S+W/Uv3WJpDPnp7uRGlS+5GSxdvPhQHmWaBvb8bhlHK9OHN2o3en5sqrPXl451HTC1TiSdc2rBpxV0rEANI= MIME-Version: 1.0 In-Reply-To: <20180214182113.27247-3-linux@dominikbrodowski.net> References: <20180214182113.27247-1-linux@dominikbrodowski.net> <20180214182113.27247-3-linux@dominikbrodowski.net> From: Andy Lutomirski Date: Thu, 15 Feb 2018 00:17:46 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 2/4] x86/entry/64: move ENTER_IRQ_STACK from interrupt macro to helper function To: Dominik Brodowski Cc: LKML , Ingo Molnar , X86 ML , Linus Torvalds , Andrew Lutomirski , Andi Kleen , Thomas Gleixner , Dan Williams Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2018 at 6:21 PM, Dominik Brodowski wrote: > Moving the switch to IRQ stack from the interrupt macro to the helper > function requires some trickery: All ENTER_IRQ_STACK really cares about > is where the "original" stack -- meaning the GP registers etc. -- is > stored. Therefore, we need to offset the stored RSP value by 8 whenever > ENTER_IRQ_STACK is called from within a function. In such cases, and > after switching to the IRQ stack, we need to push the "original" return > address (i.e. the return address from the call to the interrupt entry > function) to the IRQ stack. > > This trickery allows us to carve another 1k from the text size: > > text data bss dec hex filename > 17905 0 0 17905 45f1 entry_64.o-orig > 16897 0 0 16897 4201 entry_64.o > > Signed-off-by: Dominik Brodowski > --- > arch/x86/entry/entry_64.S | 53 +++++++++++++++++++++++++++++++---------------- > 1 file changed, 35 insertions(+), 18 deletions(-) > > diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S > index de8a0da0d347..3046b12a1acb 100644 > --- a/arch/x86/entry/entry_64.S > +++ b/arch/x86/entry/entry_64.S > @@ -449,10 +449,18 @@ END(irq_entries_start) > * > * The invariant is that, if irq_count != -1, then the IRQ stack is in use. > */ > -.macro ENTER_IRQ_STACK regs=1 old_rsp > +.macro ENTER_IRQ_STACK regs=1 old_rsp save_ret=0 > DEBUG_ENTRY_ASSERT_IRQS_OFF > movq %rsp, \old_rsp > > + .if \save_ret > + /* > + * If save_ret is set, the original stack contains one additional > + * entry -- the return address. > + */ > + addq $8, \old_rsp > + .endif > + This is a bit alarming in that you now have live data below RSP. For x86_32, this would be a big no-no due to NMI. For x86_64, it might still be bad if there are code paths where NMI is switched to non-IST temporarily, which was the case at some point and might still be the case. (I think it is.) Remember that the x86_64 *kernel* ABI has no red zone. It also means that, if you manage to hit vmalloc_fault() in here when you touch the IRQ stack, you're dead. IOW you hit: movq \old_rsp, PER_CPU_VAR(irq_stack_union + IRQ_STACK_SIZE - 8) which gets #PF and eats your return pointer. Debugging this will be quite nasty because you'll only hit it on really huge systems after a thread gets migrated, and even then only if you get unlucky on your stack alignment. So can you find another way to do this? --Andy