From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756021AbcE0Pkp (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 May 2016 11:40:45 -0400
Received: from mail-oi0-f48.google.com ([209.85.218.48]:35663 "EHLO
	mail-oi0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753953AbcE0Pkn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 May 2016 11:40:43 -0400
MIME-Version: 1.0
In-Reply-To: <1464329832-4638-2-git-send-email-mnghuan@gmail.com>
References: <1464329832-4638-1-git-send-email-mnghuan@gmail.com> <1464329832-4638-2-git-send-email-mnghuan@gmail.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Fri, 27 May 2016 08:40:23 -0700
Message-ID: <CALCETrXzeinwmfgJN3i8X6_6wiqxcL_RcadPJBHcPvKqWJh+8g@mail.gmail.com>
Subject: Re: [PATCH 2/3] pvclock: Cleanup to remove function pvclock_get_nsec_offset
To: Minfei Huang <mnghuan@gmail.com>
Cc: Borislav Petkov <bp@suse.de>, Paolo Bonzini <pbonzini@redhat.com>,
        Andrew Lutomirski <luto@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@gmail.com> wrote:
> Function __pvclock_read_cycles is short enough, so there is no need to
> have another function pvclock_get_nsec_offset to calculate tsc delta.
> It's better to combine it into function __pvclock_read_cycles.
>
> Remove useless variables in function __pvclock_read_cycles.

LGTM.