From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails Date: Thu, 19 Nov 2015 14:00:21 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Andy Lutomirski Cc: Matthew Garrett , Bjorn Helgaas , "linux-pci@vger.kernel.org" , Yijing Wang , Linux ACPI List-Id: linux-acpi@vger.kernel.org Forwarding to linux-acpi. On Thu, Nov 19, 2015 at 8:08 AM, Andy Lutomirski wrote: > When _OSC fails and especially when it fails due to an invalid UUID, > it's helpful to show the UUID that we tried. > > Signed-off-by: Andy Lutomirski > --- > drivers/acpi/bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index 2177ef0b16e4..be2b164f8f2d 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -180,9 +180,9 @@ static void acpi_print_osc_error(acpi_handle handle, > int i; > > if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer))) > - printk(KERN_DEBUG "%s\n", error); > + printk(KERN_DEBUG "%s: %s\n", context->uuid_str, error); > else { > - printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error); > + printk(KERN_DEBUG "%s (%s): %s\n", (char *)buffer.pointer, context->uuid_str, error); > kfree(buffer.pointer); > } > printk(KERN_DEBUG "_OSC request data:"); > -- > 2.5.0 > -- Andy Lutomirski AMA Capital Management, LLC