From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756782AbaIINWH (ORCPT ); Tue, 9 Sep 2014 09:22:07 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:41734 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753619AbaIINWF (ORCPT ); Tue, 9 Sep 2014 09:22:05 -0400 MIME-Version: 1.0 In-Reply-To: <20140908204830.GA19307@kroah.com> References: <20140904171548.GA3265@ada> <20140908204830.GA19307@kroah.com> Date: Tue, 9 Sep 2014 16:22:03 +0300 Message-ID: Subject: Re: [PATCH] rtl8188eu: rtw_xmit: Replace rcu_dereference() with rcu_access_pointer() From: Andreea Bernat To: Greg KH Cc: Larry.Finger@lwfinger.net, navin patidar , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Paul McKenney Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rcu_dereference() calls are no longer there. They were removed. Sorry, Andreea 2014-09-08 23:48 GMT+03:00 Greg KH : > On Thu, Sep 04, 2014 at 08:15:48PM +0300, Andreea-Cristina Bernat wrote: >> The "br_port" local variables obtained through the rcu_dereference() calls are >> not dereferenced in the rest of their function. >> Therefore, it is recommended to use rcu_access_pointer() instead of >> rcu_dereference(). >> This patch makes the replacements. >> >> The first step to detect this was made with the following Coccinelle semantic >> patch: >> @@ >> identifier p; >> @@ >> >> * p = rcu_dereference(...) >> ... when any >> when != p >> ( >> * if( (<+...p...+>) ) { ... } >> | >> * while( (<+...p...+>) ) { ... } >> ) >> ... when != p >> >> After the analysis of the output, the change was made manually. >> >> Signed-off-by: Andreea-Cristina Bernat >> --- >> drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c >> index 1413ec8..93228dc 100644 >> --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c >> +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c >> @@ -1684,7 +1684,7 @@ static int rtw_br_client_tx(struct adapter *padapter, struct sk_buff **pskb) >> void *br_port = NULL; >> >> rcu_read_lock(); >> - br_port = rcu_dereference(padapter->pnetdev->rx_handler_data); >> + br_port = rcu_access_pointer(padapter->pnetdev->rx_handler_data); >> rcu_read_unlock(); >> spin_lock_bh(&padapter->br_ext_lock); >> if (!(skb->data[0] & 1) && br_port && >> @@ -1868,7 +1868,7 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt) >> } >> >> rcu_read_lock(); >> - br_port = rcu_dereference(padapter->pnetdev->rx_handler_data); >> + br_port = rcu_access_pointer(padapter->pnetdev->rx_handler_data); >> rcu_read_unlock(); >> >> if (br_port && check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_ADHOC_STATE)) { > > This patch doesn't apply at all to my staging-next branch of the > staging.git tree on git.kernel.org :( >