All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Tu <u9012063@gmail.com>
To: nicolas.dichtel@6wind.com
Cc: kortstro <niko.kortstrom@nokia.com>,
	David Miller <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ip6_gre: fix moving ip6gre between namespaces
Date: Fri, 17 Jan 2020 15:52:15 -0800	[thread overview]
Message-ID: <CALDO+SZppBa6Wm+yi-UfQohzH3We3jWHZk5Ge8fTutH6VJHg7Q@mail.gmail.com> (raw)
In-Reply-To: <0b180112-5931-36b4-670d-192fd714a14e@6wind.com>

On Thu, Jan 16, 2020 at 8:00 AM Nicolas Dichtel
<nicolas.dichtel@6wind.com> wrote:
>
> + William Tu
>
> Le 16/01/2020 à 15:43, kortstro a écrit :
> > On 1/16/20 4:02 PM, Nicolas Dichtel wrote:
> >> Le 16/01/2020 à 10:43, Niko Kortstrom a écrit :
> >>> Support for moving IPv4 GRE tunnels between namespaces was added in
> >>> commit b57708add314 ("gre: add x-netns support"). The respective change
> >>> for IPv6 tunnels, commit 22f08069e8b4 ("ip6gre: add x-netns support")
> >>> did not drop NETIF_F_NETNS_LOCAL flag so moving them from one netns to
> >>> another is still denied in IPv6 case. Drop NETIF_F_NETNS_LOCAL flag from
> >>> ip6gre tunnels to allow moving ip6gre tunnel endpoints between network
> >>> namespaces.
> >>>
> >>> Signed-off-by: Niko Kortstrom <niko.kortstrom@nokia.com>
> >> LGTM.
> >> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Hi Nicolas,

I did not test moving between namespaces at that time.
Your change looks good to me.

Acked-by: William Tu <u9012063@gmail.com>

Thanks
William

> >>
> >> Did you test real x-vrf cases with the three kinds of gre interfaces
> >> (gre/collect_md, gretap and erspan)?
> > This was only verified in real use with ip6gretap.
> William, did you set this flag on collect_md interfaces because you did not test
> this feature or was it another reason?
>
> Note: the flag was added here: 6712abc168eb ("ip6_gre: add ip6 gre and gretap
> collect_md mode").
>
> Regards,
> Nicolas

  reply	other threads:[~2020-01-17 23:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16  9:43 [PATCH] net: ip6_gre: fix moving ip6gre between namespaces Niko Kortstrom
2020-01-16 14:02 ` Nicolas Dichtel
2020-01-16 14:43   ` kortstro
2020-01-16 16:00     ` Nicolas Dichtel
2020-01-17 23:52       ` William Tu [this message]
2020-01-20  9:01 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDO+SZppBa6Wm+yi-UfQohzH3We3jWHZk5Ge8fTutH6VJHg7Q@mail.gmail.com \
    --to=u9012063@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=niko.kortstrom@nokia.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.