All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Dryomov <ilya.dryomov@inktank.com>
To: Chaitanya Huilgol <Chaitanya.Huilgol@sandisk.com>
Cc: Somnath Roy <Somnath.Roy@sandisk.com>,
	Sage Weil <sage@inktank.com>,
	Chaitanya Huilgol <chaitanya.huilgol@gmail.com>,
	Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] ceph: rbd option listing and tcp_nodelay support
Date: Thu, 22 Jan 2015 17:28:47 +0300	[thread overview]
Message-ID: <CALFYKtAu-h86KL6A5o9tLyKo7UW=K_3Tv0aC4=hyhhR0Qd7X9w@mail.gmail.com> (raw)
In-Reply-To: <9E914F5BD7F48A4782456CEB550A42280A75FE4C@SACMBXIP01.sdcorp.global.sandisk.com>

On Thu, Jan 22, 2015 at 4:33 PM, Chaitanya Huilgol
<Chaitanya.Huilgol@sandisk.com> wrote:
> Ok, I think for now we should first get the core feature support in, if the changes in the messenger layer look fine, then I will generate two patches
> -  messenger specific options
> - tcp_nodelay support
>
> As a next set we can implement the  krbd_default_map_options in the ceph.conf and pass it down.
>
> Let me know.

Honestly, I don't see the point of splitting options the way you did
either.  There is just too much boilerplate for something as simple as
couple of flags: a struct with a single field to which ceph_messenger
then has a pointer, all the msgr opt macros (why?), the fact that
libceph options are now split between libceph.h and messenger.h, etc.

I'd just pass struct ceph_options * to ceph_messenger_init() and be
done with it.

Thanks,

                Ilya

  reply	other threads:[~2015-01-22 14:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 19:00 [PATCH] ceph: rbd option listing and tcp_nodelay support Chaitanya Huilgol
2015-01-21 19:18 ` Ilya Dryomov
2015-01-21 19:29   ` Somnath Roy
2015-01-21 19:46     ` Ilya Dryomov
2015-01-21 20:02       ` Somnath Roy
2015-01-22  2:33         ` Chaitanya Huilgol
2015-01-22  8:54         ` Ilya Dryomov
2015-01-22  9:54           ` Chaitanya Huilgol
2015-01-22 12:50             ` Ilya Dryomov
2015-01-22 13:33               ` Chaitanya Huilgol
2015-01-22 14:28                 ` Ilya Dryomov [this message]
2015-01-22 14:39                   ` Chaitanya Huilgol
2015-01-22 15:08                     ` Ilya Dryomov
2015-01-22 16:48                       ` Chaitanya Huilgol
2015-01-22 16:52                         ` Ilya Dryomov
2015-01-22 14:40             ` Sage Weil
2015-01-22 17:42           ` Somnath Roy
     [not found] <9E914F5BD7F48A4782456CEB550A42280A75F93C@SACMBXIP01.sdcorp.global.sandisk.com>
2015-01-21 18:32 ` Chaitanya Huilgol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALFYKtAu-h86KL6A5o9tLyKo7UW=K_3Tv0aC4=hyhhR0Qd7X9w@mail.gmail.com' \
    --to=ilya.dryomov@inktank.com \
    --cc=Chaitanya.Huilgol@sandisk.com \
    --cc=Somnath.Roy@sandisk.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=chaitanya.huilgol@gmail.com \
    --cc=sage@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.