From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:39779 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965769AbeCSQ1G (ORCPT ); Mon, 19 Mar 2018 12:27:06 -0400 MIME-Version: 1.0 In-Reply-To: <877eq8yqym.fsf@kamboji.qca.qualcomm.com> References: <20180319014032.9394-1-alexey.roslyakov@gmail.com> <20180319014032.9394-2-alexey.roslyakov@gmail.com> <877eq8yqym.fsf@kamboji.qca.qualcomm.com> From: Alexey Roslyakov Date: Mon, 19 Mar 2018 23:27:04 +0700 Message-ID: (sfid-20180319_173035_082107_6450B286) Subject: Re: [PATCH net-next v2 1/2] brcmfmac: add new dt entries for SG SDIO settings To: Kalle Valo Cc: Andrew Lunn , robh+dt@kernel.org, mark.rutland@arm.com, Arend van Spriel , franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, Kalle, good remark, I'll try to make it clear in next version. Thank you. On 19 March 2018 at 23:23, Kalle Valo wrote: > Alexey Roslyakov writes: > >> There are 3 fields in SDIO settings (quirks) to workaround some of the >> SG SDIO host particularities, i.e higher align requirements for SG >> items. All coding is done the long time ago, but there is no way to >> change the driver behavior without patching the kernel. Add missing >> devicetree entries. >> >> Signed-off-by: Alexey Roslyakov > > The commit log is not clear for me, what does "all coding is done long > time ago" exactly mean? What code and where? > >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) > > Why net-next? To me it looks like this should go to > wireless-drivers-next. > > -- > Kalle Valo -- With best regards, Alexey Roslyakov Email: alexey.roslyakov@gmail.com