All of lore.kernel.org
 help / color / mirror / Atom feed
From: Asaf Kahlon <asafka7@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3, 5/6] package/collectd: add capabilities option
Date: Tue, 21 Apr 2020 20:25:09 +0300	[thread overview]
Message-ID: <CALFsTFUGkEk66SasixmJm=5NHi8z8FdkL7BQJKwoxaEKC8OxjQ@mail.gmail.com> (raw)
In-Reply-To: <20200415063008.2237470-5-fontaine.fabrice@gmail.com>

Hello,

On Wed, Apr 15, 2020 at 9:28 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> capabilities plugin is available since version 5.11.0 and
> https://github.com/collectd/collectd/commit/b934f1572cdb54cf485b600546a72dbf9929ba2c
>
> It is currently enabled by default depending on jansson and
> libmicrohttpd availability
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Thomas Petazzoni):
>  - Add dmidecode runtime dependency
>
>  package/collectd/Config.in   | 10 ++++++++++
>  package/collectd/collectd.mk |  2 ++
>  2 files changed, 12 insertions(+)
>
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index 7186d67c36..3fc07a9014 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -128,6 +128,16 @@ config BR2_PACKAGE_COLLECTD_BIND
>         help
>           Collects BIND DNS statistics.
>
> +config BR2_PACKAGE_COLLECTD_CAPABILITIES
> +       bool "capabilities"
> +       depends on BR2_aarch64 || BR2_i386 || BR2_x86_64 # dmidecode
> +       select BR2_PACKAGE_DMIDECODE # runtime
> +       select BR2_PACKAGE_JANSSON
> +       select BR2_PACKAGE_LIBMICROHTTPD
> +       help
> +         Collects selected static platform data using dmidecode and
> +         expose it through micro embedded webserver.
> +
>  config BR2_PACKAGE_COLLECTD_CEPH
>         bool "ceph"
>         select BR2_PACKAGE_YAJL
> diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk
> index 964f4dc694..f04ccdb2ff 100644
> --- a/package/collectd/collectd.mk
> +++ b/package/collectd/collectd.mk
> @@ -51,6 +51,7 @@ COLLECTD_CONF_OPTS += \
>         $(if $(BR2_PACKAGE_COLLECTD_APCUPS),--enable-apcups,--disable-apcups) \
>         $(if $(BR2_PACKAGE_COLLECTD_BATTERY),--enable-battery,--disable-battery) \
>         $(if $(BR2_PACKAGE_COLLECTD_BIND),--enable-bind,--disable-bind) \
> +       $(if $(BR2_PACKAGE_COLLECTD_CAPABILITIES),--enable-capabilities,--disable-capabilities) \
>         $(if $(BR2_PACKAGE_COLLECTD_CEPH),--enable-ceph,--disable-ceph) \
>         $(if $(BR2_PACKAGE_COLLECTD_CHRONY),--enable-chrony,--disable-chrony) \
>         $(if $(BR2_PACKAGE_COLLECTD_CGROUPS),--enable-cgroups,--disable-cgroups) \
> @@ -153,6 +154,7 @@ COLLECTD_DEPENDENCIES = \
>         $(if $(BR2_PACKAGE_COLLECTD_AMQP),rabbitmq-c) \
>         $(if $(BR2_PACKAGE_COLLECTD_APACHE),libcurl) \
>         $(if $(BR2_PACKAGE_COLLECTD_BIND),libcurl libxml2) \
> +       $(if $(BR2_PACKAGE_COLLECTD_CAPABILITIES),jansson libmicrohttpd) \
>         $(if $(BR2_PACKAGE_COLLECTD_CEPH),yajl) \
>         $(if $(BR2_PACKAGE_COLLECTD_CURL),libcurl) \
>         $(if $(BR2_PACKAGE_COLLECTD_CURL_JSON),libcurl yajl) \
> --
> 2.25.1
>
Reviewed-by: Asaf Kahlon <asafka7@gmail.com>

Regards,
Asaf.

  reply	other threads:[~2020-04-21 17:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  6:30 [Buildroot] [PATCH v3,1/6] package/collectd: drop autoreconf Fabrice Fontaine
2020-04-15  6:30 ` [Buildroot] [PATCH v3,2/6] package/collectd: remove lvm Fabrice Fontaine
2020-04-15  6:30 ` [Buildroot] [PATCH v3, 3/6] package/collectd: add DPDK_TELEMETRY option Fabrice Fontaine
2020-04-19 21:14   ` Yann E. MORIN
2020-04-19 22:34     ` Fabrice Fontaine
2020-04-20  5:16     ` Thomas Petazzoni
2020-08-17 10:18   ` Thomas Petazzoni
2020-08-28 16:49     ` Peter Korsgaard
2020-04-15  6:30 ` [Buildroot] [PATCH v3,4/6] package/collectd: add InfluxDB support Fabrice Fontaine
2020-04-21 17:24   ` [Buildroot] [PATCH v3, 4/6] " Asaf Kahlon
2020-08-17 10:18   ` Thomas Petazzoni
2020-04-15  6:30 ` [Buildroot] [PATCH v3, 5/6] package/collectd: add capabilities option Fabrice Fontaine
2020-04-21 17:25   ` Asaf Kahlon [this message]
2020-08-17 10:18   ` Thomas Petazzoni
2020-04-15  6:30 ` [Buildroot] [PATCH v3,6/6] package/collectd: add buddyinfo option Fabrice Fontaine
2020-04-21 17:25   ` [Buildroot] [PATCH v3, 6/6] " Asaf Kahlon
2020-08-17 10:18   ` Thomas Petazzoni
2020-04-19 21:38 ` [Buildroot] [PATCH v3,1/6] package/collectd: drop autoreconf Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALFsTFUGkEk66SasixmJm=5NHi8z8FdkL7BQJKwoxaEKC8OxjQ@mail.gmail.com' \
    --to=asafka7@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.