From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA0D7C4338F for ; Thu, 19 Aug 2021 20:51:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF5CA60200 for ; Thu, 19 Aug 2021 20:51:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF5CA60200 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A82E80F47; Thu, 19 Aug 2021 22:51:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jWZNqi7I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 84AD782C0C; Thu, 19 Aug 2021 22:51:39 +0200 (CEST) Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A74AA80F47 for ; Thu, 19 Aug 2021 22:51:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=paul.liu@linaro.org Received: by mail-yb1-xb2d.google.com with SMTP id z18so14715477ybg.8 for ; Thu, 19 Aug 2021 13:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=57tGI5s7MyF+Ti/Hoh/1ff1SFdtDxXcv4c4//wg3SYY=; b=jWZNqi7IZm6qe2PBfNGvIw+zgqeZDrn7urhQnG9V/zjNalsdrw3tg+09KKlPUK8RtT oY7TQ+y+sFO7Oht/ZKhzSBKiVR42zvGddiqpRIgTTQh7kzFrgMrulqkgJPTRYthIP6PO nyO3tC7rwib+FhCclSWx0KCaNHJrmCcXZjJoxztX/6qtkgJQM7aMIE/46hJADYZMn7kE 062iolqQBhdIGsQ+bFT2imFNRz+O33bbmPb5oxcHgFit4W/IzUjkewD2E32IH2ePLZms kilzJAzHryhv43bUjJsCb17Ue7nvAtP27ACAqyjbVmDvZoJjxLS97Qb9nyEbkSCIbN9U oXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=57tGI5s7MyF+Ti/Hoh/1ff1SFdtDxXcv4c4//wg3SYY=; b=tv3so+qHxs6hAyeDnr8fLQ2qXFhAzxSBY4SgRIS8LTXM2Ha1/u6mWQ4Cgut1x0G1Ja P8ck0B8kFrHARQWHLdT0ARDC4WNzrjzSAFRM/NXFOre9W/RbtbtY/DMjMLyZZMEtV4So 2+HQXthpvdRe7WE00mPvroDWU2NJHJn3XRqvp+TAcO+5gLy2FLL4VZdABhgWoXa0CU97 YsghHy4yAbBOK3QgaA4pI9k3PDR4jVHgL+DmaugO1XJUJ94FfDMNxiaCHmJRA/E6mAng /K7CS8WKXuqLwqMYnKtvnutS8ZGJxlFFOvvmoeNEQo7NazYMOQVKbWfjSr3YJAU33CrN 7/Jw== X-Gm-Message-State: AOAM5322e23vopQsxsmxgXo0ur/EhT4Nl/4dQEOJUgToXoKMLc03ZBRV s3Zgf5xS8UKbQK90XeRrUF5wuidWBQHZn1aqmHVoBQ== X-Google-Smtp-Source: ABdhPJyUC+91cRk5ED4kepLudz+7Y2avuz+vlQGAljjRJaj/TOGfIvOjvSh/+E06ArvKA/fStBy/cWDwJFTlhjowlVo= X-Received: by 2002:a25:ba05:: with SMTP id t5mr19906838ybg.120.1629406293332; Thu, 19 Aug 2021 13:51:33 -0700 (PDT) MIME-Version: 1.0 References: <20210813005901.16839-1-festevam@denx.de> <04480f602808792b607089e5c2868ec9@denx.de> <88d0c3c4-5596-32e9-0434-cd0316227a3f@kontron.de> In-Reply-To: <88d0c3c4-5596-32e9-0434-cd0316227a3f@kontron.de> From: Paul Liu Date: Fri, 20 Aug 2021 04:51:22 +0800 Message-ID: Subject: Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default To: Frieder Schrempf Cc: Fabio Estevam , Marek Vasut , Fabio Estevam , Stefano Babic , Kirill Kapranov , Uri Mashiach , Valentin Raevsky , U-Boot-Denx , Harald Seiler Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Frieder, I'll confirm it. But I guess you are correct. I'll send a patch soon when I implement this right. Yours, Paul On Thu, 19 Aug 2021 at 15:14, Frieder Schrempf wrote: > On 19.08.21 02:27, Fabio Estevam wrote: > > [Adding Marek] > > > > On Wed, Aug 18, 2021 at 6:39 PM Fabio Estevam > wrote: > >> > >> Hi Paul, > >> > >> On Wed, Aug 18, 2021 at 6:32 PM Paul Liu wrote: > >>> > >>> Hi Fabio, > >>> > >>> I got several boards. With all different PN. But all of them are 2GB > memory. And the recent master doesn't boot on one of my board. I haven't > tried all of the combinations. > >> > >> With the U-Boot from Compulab, it reports 4GB. With mainline U-Boot it > >> reports 2GB, so yes, there is an issue indeed. > >> > >> However, I don't see a hang. > >> > >>> After bisect, I found commit e27bddff breaks the boot. It just hang > there. > >> > >> Adding Frieder as the author of the patch. > > > > Marek objected to this change, which is now: > > e27bdd ff4b97 ("imx8m: Restrict usable memory to space below 4G > boundary") > > Yes, Marek objected and it was still pulled in for some reason. > > > > > As this causes a regression on Paul's i.MX8MM IoT Gateway board, > > should this be reverted? > > Maybe, yes. I'll leave that decision to the maintainers. > > For the failure: The change in e27bddff4b97 assumes that gd->ram_size was > set during initialization/detection of the DDR. Could it be that the > Compulab board doesn't do this and gd->ram_size is 0 or differs from the > actual DDR size? That would probably cause some kind of issue. > > Paul, maybe you could check if gd->ram_size is set properly. Other boards > do this by implementing board_phys_sdram_size() [1], which also makes sure > that the memory map is updated with the detected size in dram_init() [2]. > > [1] > https://elixir.bootlin.com/u-boot/latest/source/board/gateworks/venice/imx8mm_venice.c#L21 > [2] > https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-imx/imx8m/soc.c#L218 >