From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ABFEEB64D9 for ; Sat, 17 Jun 2023 08:26:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AD2BD86290; Sat, 17 Jun 2023 10:26:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FPLNqNzR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 380E08629B; Sat, 17 Jun 2023 10:26:51 +0200 (CEST) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DE4518620F for ; Sat, 17 Jun 2023 10:26:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bigunclemax@gmail.com Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-514ab6cb529so5404805a12.1 for ; Sat, 17 Jun 2023 01:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686990408; x=1689582408; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s/naurQ1kLyuIs7svdR85U5QXn/8uZY2mZyghA5T7S4=; b=FPLNqNzRliMAFSYDtx5L/pCxMSmxSAnAF1r9vM5269XrNy4M4hPNjwJv3CjZa8/9BN RRL4PxOtVLnsyErfLIGhDRIj/gDVsSVvWUROXgOm8MrvgKXk7EfoX5d8rv6DO9xr2bou NJA/GfCskB24gJYzaIKWNrswyp3zLfv1eWWhICHs+7/+wH+l9MJIMvjIt9CYEfartAKH ueLejpA4mGFPZJBc8SDUenYEUztiHL8oJxcHRXX55HKRvAEJ2ir4oYkVm8MC0mciFU2Q mvbR2r2kRudxfHIrmdrQ99fEPqDL65eWR4lAWlnKfYcKH0NLqQlMTDAgndq9wK1Sh4yr 9xlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686990408; x=1689582408; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s/naurQ1kLyuIs7svdR85U5QXn/8uZY2mZyghA5T7S4=; b=f9v3ArT0TvpE7PLCKHzV4G+eI+svi/0aIPBmjrFcougdzBPSVBj5k/8Dn9Rsi4nZrt /2fw0JY76hqcUWrqsyIVuAH65PGFn49w3dOWbKFYCa0I13/M0H3Uogrz01MGIoDEDUtj M+7c5/Y8Y4tqefiqPHNpD9984x6xgBaH8CaufMQo64gCVcpWrmK82jHJAHzNHZRH8rV3 DE2PerQL/si1Q0Mr5+6eig3Or2kJevuw/H8puFO+lYFbCTN2O+cwrDsjumWDUEx4Jevm 1l3eMa8vve59bVPem8/IbvFSmB64P/vZndbS9lFDtyAPJB2swfLm475W68EoD+Cuw5x3 kDxA== X-Gm-Message-State: AC+VfDyCxkF04ZByohapNHAT6/+tdE2RPQmw1RwJMYJ2eiNIcloFRyin QyD3QOHfz0Xr4rakezFdylo0DgLU1MsD0ijetsE= X-Google-Smtp-Source: ACHHUZ6UTDXZWbG/7l9jQI6PDG3MT1C69LMTy5vzXe1yOmCLLJtuF8UW0U+7qv8u1WPaMsRszl/mxv+pe1UHTPR3iuo= X-Received: by 2002:a17:906:58d2:b0:976:a0b2:bf0a with SMTP id e18-20020a17090658d200b00976a0b2bf0amr8725162ejs.7.1686990407973; Sat, 17 Jun 2023 01:26:47 -0700 (PDT) MIME-Version: 1.0 References: <20221206004549.29015-1-andre.przywara@arm.com> <04c52801-a6d0-033b-c7f4-613e0b789d96@gmail.com> <20230612012056.65883683@slackpad.lan> <20230616165902.0b6eea86@donnerap.cambridge.arm.com> <20230616173645.6d5597c4@donnerap.cambridge.arm.com> In-Reply-To: <20230616173645.6d5597c4@donnerap.cambridge.arm.com> From: Maxim Kiselev Date: Sat, 17 Jun 2023 11:26:35 +0300 Message-ID: Subject: Re: [RFC PATCH 00/17] sunxi: rework pinctrl and add T113s support To: Andre Przywara Cc: Sam Edwards , u-boot@lists.denx.de, Samuel Holland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Andre, =D0=BF=D1=82, 16 =D0=B8=D1=8E=D0=BD. 2023=E2=80=AF=D0=B3. =D0=B2 19:36, And= re Przywara : [..] > > thanks for the reply! If you have anything that is missing or broken in > the new version of the patchset I put on github, please let me know. I tried the new version and everything looks pretty good for me. Great job! Just one note. Could you please add SUNXI_R_CPUCFG_BASE 0x07000400 to cpu_sunxi_ncat2.h file. This register is required for Sam's PCSI patches= . Otherwise it leads to undeclared error: In file included from ./arch/arm/include/asm/armv7.h:60, from arch/arm/cpu/armv7/sunxi/psci.c:16: arch/arm/cpu/armv7/sunxi/psci.c: In function =E2=80=98sunxi_cpu_set_e= ntry=E2=80=99: arch/arm/cpu/armv7/sunxi/psci.c:138:24: error: =E2=80=98SUNXI_R_CPUCFG_BASE=E2=80=99 undeclared (first use in this functio= n); did you mean =E2=80=98SUNXI_CPUCFG_BASE=E2=80=99? 138 | SUNXI_R_CPUCFG_BASE + SUN8I_R528_SOFT_EN= TRY); | ^~~~~~~~~~~~~~~~~~~