All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve deRosier <derosier@gmail.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libertas_tf: lower the debug level of command trace
Date: Mon, 11 Feb 2019 05:23:17 -0800	[thread overview]
Message-ID: <CALLGbRLZGJGjJuYsno-y8=5UWZ9xjwvgTeM4hZRGNXS-Y+WF9Q@mail.gmail.com> (raw)
In-Reply-To: <20190210194735.17939-1-lkundrak@v3.sk>

On Sun, Feb 10, 2019 at 11:47 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> Logging each and every command response is way too much for INFO level.
> Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  drivers/net/wireless/marvell/libertas_tf/cmd.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas_tf/cmd.c b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> index 909ac3685010..64b147dd2432 100644
> --- a/drivers/net/wireless/marvell/libertas_tf/cmd.c
> +++ b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> @@ -737,10 +737,9 @@ int lbtf_process_rx_command(struct lbtf_private *priv)
>         respcmd = le16_to_cpu(resp->command);
>         result = le16_to_cpu(resp->result);
>
> -       if (net_ratelimit())
> -               pr_info("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> -                       respcmd, le16_to_cpu(resp->seqnum),
> -                       le16_to_cpu(resp->size));
> +       lbtf_deb_cmd("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> +                    respcmd, le16_to_cpu(resp->seqnum),
> +                    le16_to_cpu(resp->size));
>
>         if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
>                 spin_unlock_irqrestore(&priv->driver_lock, flags);
> --
> 2.20.1
>

Reviewed-by: Steve deRosier <derosier@cal-sierra.com>

  reply	other threads:[~2019-02-11 13:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-10 19:47 [PATCH] libertas_tf: lower the debug level of command trace Lubomir Rintel
2019-02-11 13:23 ` Steve deRosier [this message]
2019-02-19 15:10 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLGbRLZGJGjJuYsno-y8=5UWZ9xjwvgTeM4hZRGNXS-Y+WF9Q@mail.gmail.com' \
    --to=derosier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.