All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Geissler <geissonator@gmail.com>
To: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: New obmc-host-startmin action target proposal
Date: Wed, 28 Mar 2018 08:25:11 -0500	[thread overview]
Message-ID: <CALLMt=qYtvJ5-tgf1=NVxYv8OeviamZrAGizsNYzE48V-icVww@mail.gmail.com> (raw)

Recently an issue arose
(https://github.com/openbmc/openbmc/issues/3035) which stated OpenBMC
needed to reset the host reboot counter whenever a fresh power on is
done. The host reboot counter
(https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/Boot/RebootAttempts.interface.yaml)
is used to ensure OpenBMC only retries the boot of the host a certain
amount of times.  It’s decremented each time the host fails to boot
and if all retries are used, the BMC will go to a host quiesce state.

It brought up an interesting issue because the reboot path used by
OpenBMC when the host fails to boot basically just used the host-stop
and then host-start target.  The host-start target is the same target
used for a fresh power on. This put me in a quandary because I
couldn’t just add a service to host-start to reset the host reboot
count since it was used in the reboot path.

Adriana and I discussed a few options (bread crumb in reboot path to
look at, software logic in phosphor-host-state code) but none seemed
as clean a just making a new host start action target.  The proposal
is we have two targets:

obmc-host-start (existing target)
obmc-host-startmin (minimum services required to start host, used by
reboot target)

The obmc-host-start target will require (i.e. start) the
obmc-host-startmin target.  We can now add services that we only want
run during a fresh power on to obmc-host-start.

I put the code up in https://gerrit.openbmc-project.xyz/#/c/9774/ (and
it’s related commit).

ref: https://github.com/openbmc/docs/blob/master/openbmc-systemd.md
(I’ll be updating this pending and comments on above design)

Comments appreciated.

Thanks,
Andrew

                 reply	other threads:[~2018-03-28 13:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLMt=qYtvJ5-tgf1=NVxYv8OeviamZrAGizsNYzE48V-icVww@mail.gmail.com' \
    --to=geissonator@gmail.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.