From mboxrd@z Thu Jan  1 00:00:00 1970
MIME-Version: 1.0
References: <20210203070159.3610435-1-greg@embeddedgreg.com>
 <15001d4b-48ce-7192-d5e8-0e4dab9a55e0@siemens.com>
 <0bbdd664-2065-1680-313c-fcb7dbd6388e@siemens.com>
In-Reply-To: <0bbdd664-2065-1680-313c-fcb7dbd6388e@siemens.com>
From: Greg Gallagher <greg@embeddedgreg.com>
Date: Fri, 5 Feb 2021 09:47:54 -0500
Message-ID: <CALLqZ8Qq7pufiD42AOpLnux=2hT1=xKtO7+LQHN8WsY2+8rSRw@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] kernel: cobalt: Remove header file for newer
 kernels
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: Discussions about the Xenomai project <xenomai.xenomai.org>
List-Unsubscribe: <https://xenomai.org/mailman/options/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=unsubscribe>
List-Archive: <http://xenomai.org/pipermail/xenomai/>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-request@xenomai.org?subject=help>
List-Subscribe: <https://xenomai.org/mailman/listinfo/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: xenomai@xenomai.org

On Fri, Feb 5, 2021 at 9:45 AM Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 03.02.21 10:50, Jan Kiszka via Xenomai wrote:
> > On 03.02.21 08:01, Greg Gallagher via Xenomai wrote:
> >> 5.4 kernels do not have compiler.h, only include this header file for
> kernels older then 5.4
> >>
> >> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
> >> ---
> >>  kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h
> b/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h
> >> index 7444cc823..17be10339 100644
> >> --- a/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h
> >> +++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h
> >> @@ -29,7 +29,11 @@
> >>  #define XNARCH_HOST_TICK_IRQ __ipipe_hrtimer_irq
> >>
> >>  #include <asm/barrier.h>
> >> +
> >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(5,4,0)
> >>  #include <asm/compiler.h>
> >> +#endif
> >> +
> >>  #include <asm/cmpxchg.h>
> >>  #include <asm/switch_to.h>
> >>  #include <asm/system_misc.h>
> >>
> >
> > There is still arch/arm64/include/asm/compiler.h in today's master.
> >
> > What error exactly are you fixing? That we should rather including
> > linux/compiler.h? Or is that header obsolete for us now, for all kernel=
s?
> >
>
> OK, that file vanished in 4.20 and resurrected in 5.7. Given that we do
> not head for ipipe over > 5.4, I will just merge this (ported to next).
>
> Jan
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux


Sorry, I meant to look into that. I=E2=80=99m assuming this won=E2=80=99t i=
mpact the port
to dovetail? We could always add it back for kernels greater then 5.6 and
remove for 4.20 and above?

Greg

>
>