All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Gallagher <greg@embeddedgreg.com>
To: Dario Binacchi <dariobin@libero.it>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	"Xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: Re: [RESEND PATCH] arm: ipipe: omap-gpio: Fix interrupts delivering
Date: Sun, 3 Oct 2021 20:27:24 -0400	[thread overview]
Message-ID: <CALLqZ8RGB8-dd0o54EyMyA=a0BuZdJXTHDE7HDR0YJic+eLn+w@mail.gmail.com> (raw)
In-Reply-To: <CALLqZ8SjgvN8zsA22f04-_gj8N_pzSuTaKDiT8ufTHpJ6UDm+Q@mail.gmail.com>

On Sun, Sep 26, 2021 at 7:59 AM Greg Gallagher <greg@embeddedgreg.com>
wrote:

>
>
> On Sun, Sep 26, 2021 at 6:07 AM Dario Binacchi <dariobin@libero.it> wrote:
>
>> If you set the irq trigger as edge rising or falling the interrupts are
>> no longer delivered to the upper layers. The gpiokeys driver, for
>> example, no longer detects the change in the state of the pins mapped
>> to the buttons.
>>
>> Fixes: c041e938312b ("arm: ipipe: Fix up the omap-gpio driver to deliver
>> interrupts properly to the pipeline")
>> Signed-off-by: Dario Binacchi <dariobin@libero.it>
>> ---
>>  drivers/gpio/gpio-omap.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
>> index c8192c82d2b1..ae527d65bfc2 100644
>> --- a/drivers/gpio/gpio-omap.c
>> +++ b/drivers/gpio/gpio-omap.c
>> @@ -577,9 +577,6 @@ static int omap_gpio_irq_type(struct irq_data *d,
>> unsigned type)
>>         }
>>         raw_spin_unlock_irqrestore(&bank->lock, flags);
>>
>> -#ifdef CONFIG_IPIPE
>> -       irq_set_handler_locked(d, handle_level_irq);
>> -#else
>>         if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
>>                 irq_set_handler_locked(d, handle_level_irq);
>>         else if (type & (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
>> @@ -590,7 +587,7 @@ static int omap_gpio_irq_type(struct irq_data *d,
>> unsigned type)
>>                  * So just use handle_simple_irq.
>>                  */
>>                 irq_set_handler_locked(d, handle_simple_irq);
>> -#endif
>> +
>>         return 0;
>>
>>  error:
>> --
>> 2.17.1
>
>
> Thanks, applying to 5.4 and 4.19. I’ll have a. Updated release this week.
>
> Thanks
>
> Greg
>
>>
>>
>> Applied to master, starting the 4.19 and 5.4 update.

Thanks

-Greg

      reply	other threads:[~2021-10-04  0:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 10:07 [RESEND PATCH] arm: ipipe: omap-gpio: Fix interrupts delivering Dario Binacchi
2021-09-26 11:59 ` Greg Gallagher
2021-10-04  0:27   ` Greg Gallagher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALLqZ8RGB8-dd0o54EyMyA=a0BuZdJXTHDE7HDR0YJic+eLn+w@mail.gmail.com' \
    --to=greg@embeddedgreg.com \
    --cc=dariobin@libero.it \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.