From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1521120161.86246.4.camel@primarydata.com> From: Eddie Horng Date: Fri, 16 Mar 2018 23:06:37 +0800 Message-ID: Subject: Re: readdir returns d_type=DT_UNKNOWN to overlay exported dir (NFSv3) Content-Type: text/plain; charset="UTF-8" To: Amir Goldstein Cc: Trond Myklebust , "bfields@fieldses.org" , "miklos@szeredi.hu" , "linux-unionfs@vger.kernel.org" , "jlayton@kernel.org" List-ID: > Eddie, > > I rebased and push branch ovl-xino [1] to my github, it includes the > fix you already > tested. > > If your proprietary filesystem does not implement the operation encode_fh() > and uses the default 32INO encoding then you don't have to specify any new > mount option. If it implements its own file handle encoding, you need to specify > overlay mount option -o xino to declare that all inode numbers are > limited to 32bit > (or at least not using 64bit). > > Cheers, > Amir. > > [1] https://github.com/amir73il/linux/commits/ovl-xino I tested ovl-xino with my proprietary filesystem and ext4, the result is great -- readdir returns correct d_type. Really thanks your effort to find root cause and provide solution so fast. In addition, do you plan to merge the fix or even the xino feature in 4.16? Thanks, Eddie