From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158C1C31E45 for ; Thu, 13 Jun 2019 17:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D98422183F for ; Thu, 13 Jun 2019 17:25:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PRI840OE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728651AbfFMRZL (ORCPT ); Thu, 13 Jun 2019 13:25:11 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:40727 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727081AbfFMRZL (ORCPT ); Thu, 13 Jun 2019 13:25:11 -0400 Received: by mail-io1-f67.google.com with SMTP id n5so18697168ioc.7 for ; Thu, 13 Jun 2019 10:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i3k1ewQshQXWU0zPqm6pMO1N4JQ6ELHz1NxT8KKHaxU=; b=PRI840OEIYdnMjVzyvdNG6jNrPT6PG0274LwvS4xl/F1GKW4tkG8ElrE5nEv/v4d2h pdQhlRr6ijJYmX/ulTIqX8hEPfoZ+w81aUCCipbv93f0FPopFfSjx1B2Y/A96iqRtIGX lpmt+uy2fpEpDKCZLGMdaA4FiVQKVM43zHgam29l432+DKFE2tusOg58mk22UzkTO+JI sfrv93+aQ7s/YOHOgNvH9R0SWUnTHVoLBWEMF0ZlfHiF1ZaBhJYKX+cXd/qDMljGYRXp ltes+z8RFDcNwoohT/UqVtbVXS07ZVS8G6m9AftlABKcMwgGQbaKVjEeRixEa2CLnusI sGPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i3k1ewQshQXWU0zPqm6pMO1N4JQ6ELHz1NxT8KKHaxU=; b=IVpkWfNoGkP02JJUfvZex8s0grvr3HRpUqWmlhuU69jNQPg4L7N7jibhrtsQM3oi1o QeD0Zaw3roUKVQjra6vH2AtIBhP9ybeyB9SqVfZNVw8lnLC6Qy0k7YrA0PuSMTMpVm7M h58xdd98Sx2G48rrEV7jD/nWCCiA82eYN8WAPhjXqwWX0950/fP7fhTiGxK+xKyI6XrG BONIB4VBE5bLvQCIIXPvr0TQVqZlg9JZ4zJG4y0DDAA6PPey2QCIjgtpGQ7BEaDrXwKf Uz3Frz7eQA2BfINY4nf17uZFZkxyhwiFmCCVKwUPChlgbDUwjrowI5ehQ/AM9slU4dx2 x7zw== X-Gm-Message-State: APjAAAVC0IP1ffgAQXiY9gtiEFvLFDZqeB23cq6mCqEm915nBC0uhWal qzNEv3q1MLmK+4kZt3GaUBmFh1BvgPwlG4zEnHxAxQ== X-Google-Smtp-Source: APXvYqz+be35Z7WOf3tL1YUmH7TuwYnypRlKk1tb+7pCTUCRVz7FVgMNC+q7mps6ZQu5ZnQDIb0tXv/jgzCnqf68NDg= X-Received: by 2002:a5d:94d7:: with SMTP id y23mr55512163ior.296.1560446710333; Thu, 13 Jun 2019 10:25:10 -0700 (PDT) MIME-Version: 1.0 References: <1560445409-17363-1-git-send-email-pbonzini@redhat.com> <1560445409-17363-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1560445409-17363-2-git-send-email-pbonzini@redhat.com> From: Jim Mattson Date: Thu, 13 Jun 2019 10:24:58 -0700 Message-ID: Subject: Re: [PATCH 01/43] KVM: VMX: Fix handling of #MC that occurs during VM-Entry To: Paolo Bonzini Cc: LKML , kvm list , Sean Christopherson , Vitaly Kuznetsov , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 10:03 AM Paolo Bonzini wrote: > > From: Sean Christopherson > > A previous fix to prevent KVM from consuming stale VMCS state after a > failed VM-Entry inadvertantly blocked KVM's handling of machine checks > that occur during VM-Entry. > > Per Intel's SDM, a #MC during VM-Entry is handled in one of three ways, > depending on when the #MC is recognoized. As it pertains to this bug > fix, the third case explicitly states EXIT_REASON_MCE_DURING_VMENTRY > is handled like any other VM-Exit during VM-Entry, i.e. sets bit 31 to > indicate the VM-Entry failed. > > If a machine-check event occurs during a VM entry, one of the following occurs: > - The machine-check event is handled as if it occurred before the VM entry: > ... > - The machine-check event is handled after VM entry completes: > ... > - A VM-entry failure occurs as described in Section 26.7. The basic > exit reason is 41, for "VM-entry failure due to machine-check event". > > Explicitly handle EXIT_REASON_MCE_DURING_VMENTRY as a one-off case in > vmx_vcpu_run() instead of binning it into vmx_complete_atomic_exit(). > Doing so allows vmx_vcpu_run() to handle VMX_EXIT_REASONS_FAILED_VMENTRY > in a sane fashion and also simplifies vmx_complete_atomic_exit() since > VMCS.VM_EXIT_INTR_INFO is guaranteed to be fresh. > > Fixes: b060ca3b2e9e7 ("kvm: vmx: Handle VMLAUNCH/VMRESUME failure properly") I'm never going to live down that subject line, am I? :-) Reviewed-by: Jim Mattson