From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F45C43460 for ; Tue, 4 May 2021 17:53:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46B5461076 for ; Tue, 4 May 2021 17:53:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232197AbhEDRyQ (ORCPT ); Tue, 4 May 2021 13:54:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232222AbhEDRyO (ORCPT ); Tue, 4 May 2021 13:54:14 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A1D4C061574 for ; Tue, 4 May 2021 10:53:18 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id 92-20020a9d02e50000b029028fcc3d2c9eso9047380otl.0 for ; Tue, 04 May 2021 10:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zBVMDvBEgjOjeMHbsEdTwYO7oiRFE8elSZdEfzu5kjo=; b=Hwj5AUvMrkRZauysJ4VIPZwfbnyHCjpUlARF9+kvnwXT7wKAuwkiCxrkcYY3bdDBFn TEUc9RwalezA/Ckl+j7dqQymKma/SAYUwK6AZOImiV1IE93bVdcOVHcVLfFeoXtIFSjO WyHBfaAyMJTsNoGt94zojRlK4hvKRV5Ben96Dd/KEqG/L93A93JlgiO5/MJ2FkiKokPO LP0HemyBSPR8eJiHlwoMtgTUvV3pAn0H4u8Mhgg+MQX5P45th0DljBpemVYxJyuoxshY Au9dpfeGBkduOEELK7ULyvyGjy53epUFFrz1yA9X6WHSYSNU7nc5bdsIuKUpL/ggN3+k LcJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zBVMDvBEgjOjeMHbsEdTwYO7oiRFE8elSZdEfzu5kjo=; b=EtOjA9cWFI7NeX5ieylfHyM5sTOGzCqtnXu3Dj6LUlGhk6+JtyzccbuTAzs8gzMD7D BLhWBRAGATNFUatemFwzzdm0nM+ZAcpHqgfM9+AzvJJ29OKl6DEvsh/2RR1gsbiDT989 tlLwrvPoux4Y4xd4ntxjvvAolHTt22YUjhuUio6Yg69rE1zjO43uEV2+sKkc0Vy943VG zhF8AS76QV7RADkvcMb1o5Pq8JVk/xG4vpVgMRB/SQuD8zSYnsNABFfJTUtPejLeuv6B jwhJpw6cMk7XHU/17UhwmB/LYZzNfEhKLXw84E2V7Xrt6Y4aCGoquDhQkUAnG9qcERgr Mo5g== X-Gm-Message-State: AOAM531nBIWt7ir7xJGdNuWVKxlgNTlDFYapadyhYoa87szAT7LCITDY PIVYpGUHygvZVCa/jYV6NCpDzlrsXkMAsNNEjIdVcA== X-Google-Smtp-Source: ABdhPJybH8tugiuOvAR59PbiEySOPnTUmRDfAz8EGG36kg/E0g04w83cO+/0DMLypHj9WwWuxaOMfd0B90CRESZwTus= X-Received: by 2002:a9d:1b4d:: with SMTP id l71mr20519674otl.241.1620150797159; Tue, 04 May 2021 10:53:17 -0700 (PDT) MIME-Version: 1.0 References: <20210504171734.1434054-1-seanjc@google.com> <20210504171734.1434054-2-seanjc@google.com> In-Reply-To: From: Jim Mattson Date: Tue, 4 May 2021 10:53:06 -0700 Message-ID: Subject: Re: [PATCH 01/15] KVM: VMX: Do not adverise RDPID if ENABLE_RDTSCP control is unsupported To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm list , LKML , Xiaoyao Li , Reiji Watanabe Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 4, 2021 at 10:37 AM Jim Mattson wrote: > > On Tue, May 4, 2021 at 10:17 AM Sean Christopherson wrote: > > > > Clear KVM's RDPID capability if the ENABLE_RDTSCP secondary exec control is > > unsupported. Despite being enumerated in a separate CPUID flag, RDPID is > > bundled under the same VMCS control as RDTSCP and will #UD in VMX non-root > > if ENABLE_RDTSCP is not enabled. > > > > Fixes: 41cd02c6f7f6 ("kvm: x86: Expose RDPID in KVM_GET_SUPPORTED_CPUID") > > Cc: stable@vger.kernel.org > > Signed-off-by: Sean Christopherson > > But KVM will happily emulate RDPID if the instruction causes a #UD > VM-exit, won't it? See commit fb6d4d340e05 (KVM: x86: emulate RDPID). Oh, after reading the second patch, I now see why this is needed. You mispelled 'advertise' in the summary line. Reviewed-by: Jim Mattson