All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Mattson <jmattson@google.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
	David Matlack <dmatlack@google.com>
Subject: Re: [PATCH v2] KVM: VMX: Print VM-instruction error when it may be helpful
Date: Tue, 10 May 2022 22:24:05 +0000	[thread overview]
Message-ID: <CALMp9eQEaWxLTY3d8JRFWdGn6qLuOLTX3y-t+W-mkEzCe3n0hg@mail.gmail.com> (raw)
In-Reply-To: <YnqSecml2/Ooc0E/@google.com>

On Tue, May 10, 2022 at 9:27 AM Sean Christopherson <seanjc@google.com> wrote:

> >  noinline void vmclear_error(struct vmcs *vmcs, u64 phys_addr)
> >  {
> > -     vmx_insn_failed("kvm: vmclear failed: %p/%llx\n", vmcs, phys_addr);
> > +     vmx_insn_failed("kvm: vmclear failed: %p/%llx err=%d\n",
>
> I highly doubt it will ever matter, but arguably this should be %u, not %d.
>

:-@

Okay; I will send out a V3, along with a separate patch to fix VMWRITE.

      reply	other threads:[~2022-05-10 22:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08  4:02 [PATCH v2] KVM: VMX: Print VM-instruction error when it may be helpful Jim Mattson
2022-05-10 16:27 ` Sean Christopherson
2022-05-10 22:24   ` Jim Mattson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALMp9eQEaWxLTY3d8JRFWdGn6qLuOLTX3y-t+W-mkEzCe3n0hg@mail.gmail.com \
    --to=jmattson@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.