All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Mattson <jmattson@google.com>
To: Lara Lazier <laramglazier@gmail.com>
Cc: Krish Sadhukhan <krish.sadhukhan@oracle.com>, kvm@vger.kernel.org
Subject: Re: [PATCH kvm-unit-tests] svm: Updated cr4 in test_efer to fix report msg
Date: Fri, 18 Jun 2021 14:10:01 -0700	[thread overview]
Message-ID: <CALMp9eRDkfHHmRuRuRabRLcNBhudJwb+mhE=WD2tVR016Yq58w@mail.gmail.com> (raw)
In-Reply-To: <CANX1H+2YUt6wF7P=jNBpfzJEnjz7Yz=Y8K_hWTwvYYbNb-vV2A@mail.gmail.com>

On Fri, Jun 18, 2021 at 1:57 PM Lara Lazier <laramglazier@gmail.com> wrote:
>
> Am Fr., 18. Juni 2021 um 22:26 Uhr schrieb Jim Mattson <jmattson@google.com>:
> >
> > On Fri, Jun 18, 2021 at 12:59 PM Lara Lazier <laramglazier@gmail.com> wrote:
> >
> > > My understanding is as follows:
> > > The "first" test should succeed with an SVM_EXIT_ERR when EFER.LME and
> > > CR0.PG are both
> > > non-zero and CR0.PE is zero (so I believe we do not really care
> > > whether CR4.PAE is set or not though
> > > I might be overlooking something here).
> >
> > You are overlooking the fact that the test will fail if CR4.PAE is
> > clear. If CR4.PAE is 0 *and* CR0.PE is 0, then you can't be sure which
> > one triggered the failure.
> Oh, yes that makes sense! Thank you for the explanation.
> I will move it back up.

I think this may be subtle enough to warrant a comment as well, if
you're so inclined.

  reply	other threads:[~2021-06-18 21:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 11:31 [PATCH kvm-unit-tests] svm: Updated cr4 in test_efer to fix report msg Lara Lazier
2021-06-18 18:28 ` Krish Sadhukhan
2021-06-18 19:58   ` Lara Lazier
2021-06-18 20:26     ` Jim Mattson
2021-06-18 20:57       ` Lara Lazier
2021-06-18 21:10         ` Jim Mattson [this message]
2021-06-18 21:20           ` Lara Lazier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALMp9eRDkfHHmRuRuRabRLcNBhudJwb+mhE=WD2tVR016Yq58w@mail.gmail.com' \
    --to=jmattson@google.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=laramglazier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.