From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6F2C33C8C for ; Mon, 6 Jan 2020 20:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9F04214D8 for ; Mon, 6 Jan 2020 20:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NCc+tSWR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbgAFURO (ORCPT ); Mon, 6 Jan 2020 15:17:14 -0500 Received: from mail-il1-f195.google.com ([209.85.166.195]:36728 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbgAFURN (ORCPT ); Mon, 6 Jan 2020 15:17:13 -0500 Received: by mail-il1-f195.google.com with SMTP id b15so43661710iln.3 for ; Mon, 06 Jan 2020 12:17:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LxvwhJJ0uR0l3XlAR6Ya25i11ON7evDplvpGhKU4LZo=; b=NCc+tSWRs4DoBDCc2IweeZQ/X1n5EKwZ4hA9koLfWxjBZi0elUS+ckWbY4YxEZ/bKF TXE53YiO1FSF9lxsO+D5SpWLwFhJaGbfG3I6y6ihNxGuRDsByIXHBwnp8VQZV10ZrYPF JNGgY6LQXJIW9WYui/HJtuXmqAPzvTIQB2/jI6eL/AnfoMsSWPhErI4X4rEckqjVUsVC BmSRf7yOcomjqmZlfdK8Ly8fMnlt0H1ufQBoGYiQu6LH8gP4qT1rEOGiuDNVlwxfPqfq LN06g7d6u+1ivjvWNtPZFoSvydyU2MyCUuE4XXrUI4dTImUMwmh4/R+JkHYtefn12tCP CkWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LxvwhJJ0uR0l3XlAR6Ya25i11ON7evDplvpGhKU4LZo=; b=kksvax7G6xSONgPx4vfKAnh70bAjaCKzWY6CObMsuVnYt3vTg8Q2QwL2+oElEuYVSO FJGJ5Zo8KcoNnRNefeziTBItm3AYwpdkrRsr+1jruyQ/QCI8s5gRbeZb1eYHjPVuKd0L aZpysFXAf48zcHRPCa5E4mXNptgYxD75N2/YijmSdEQ2JpRth7yUKpm9wT4dboKIPDue XAr3CLr5aSbdPQuFrDARVnbiMQgvE9K4J7aADh4u1/kbBUUw6GW7CjXnPHcIoGJPsP4t yxkjgIxQqFl6RDg3MP8VRMxDWR6o0OmC+Qr4X1NR+Le6XdYBpJqChshQf8Y9KAMUAgMM ABTQ== X-Gm-Message-State: APjAAAXY9cG2i/F/isZ3tavXI126DZfUsMZd9PGYTtqX3Nmr/Ae2RUOQ RarPGcWb6tHjnSJ8GWm5GYPAV60i48vXdHOpX2Q8/Q== X-Google-Smtp-Source: APXvYqz+I+w1AKAX4I685EkhXLV0JGNj7Ig7L3KcjNLDo2lQBjrY4YdOG2hhx8MIKccUvvq8iyzLWgCunGxYEoz2vTI= X-Received: by 2002:a05:6e02:8eb:: with SMTP id n11mr89886746ilt.26.1578341832825; Mon, 06 Jan 2020 12:17:12 -0800 (PST) MIME-Version: 1.0 References: <20191211204753.242298-1-pomonis@google.com> <20191211204753.242298-4-pomonis@google.com> In-Reply-To: <20191211204753.242298-4-pomonis@google.com> From: Jim Mattson Date: Mon, 6 Jan 2020 12:17:01 -0800 Message-ID: Subject: Re: [PATCH v2 03/13] KVM: x86: Refactor picdev_write() to prevent Spectre-v1/L1TF attacks To: Marios Pomonis Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , kvm list , LKML , Nick Finco , Andrew Honig , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 12:48 PM Marios Pomonis wrote: > > This fixes a Spectre-v1/L1TF vulnerability in picdev_write(). > It replaces index computations based on the (attacked-controlled) port > number with constants through a minor refactoring. > > Fixes: commit 85f455f7ddbe ("KVM: Add support for in-kernel PIC emulation") > > Signed-off-by: Nick Finco > Signed-off-by: Marios Pomonis > Reviewed-by: Andrew Honig > Cc: stable@vger.kernel.org Reviewed-by: Jim Mattson