All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Mattson <jmattson@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, zxwang42@gmail.com, marcorr@google.com,
	seanjc@google.com, jroedel@suse.de, varad.gautam@suse.com
Subject: Re: [PATCH v2 kvm-unit-tests 2/2] replace tss_descr global with a function
Date: Wed, 20 Oct 2021 14:18:34 -0700	[thread overview]
Message-ID: <CALMp9eRY_YYozTv0EZb5rbr27TJihaW3SpxV-Be=JJt2HYaTYQ@mail.gmail.com> (raw)
In-Reply-To: <0a87132a-f7ea-5483-dd9d-cb8c377af535@redhat.com>

On Wed, Oct 20, 2021 at 2:12 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 20/10/21 22:46, Jim Mattson wrote:
> >> -       vmcs_write(GUEST_LIMIT_TR, tss_descr.limit);
> >> +       vmcs_write(GUEST_LIMIT_TR, 0x67);
> > Isn't the limit still set to 0xFFFF in {cstart,cstart64}.S? And
> > doesn't the VMware backdoor test assume there's room for an I/O
> > permission bitmap?
> >
>
> Yes, but this is just for L2.  The host TR limit is restored to 0x67 on
> every vmexit, and it seemed weird to run L1 and L2 with different limits.

Perhaps you could change the limits in the GDT entries to match?

  reply	other threads:[~2021-10-20 21:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 19:27 [PATCH v2 kvm-unit-tests 0/2] remove tss_descr, replace with a function Paolo Bonzini
2021-10-20 19:27 ` [PATCH v2 kvm-unit-tests 1/2] unify field names and definitions for GDT descriptors Paolo Bonzini
2021-10-21  0:07   ` Marc Orr
2021-10-20 19:27 ` [PATCH v2 kvm-unit-tests 2/2] replace tss_descr global with a function Paolo Bonzini
2021-10-20 20:06   ` Sean Christopherson
2021-10-20 20:46   ` Jim Mattson
2021-10-20 21:12     ` Paolo Bonzini
2021-10-20 21:18       ` Jim Mattson [this message]
2021-10-20 21:31         ` Paolo Bonzini
2021-10-20 22:01           ` Jim Mattson
2021-10-21  7:17             ` Paolo Bonzini
2021-10-21  3:50   ` Marc Orr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALMp9eRY_YYozTv0EZb5rbr27TJihaW3SpxV-Be=JJt2HYaTYQ@mail.gmail.com' \
    --to=jmattson@google.com \
    --cc=jroedel@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=marcorr@google.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=varad.gautam@suse.com \
    --cc=zxwang42@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.