All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Mattson <jmattson@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm list <kvm@vger.kernel.org>
Subject: Re: [PATCH kvm-unit-tests] x86: add tests for MSR_IA32_TSX_CTRL
Date: Wed, 20 Nov 2019 14:21:27 -0800	[thread overview]
Message-ID: <CALMp9eRz_G0rTMO4Omd_s78-=-zbRLGGxHzJsZBFpsfr0ysCgw@mail.gmail.com> (raw)
In-Reply-To: <f5fcab3a-21f3-8025-5773-1bed4ef75f13@redhat.com>

On Wed, Nov 20, 2019 at 2:17 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 20/11/19 23:16, Jim Mattson wrote:
> > On Wed, Nov 20, 2019 at 10:43 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >>
> >> On 20/11/19 19:13, Jim Mattson wrote:
> >>> On Mon, Nov 18, 2019 at 9:29 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >>>>
> >>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>>
> >>> I had to add tsx-ctrl to x86/unittests.cfg:
> >>>
> >>> +[tsx-ctrl]
> >>> +file = tsx-ctrl.flat
> >>> +extra_params = -cpu host
> >>> +groups = tsx-ctrl
> >>> +
> >>>
> >>> With qemu 4.1, I get:
> >>>
> >>> timeout -k 1s --foreground 90s /root/kvm-unit-tests/deps/qemu.sh
> >>> -nodefaults -device pc-testdev -device
> >>> isa-debug-exit,iobase=0xf4,iosize=0x4 -vnc none -serial stdio -device
> >>> pci-testdev -machine accel=kvm -kernel x86/tsx-ctrl.flat -smp 1 -cpu
> >>> host # -initrd /tmp/tmp.7wOLppNO4W
> >>> enabling apic
> >>> SKIP: TSX_CTRL not available
> >>>
> >>> Maybe qemu is masking off ARCH_CAP_TSX_CTRL_MSR? I haven't investigated.
> >>
> >> Yes, you need "-cpu host,migratable=off" if you don't have the
> >> corresponding QEMU patches (which I've only sent today, but just
> >> allowing unmigratable features in extra_params will be okay for you to
> >> test).
> >
> > Okay, that works!
> >
> > enabling apic
> > PASS: TSX_CTRL should be 0
> > PASS: Transactions do not abort
> > PASS: TSX_CTRL hides RTM
> > PASS: TSX_CTRL hides HLE
> > PASS: TSX_CTRL=0 unhides RTM
> > PASS: TSX_CTRL causes transactions to abort
> > PASS: TSX_CTRL=0 causes transactions to succeed
> > SUMMARY: 7 tests
>
> Great, should I merge the patches in 5.5 with your Tested-by annotation?

Please do.

      reply	other threads:[~2019-11-20 22:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-18 17:28 [PATCH kvm-unit-tests] x86: add tests for MSR_IA32_TSX_CTRL Paolo Bonzini
2019-11-20 18:13 ` Jim Mattson
2019-11-20 18:43   ` Paolo Bonzini
2019-11-20 22:16     ` Jim Mattson
2019-11-20 22:17       ` Paolo Bonzini
2019-11-20 22:21         ` Jim Mattson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALMp9eRz_G0rTMO4Omd_s78-=-zbRLGGxHzJsZBFpsfr0ysCgw@mail.gmail.com' \
    --to=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.