From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BC8C83000 for ; Tue, 28 Apr 2020 22:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF35B206D6 for ; Tue, 28 Apr 2020 22:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EYfcSwBK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726812AbgD1WEO (ORCPT ); Tue, 28 Apr 2020 18:04:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725934AbgD1WEO (ORCPT ); Tue, 28 Apr 2020 18:04:14 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31075C03C1AC for ; Tue, 28 Apr 2020 15:04:14 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id i19so25078857ioh.12 for ; Tue, 28 Apr 2020 15:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hdye9Y+HN3Ay3k4lAQbTQjGJKjGjfhnRJ5ClLYqLI5Q=; b=EYfcSwBKoyf1yvsIqjslcUpr811ti1beomA8wAYjwTPxou14WZi54Y1DRkaCZUFbzS fod/drVFx08FoL743YYDcZt006b5fMlrKOhEBMc4mWuSCmaYYwZkmU3OnVT2w56YAGPt dwetTgWPn05l/H7Uw5Q2HAA94rrAsF8o3ibPAdUZJPCtvTuONOnkW2Iou8UMTPASDrh4 VWBxlx9oC3tOZvW+Q7G3fRsF3AmnRSLqL0QMA0x+k9MI6P1D4E51Gs5ZhZqI+EKccIrZ 0JtZZdKuZU3XbuJSvldJMMICbIXaSn86M3joweoUyWG+rjeODIhzGiQL4bfNphcwoJs2 X47w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hdye9Y+HN3Ay3k4lAQbTQjGJKjGjfhnRJ5ClLYqLI5Q=; b=f2F3EZiuPqjISy12iILQhnzxMD93fVZAYE65ZOd4fvZm5OgPhwSWsr0WOYOAeDpHD+ HAS16vpgHes3sD+uo+dZ4L4xjb6IqwiMjFIvHu0KB0DuhZ+u/awsLSvZgV5i5yy+BY3/ KjZ2AqlWPyBu1WdjjINkNUW0+xu4tOaY5L2qZLQ03LY/Ir95AwnKp6RencC0ejawUNOS WiUY1NLOwOIHrO30vWUMh5lmCKrb0nCxnJwkv3xVmni2So7abY/xbJ874n9Hia3X0h56 9kZjYFumSqPy18AD/an1/ZRrH1aO8n63IUu4f6g+jPIl2JV4X2IN9f50D8hJr3RteeCC i80A== X-Gm-Message-State: AGi0PuYizf+TRJLG+OKtTuJaLbCPbUqiY4sIjo4ovd/s58bWsV4tD0Qk Zn4JnKPNPeTN8rtn82UzzSaWEhX1BtU0Qfb1oYLUaA== X-Google-Smtp-Source: APiQypI9Nf6EOOBA5QVkfYCA6/jwvMsAYAzR0B14+Ay30XrCyHLqc0Nyb66cxDFd7jShKchKfrhAeQtEqRe90mQA/zU= X-Received: by 2002:a6b:6318:: with SMTP id p24mr4129450iog.12.1588111453327; Tue, 28 Apr 2020 15:04:13 -0700 (PDT) MIME-Version: 1.0 References: <20200423022550.15113-1-sean.j.christopherson@intel.com> <20200423022550.15113-10-sean.j.christopherson@intel.com> In-Reply-To: <20200423022550.15113-10-sean.j.christopherson@intel.com> From: Jim Mattson Date: Tue, 28 Apr 2020 15:04:02 -0700 Message-ID: Subject: Re: [PATCH 09/13] KVM: nVMX: Prioritize SMI over nested IRQ/NMI To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm list , LKML , Oliver Upton , Peter Shier Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 7:26 PM Sean Christopherson wrote: > > Check for an unblocked SMI in vmx_check_nested_events() so that pending > SMIs are correctly prioritized over IRQs and NMIs when the latter events > will trigger VM-Exit. This also fixes an issue where an SMI that was > marked pending while processing a nested VM-Enter wouldn't trigger an > immediate exit, i.e. would be incorrectly delayed until L2 happened to > take a VM-Exit. > > Fixes: 64d6067057d96 ("KVM: x86: stubs for SMM support") > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/vmx/nested.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c > index 1fdaca5fd93d..8c16b190816b 100644 > --- a/arch/x86/kvm/vmx/nested.c > +++ b/arch/x86/kvm/vmx/nested.c > @@ -3750,6 +3750,12 @@ static int vmx_check_nested_events(struct kvm_vcpu= *vcpu) > return 0; > } > > + if (vcpu->arch.smi_pending && !is_smm(vcpu)) { > + if (block_nested_events) > + return -EBUSY; > + goto no_vmexit; > + } > + >From the SDM, volume 3: =E2=80=A2 System-management interrupts (SMIs), INIT signals, and higher priority events take priority over MTF VM exits. I think this block needs to be moved up.